From: Yisen Zhuang <Yisen.zhuang@huawei.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: <davem@davemloft.net>, <yankejian@huawei.com>,
<huangdaode@hisilicon.com>, <salil.mehta@huawei.com>,
<lisheng011@huawei.com>, <lipeng321@huawei.com>,
<liguozhu@huawei.com>, <arnd@arndb.de>, <xieqianqian@huawei.com>,
<andrew@lunn.ch>, <ivecera@redhat.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>
Subject: Re: [PATCH net 09/10] net: hns: adds limitation for debug port mtu
Date: Tue, 22 Mar 2016 09:19:52 +0800 [thread overview]
Message-ID: <56F09DB8.5010908@huawei.com> (raw)
In-Reply-To: <56F0028D.4070500@cogentembedded.com>
在 2016/3/21 22:17, Sergei Shtylyov 写道:
> Hello.
>
> On 03/21/2016 02:06 PM, Yisen Zhuang wrote:
>
>> From: Kejian Yan <yankejian@huawei.com>
>>
>> If mtu for debug port is set more than 1500, it may cause that packets
>> are dropped by ppe. So maximum value for debug port should be 1500.
>>
>> Signed-off-by: Kejian Yan <yankejian@huawei.com>
>> Signed-off-by: Yisen Zhuang <Yisen.Zhuang@huawei.com>
> [...]
>> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h
>> index a69c8af..a68efd6 100644
>> --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h
>> +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h
>> @@ -28,6 +28,7 @@ struct dsaf_device;
>> #define MAC_MAX_MTU 9600
>> #define MAC_MAX_MTU_V2 9728
>> #define MAC_MIN_MTU 68
>> +#define MAC_MAX_MTU_DBG MAC_DEFAULT_MTU
>
> Please use tabs, not spaces to indent the value, like above
Will fix it in next version.
Thanks,
Yisen
>
> [...]
>
> MBR, Sergei
>
>
> .
>
next prev parent reply other threads:[~2016-03-22 1:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 11:06 [PATCH net 00/10] net: hns: bugs fixed for hns Yisen Zhuang
2016-03-21 11:06 ` [PATCH net 01/10] net: hns: bug fix about ping6 Yisen Zhuang
2016-03-21 15:39 ` David Miller
2016-03-22 0:46 ` Yisen Zhuang
2016-03-21 11:06 ` [PATCH net 02/10] net: hns: fixed portid bug in sending manage pkt Yisen Zhuang
2016-03-21 11:06 ` [PATCH net 03/10] net: hns: add uc match for debug ports Yisen Zhuang
2016-03-21 15:40 ` David Miller
2016-03-22 1:03 ` Yisen Zhuang
2016-03-21 11:06 ` [PATCH net 04/10] net: hns: fixed the bug about GMACs mac setting Yisen Zhuang
2016-03-21 11:06 ` [PATCH net 05/10] net: hns: set xge statistic reg as read only Yisen Zhuang
2016-03-21 11:06 ` [PATCH net 06/10] net: hns: fix return value of the function about rss Yisen Zhuang
2016-03-21 15:42 ` David Miller
2016-03-22 1:16 ` Yisen Zhuang
2016-03-21 11:06 ` [PATCH net 07/10] net: hns: fixes a bug of RSS Yisen Zhuang
2016-03-21 11:06 ` [PATCH net 08/10] net: hns: fix the bug about mtu setting Yisen Zhuang
2016-03-21 11:06 ` [PATCH net 09/10] net: hns: adds limitation for debug port mtu Yisen Zhuang
2016-03-21 14:17 ` Sergei Shtylyov
2016-03-22 1:19 ` Yisen Zhuang [this message]
2016-03-21 11:06 ` [PATCH net 10/10] net: hns: bug fix about the overflow of mss Yisen Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F09DB8.5010908@huawei.com \
--to=yisen.zhuang@huawei.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=huangdaode@hisilicon.com \
--cc=ivecera@redhat.com \
--cc=liguozhu@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lipeng321@huawei.com \
--cc=lisheng011@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=xieqianqian@huawei.com \
--cc=yankejian@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.