All of lore.kernel.org
 help / color / mirror / Atom feed
From: Waiman Long <waiman.long@hpe.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>, <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Ding Tianhong <dingtianhong@huawei.com>,
	Jason Low <jason.low2@hpe.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	"Paul E. McKenney" <paulmck@us.ibm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Will Deacon <Will.Deacon@arm.com>,
	Tim Chen <tim.c.chen@linux.intel.com>
Subject: Re: [PATCH v2 0/4] locking/mutex: Enable optimistic spinning of lock waiter
Date: Mon, 21 Mar 2016 23:19:02 -0400	[thread overview]
Message-ID: <56F0B9A6.4040903@hpe.com> (raw)
In-Reply-To: <20160216085111.GR6357@twins.programming.kicks-ass.net>

On 02/16/2016 03:51 AM, Peter Zijlstra wrote:
> On Fri, Feb 12, 2016 at 12:32:11PM -0500, Waiman Long wrote:
>> My own test on a 4-socket E7-4820 v3 system showed a regression of
>> about 4% in the high_systime workload with Peter's patch which this
>> new patch effectively eliminates.
>>
>> Testing on an 8-socket Westmere-EX server, however, has performance
>> change from -9% to than +140% on the fserver workload of AIM7
>> depending on how the system was set up.
> Subject: [lkp] [locking/mutex] aaca135480: -72.9% fsmark.files_per_sec
>
> My patch also generated the above email.
>
> Please also test that benchmark against this approach.
>

I also got an email from "kernel test robot", it didn't list fsmark at 
all. Instead, the subject was

[lkp] [locking/mutex] 5267438002: +38.9% 
fileio.time.involuntary_context_switches

       4409 ±  1%     +38.9%       6126 ±  2%  
fileio.time.involuntary_context_switches
       6.00 ±  0%     +33.3%       8.00 ±  0%  
fileio.time.percent_of_cpu_this_job_got
      36.06 ±  0%     +43.0%      51.55 ±  0%  fileio.time.system_time
    1828660 ±  0%     -92.5%     137258 ±  0%  
fileio.time.voluntary_context_switches

Given that the number of voluntary context switches dropped by 92.5%, an 
increase in involuntary context switches that is order of magnitude less 
than the voluntary context switches should be OK, I think.

Do you know how to report back that this increase is expected and is 
nothing to worry about? Do I just reply it back?

Cheers,
Longman

  parent reply	other threads:[~2016-03-22  3:19 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-12 17:32 [PATCH v2 0/4] locking/mutex: Enable optimistic spinning of lock waiter Waiman Long
2016-02-12 17:32 ` [PATCH v2 1/4] locking/mutex: Add waiter parameter to mutex_optimistic_spin() Waiman Long
2016-02-12 20:23   ` Peter Zijlstra
2016-02-12 22:14     ` Davidlohr Bueso
2016-02-13 12:10       ` Peter Zijlstra
2016-02-13 18:14         ` Davidlohr Bueso
2016-02-16  2:15       ` Jason Low
2016-02-16  2:22         ` Jason Low
2016-02-16  8:53           ` Peter Zijlstra
2016-02-17  1:40             ` Waiman Long
2016-02-15 22:06     ` Waiman Long
2016-02-12 20:40   ` Peter Zijlstra
2016-02-15 23:55     ` Waiman Long
2016-02-16  3:00       ` Jason Low
2016-02-16  3:30         ` Waiman Long
2016-02-12 22:02   ` Davidlohr Bueso
2016-02-12 22:09     ` Davidlohr Bueso
2016-02-16  0:03     ` Waiman Long
2016-02-12 17:32 ` [PATCH v2 2/4] locking/mutex: Enable optimistic spinning of woken task in wait queue Waiman Long
2016-02-12 17:32 ` [PATCH v2 3/4] locking/mutex: Avoid missed wakeup of mutex waiter Waiman Long
2016-02-12 17:32 ` [PATCH v2 4/4] sched/fair: Abort wakeup when task is no longer in a sleeping state Waiman Long
2016-02-12 20:18   ` Peter Zijlstra
2016-02-12 21:22     ` Waiman Long
2016-02-13 12:09       ` Peter Zijlstra
2016-02-16  8:51 ` [PATCH v2 0/4] locking/mutex: Enable optimistic spinning of lock waiter Peter Zijlstra
2016-02-17  1:39   ` Waiman Long
2016-03-22  3:19   ` Waiman Long [this message]
2016-03-22  9:59     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56F0B9A6.4040903@hpe.com \
    --to=waiman.long@hpe.com \
    --cc=Will.Deacon@arm.com \
    --cc=dave@stgolabs.net \
    --cc=dingtianhong@huawei.com \
    --cc=jason.low2@hpe.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paulmck@us.ibm.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=tim.c.chen@linux.intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.