Re: [PATCH 1/1] [RFC]sparc64: enable cpu hotplug feature

[Allen Pais <allen.pais@oracle.com>]

>>   	return ret;
>>   }
>>
>
> You've made this significantly harder to review and audit by moving the code
> around so much.
>
> Just add the new calls:
>
> 	smp_fill_in_sib_core_maps();
> 	cpu_map_rebuild();
>
> in the existing basic block containing the smp_synchronize_one_tick() call.
>
> Then it's obvious to reviewers what your change is actually doing.

  Sure, I'll fix this and resend.

>>
>> +	set_cpu_online(cpu, false);
>> +
>>   	/* Make sure no interrupts point to this cpu.  */
>>   	fixup_irqs();
>
> This looks like a bug fix, to make sure fixup_irqs() does the right
> thing, right?
>
> All the little bug fixes like this should be split out into separate
> patches.

  I really did not think it was necessary, but I'll split it up as you
said.

Thanks.