From: David Ahern <dsa@cumulusnetworks.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Lance Richardson <lrichard@redhat.com>,
Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [PATCH net] ipv4: initialize flowi4_flags before calling fib_lookup()
Date: Tue, 22 Mar 2016 15:02:56 -0600 [thread overview]
Message-ID: <56F1B300.8070209@cumulusnetworks.com> (raw)
In-Reply-To: <CAM_iQpV6srT84xa4y0WHrKG0mbO2xs=rnKKCx1XB9FtWusxCgw@mail.gmail.com>
On 3/22/16 2:45 PM, Cong Wang wrote:
> @@ -1426,7 +1426,7 @@ int fib_table_lookup(struct fib_table *tb, const
> struct flowi4 *flp,
> nh->nh_flags & RTNH_F_LINKDOWN &&
> !(fib_flags & FIB_LOOKUP_IGNORE_LINKSTATE))
> continue;
> - if (!(flp->flowi4_flags & FLOWI_FLAG_VRFSRC)) {
> + if (!(flp->flowi4_flags & FLOWI_FLAG_SKIP_NH_OIF)) {
> if (flp->flowi4_oif &&
> flp->flowi4_oif != nh->nh_oif)
> continue;
>
> For me, it looks the bug was introduce by commit 35ebf65e851c6d9731abc6362b1.
>
Arguably yes since it added the function without initializing flags.
The commit I referenced (and even the VRF predecessor both of which
originated in the v4.3) is the one introducing use of flow flags to the
lookup. From a stable perspective going back to v4.3 is what matters.
next prev parent reply other threads:[~2016-03-22 21:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 15:31 [PATCH net] ipv4: initialize flowi4_flags before calling fib_lookup() Lance Richardson
2016-03-22 18:29 ` David Ahern
2016-03-22 18:41 ` Lance Richardson
2016-03-22 20:45 ` Cong Wang
2016-03-22 21:02 ` David Ahern [this message]
2016-03-22 21:10 ` Cong Wang
-- strict thread matches above, loose matches on Subject: below --
2016-03-22 18:56 Lance Richardson
2016-03-22 18:58 ` Lance Richardson
2016-03-22 20:03 ` David Miller
2016-03-22 19:00 ` David Ahern
2016-03-22 20:15 ` Eric Dumazet
2016-03-23 11:35 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F1B300.8070209@cumulusnetworks.com \
--to=dsa@cumulusnetworks.com \
--cc=lrichard@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.