From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Liang, Cunming" Subject: Re: [PATCH] ixgbe: fix vector RX can't always set packet_type properly Date: Wed, 23 Mar 2016 10:54:23 +0800 Message-ID: <56F2055F.80905@intel.com> References: <1458657017-22160-1-git-send-email-konstantin.ananyev@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Konstantin Ananyev Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 0DA5129C6 for ; Wed, 23 Mar 2016 03:54:25 +0100 (CET) In-Reply-To: <1458657017-22160-1-git-send-email-konstantin.ananyev@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, On 3/22/2016 10:30 PM, Konstantin Ananyev wrote: > Fixes: 39625417585 ("mbuf: redefine packet type") > > Current vector RX can't always set packet_type properly. > To be more specific: > a) it never sets RTE_PTYPE_L2_ETHER > b) it doesn't handle tunnel ipv4/ipv6 case correctly. > c) it doesn't check is IXGBE_RXDADV_PKTTYPE_ETQF set or not. > While a) is pretty easy to fix, b) and c) are not that straightforward > in terms of SIMD ops (specially b). > So far I wasn't able to make vRX support packet_type properly without > noticeable performance loss. > So for now, just remove that functionality at all from vector RX and > update dev_supported_ptypes_get(). > > Signed-off-by: Konstantin Ananyev > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 4 +--- > drivers/net/ixgbe/ixgbe_rxtx_vec.c | 34 +++++++++++----------------------- > 2 files changed, 12 insertions(+), 26 deletions(-) > > Acked-by: Liang Cunming