[PATCH 0/3] Few st33zp24 fixes

[PATCH 0/3] Few st33zp24 fixes

[Christophe Ricard]

Hi Jarkko,

After my first tentative and as discussed, please find a dedicated
st33zp24 serie intends to provide few fixes on acpi probing and code
style improvement.

Best Regards
Christophe

Christophe Ricard (3):
  tpm/st33zp24/i2c: Drop two useless checks in ACPI probe path
  tpm/st33zp24/spi: Drop two useless checks in ACPI probe path
  tpm/st33zp24: Remove unneeded tpm_reg in get_burstcount

 drivers/char/tpm/st33zp24/i2c.c      | 13 +------------
 drivers/char/tpm/st33zp24/spi.c      | 13 +------------
 drivers/char/tpm/st33zp24/st33zp24.c | 10 +++++-----
 3 files changed, 7 insertions(+), 29 deletions(-)

-- 
2.5.0


------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140

[PATCH 1/3] tpm/st33zp24/i2c: Drop two useless checks in ACPI probe path

[Christophe Ricard]

When st33zp24_i2c_acpi_request_resources() gets called we
already know that the entries in ->acpi_match_table have matched ACPI ID
of the device.
In addition I2C client pointer cannot be NULL in any case (otherwise I2C
core would not call ->probe() for the driver in the first place).

Drop the two useless checks from the driver.

Signed-off-by: Christophe Ricard <christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
---
 drivers/char/tpm/st33zp24/i2c.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/drivers/char/tpm/st33zp24/i2c.c b/drivers/char/tpm/st33zp24/i2c.c
index f179aad..f8e8123 100644
--- a/drivers/char/tpm/st33zp24/i2c.c
+++ b/drivers/char/tpm/st33zp24/i2c.c
@@ -113,19 +113,8 @@ static const struct st33zp24_phy_ops i2c_phy_ops = {
 static int st33zp24_i2c_acpi_request_resources(struct i2c_client *client)
 {
 	struct st33zp24_i2c_phy *phy = i2c_get_clientdata(client);
-	const struct acpi_device_id *id;
 	struct gpio_desc *gpiod_lpcpd;
-	struct device *dev;
-
-	if (!client)
-		return -EINVAL;
-
-	dev = &client->dev;
-
-	/* Match the struct device against a given list of ACPI IDs */
-	id = acpi_match_device(dev->driver->acpi_match_table, dev);
-	if (!id)
-		return -ENODEV;
+	struct device *dev = &client->dev;
 
 	/* Get LPCPD GPIO from ACPI */
 	gpiod_lpcpd = devm_gpiod_get_index(dev, "TPM IO LPCPD", 1,
-- 
2.5.0


------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140

Re: [PATCH 1/3] tpm/st33zp24/i2c: Drop two useless checks in ACPI probe path

[Jarkko Sakkinen]

On Wed, Mar 23, 2016 at 08:55:32AM +0100, Christophe Ricard wrote:
> When st33zp24_i2c_acpi_request_resources() gets called we
> already know that the entries in ->acpi_match_table have matched ACPI ID
> of the device.
> In addition I2C client pointer cannot be NULL in any case (otherwise I2C
> core would not call ->probe() for the driver in the first place).
> 
> Drop the two useless checks from the driver.
> 
> Signed-off-by: Christophe Ricard <christophe-h.ricard-qxv4g6HH51o@public.gmane.org>

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

/Jarkko

> ---
>  drivers/char/tpm/st33zp24/i2c.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/drivers/char/tpm/st33zp24/i2c.c b/drivers/char/tpm/st33zp24/i2c.c
> index f179aad..f8e8123 100644
> --- a/drivers/char/tpm/st33zp24/i2c.c
> +++ b/drivers/char/tpm/st33zp24/i2c.c
> @@ -113,19 +113,8 @@ static const struct st33zp24_phy_ops i2c_phy_ops = {
>  static int st33zp24_i2c_acpi_request_resources(struct i2c_client *client)
>  {
>  	struct st33zp24_i2c_phy *phy = i2c_get_clientdata(client);
> -	const struct acpi_device_id *id;
>  	struct gpio_desc *gpiod_lpcpd;
> -	struct device *dev;
> -
> -	if (!client)
> -		return -EINVAL;
> -
> -	dev = &client->dev;
> -
> -	/* Match the struct device against a given list of ACPI IDs */
> -	id = acpi_match_device(dev->driver->acpi_match_table, dev);
> -	if (!id)
> -		return -ENODEV;
> +	struct device *dev = &client->dev;
>  
>  	/* Get LPCPD GPIO from ACPI */
>  	gpiod_lpcpd = devm_gpiod_get_index(dev, "TPM IO LPCPD", 1,
> -- 
> 2.5.0
> 

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140

[PATCH 2/3] tpm/st33zp24/spi: Drop two useless checks in ACPI probe path

[Christophe Ricard]

When st33zp24_spi_acpi_request_resources() gets called we
already know that the entries in ->acpi_match_table have matched ACPI ID
of the device.
In addition spi_device pointer cannot be NULL in any case (otherwise I2C
core would not call ->probe() for the driver in the first place).

Drop the two useless checks from the driver.

Signed-off-by: Christophe Ricard <christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
---
 drivers/char/tpm/st33zp24/spi.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/drivers/char/tpm/st33zp24/spi.c b/drivers/char/tpm/st33zp24/spi.c
index 6be51ac..608dbc6 100644
--- a/drivers/char/tpm/st33zp24/spi.c
+++ b/drivers/char/tpm/st33zp24/spi.c
@@ -232,19 +232,8 @@ static const struct st33zp24_phy_ops spi_phy_ops = {
 static int st33zp24_spi_acpi_request_resources(struct spi_device *spi_dev)
 {
 	struct st33zp24_spi_phy *phy = spi_get_drvdata(spi_dev);
-	const struct acpi_device_id *id;
 	struct gpio_desc *gpiod_lpcpd;
-	struct device *dev;
-
-	if (!spi_dev)
-		return -EINVAL;
-
-	dev = &spi_dev->dev;
-
-	/* Match the struct device against a given list of ACPI IDs */
-	id = acpi_match_device(dev->driver->acpi_match_table, dev);
-	if (!id)
-		return -ENODEV;
+	struct device *dev = &spi_dev->dev;
 
 	/* Get LPCPD GPIO from ACPI */
 	gpiod_lpcpd = devm_gpiod_get_index(dev, "TPM IO LPCPD", 1,
-- 
2.5.0


------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140

Re: [PATCH 2/3] tpm/st33zp24/spi: Drop two useless checks in ACPI probe path

[Jarkko Sakkinen]

On Wed, Mar 23, 2016 at 08:55:33AM +0100, Christophe Ricard wrote:
> When st33zp24_spi_acpi_request_resources() gets called we
> already know that the entries in ->acpi_match_table have matched ACPI ID
> of the device.
> In addition spi_device pointer cannot be NULL in any case (otherwise I2C
> core would not call ->probe() for the driver in the first place).
> 
> Drop the two useless checks from the driver.
> 
> Signed-off-by: Christophe Ricard <christophe-h.ricard-qxv4g6HH51o@public.gmane.org>

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

/Jarkko

> ---
>  drivers/char/tpm/st33zp24/spi.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/drivers/char/tpm/st33zp24/spi.c b/drivers/char/tpm/st33zp24/spi.c
> index 6be51ac..608dbc6 100644
> --- a/drivers/char/tpm/st33zp24/spi.c
> +++ b/drivers/char/tpm/st33zp24/spi.c
> @@ -232,19 +232,8 @@ static const struct st33zp24_phy_ops spi_phy_ops = {
>  static int st33zp24_spi_acpi_request_resources(struct spi_device *spi_dev)
>  {
>  	struct st33zp24_spi_phy *phy = spi_get_drvdata(spi_dev);
> -	const struct acpi_device_id *id;
>  	struct gpio_desc *gpiod_lpcpd;
> -	struct device *dev;
> -
> -	if (!spi_dev)
> -		return -EINVAL;
> -
> -	dev = &spi_dev->dev;
> -
> -	/* Match the struct device against a given list of ACPI IDs */
> -	id = acpi_match_device(dev->driver->acpi_match_table, dev);
> -	if (!id)
> -		return -ENODEV;
> +	struct device *dev = &spi_dev->dev;
>  
>  	/* Get LPCPD GPIO from ACPI */
>  	gpiod_lpcpd = devm_gpiod_get_index(dev, "TPM IO LPCPD", 1,
> -- 
> 2.5.0
> 

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140

[PATCH 3/3] tpm/st33zp24: Remove unneeded tpm_reg in get_burstcount

[Christophe Ricard]

We can get rid of tpm_reg variable in get_burstcount.

Signed-off-by: Christophe Ricard <christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
---
 drivers/char/tpm/st33zp24/st33zp24.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/char/tpm/st33zp24/st33zp24.c b/drivers/char/tpm/st33zp24/st33zp24.c
index 944d279..9e91ca7 100644
--- a/drivers/char/tpm/st33zp24/st33zp24.c
+++ b/drivers/char/tpm/st33zp24/st33zp24.c
@@ -208,21 +208,21 @@ static int get_burstcount(struct tpm_chip *chip)
 {
 	unsigned long stop;
 	int burstcnt, status;
-	u8 tpm_reg, temp;
+	u8 temp;
 	struct st33zp24_dev *tpm_dev;
 
 	tpm_dev = (struct st33zp24_dev *)TPM_VPRIV(chip);
 
 	stop = jiffies + chip->vendor.timeout_d;
 	do {
-		tpm_reg = TPM_STS + 1;
-		status = tpm_dev->ops->recv(tpm_dev->phy_id, tpm_reg, &temp, 1);
+		status = tpm_dev->ops->recv(tpm_dev->phy_id, TPM_STS + 1,
+					    &temp, 1);
 		if (status < 0)
 			return -EBUSY;
 
-		tpm_reg = TPM_STS + 2;
 		burstcnt = temp;
-		status = tpm_dev->ops->recv(tpm_dev->phy_id, tpm_reg, &temp, 1);
+		status = tpm_dev->ops->recv(tpm_dev->phy_id, TPM_STS + 2,
+					    &temp, 1);
 		if (status < 0)
 			return -EBUSY;
 
-- 
2.5.0


------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140

Re: [PATCH 3/3] tpm/st33zp24: Remove unneeded tpm_reg in get_burstcount

[Jarkko Sakkinen]

On Wed, Mar 23, 2016 at 08:55:34AM +0100, Christophe Ricard wrote:
> We can get rid of tpm_reg variable in get_burstcount.
> 
> Signed-off-by: Christophe Ricard <christophe-h.ricard-qxv4g6HH51o@public.gmane.org>

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

/Jarkko

> ---
>  drivers/char/tpm/st33zp24/st33zp24.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/char/tpm/st33zp24/st33zp24.c b/drivers/char/tpm/st33zp24/st33zp24.c
> index 944d279..9e91ca7 100644
> --- a/drivers/char/tpm/st33zp24/st33zp24.c
> +++ b/drivers/char/tpm/st33zp24/st33zp24.c
> @@ -208,21 +208,21 @@ static int get_burstcount(struct tpm_chip *chip)
>  {
>  	unsigned long stop;
>  	int burstcnt, status;
> -	u8 tpm_reg, temp;
> +	u8 temp;
>  	struct st33zp24_dev *tpm_dev;
>  
>  	tpm_dev = (struct st33zp24_dev *)TPM_VPRIV(chip);
>  
>  	stop = jiffies + chip->vendor.timeout_d;
>  	do {
> -		tpm_reg = TPM_STS + 1;
> -		status = tpm_dev->ops->recv(tpm_dev->phy_id, tpm_reg, &temp, 1);
> +		status = tpm_dev->ops->recv(tpm_dev->phy_id, TPM_STS + 1,
> +					    &temp, 1);
>  		if (status < 0)
>  			return -EBUSY;
>  
> -		tpm_reg = TPM_STS + 2;
>  		burstcnt = temp;
> -		status = tpm_dev->ops->recv(tpm_dev->phy_id, tpm_reg, &temp, 1);
> +		status = tpm_dev->ops->recv(tpm_dev->phy_id, TPM_STS + 2,
> +					    &temp, 1);
>  		if (status < 0)
>  			return -EBUSY;
>  
> -- 
> 2.5.0
> 

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140

Re: [PATCH 0/3] Few st33zp24 fixes

[Jarkko Sakkinen]

On Wed, Mar 23, 2016 at 08:55:31AM +0100, Christophe Ricard wrote:
> Hi Jarkko,
> 
> After my first tentative and as discussed, please find a dedicated
> st33zp24 serie intends to provide few fixes on acpi probing and code
> style improvement.

Thanks. This is also your benefit because these patches probably get
reviewed and merged much faster whereas other patches might go for a few
cycles before taken be accepted.

> Best Regards
> Christophe

/Jarkko

> 
> Christophe Ricard (3):
>   tpm/st33zp24/i2c: Drop two useless checks in ACPI probe path
>   tpm/st33zp24/spi: Drop two useless checks in ACPI probe path
>   tpm/st33zp24: Remove unneeded tpm_reg in get_burstcount
> 
>  drivers/char/tpm/st33zp24/i2c.c      | 13 +------------
>  drivers/char/tpm/st33zp24/spi.c      | 13 +------------
>  drivers/char/tpm/st33zp24/st33zp24.c | 10 +++++-----
>  3 files changed, 7 insertions(+), 29 deletions(-)
> 
> -- 
> 2.5.0
> 

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140

Re: [PATCH 0/3] Few st33zp24 fixes

[Christophe Ricard]

Hi Jarkko,

No problem, i will adapt to your feedback.
I have seen you are working on cleaning up tpm_chip and 
tpm_vendor_specific structures which i am doing as well
since then.

May i ask you to try to keep me in copy of this topic so that i don't 
scratch my head looking at what's on going on the mailing list ?

Thanks a lot.
Best Regards
Christophe

On 23/03/2016 09:17, Jarkko Sakkinen wrote:
> On Wed, Mar 23, 2016 at 08:55:31AM +0100, Christophe Ricard wrote:
>> Hi Jarkko,
>>
>> After my first tentative and as discussed, please find a dedicated
>> st33zp24 serie intends to provide few fixes on acpi probing and code
>> style improvement.
> Thanks. This is also your benefit because these patches probably get
> reviewed and merged much faster whereas other patches might go for a few
> cycles before taken be accepted.
>
>> Best Regards
>> Christophe
> /Jarkko
>
>> Christophe Ricard (3):
>>    tpm/st33zp24/i2c: Drop two useless checks in ACPI probe path
>>    tpm/st33zp24/spi: Drop two useless checks in ACPI probe path
>>    tpm/st33zp24: Remove unneeded tpm_reg in get_burstcount
>>
>>   drivers/char/tpm/st33zp24/i2c.c      | 13 +------------
>>   drivers/char/tpm/st33zp24/spi.c      | 13 +------------
>>   drivers/char/tpm/st33zp24/st33zp24.c | 10 +++++-----
>>   3 files changed, 7 insertions(+), 29 deletions(-)
>>
>> -- 
>> 2.5.0
>>


------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140

Re: [PATCH 0/3] Few st33zp24 fixes

[Jarkko Sakkinen]

On Wed, Mar 23, 2016 at 09:21:06AM +0100, Christophe Ricard wrote:
> Hi Jarkko,
> 
> No problem, i will adapt to your feedback.
> I have seen you are working on cleaning up tpm_chip and tpm_vendor_specific
> structures which i am doing as well
> since then.
> 
> May i ask you to try to keep me in copy of this topic so that i don't
> scratch my head looking at what's on going on the mailing list ?

If you look at my master branch I've pushed them on top. I decided to
put them available to my bleeding edge branch (next is the stable branch
that gets pulled to linux-next) even though they are still undergoing
review because the changes are so obvious.

They might get updated/changed based on review comments.

/Jarkko


> Thanks a lot.
> Best Regards
> Christophe
> 
> On 23/03/2016 09:17, Jarkko Sakkinen wrote:
> >On Wed, Mar 23, 2016 at 08:55:31AM +0100, Christophe Ricard wrote:
> >>Hi Jarkko,
> >>
> >>After my first tentative and as discussed, please find a dedicated
> >>st33zp24 serie intends to provide few fixes on acpi probing and code
> >>style improvement.
> >Thanks. This is also your benefit because these patches probably get
> >reviewed and merged much faster whereas other patches might go for a few
> >cycles before taken be accepted.
> >
> >>Best Regards
> >>Christophe
> >/Jarkko
> >
> >>Christophe Ricard (3):
> >>   tpm/st33zp24/i2c: Drop two useless checks in ACPI probe path
> >>   tpm/st33zp24/spi: Drop two useless checks in ACPI probe path
> >>   tpm/st33zp24: Remove unneeded tpm_reg in get_burstcount
> >>
> >>  drivers/char/tpm/st33zp24/i2c.c      | 13 +------------
> >>  drivers/char/tpm/st33zp24/spi.c      | 13 +------------
> >>  drivers/char/tpm/st33zp24/st33zp24.c | 10 +++++-----
> >>  3 files changed, 7 insertions(+), 29 deletions(-)
> >>
> >>-- 
> >>2.5.0
> >>
> 

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140

Re: [PATCH] tpm: drop int_queue from tpm_vendor_specific

[Christophe Ricard]

On Tue, Mar 22, 2016 at 06:20:09AM +0200, Jarkko Sakkinen wrote:
> Drop field int_queue from tpm_vendor_specific as it is used only by
> tpm_tis. Probably all of the fields should be eventually dropped and
> moved to the private structures of different drivers but it is better to
> do this one step at a time in order not to break anything.
>
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@...>

Don't you think read_queue could be dropped instead and merge with int_queue.
I think they are both used for the same purpose and don't really see a mean to keep 2 queue.

What do you think ?

Best Regards
Christophe


------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140

Re: [PATCH] tpm: drop int_queue from tpm_vendor_specific

[Jarkko Sakkinen]

On Wed, Mar 23, 2016 at 10:58:08PM +0100, Christophe Ricard wrote:
> On Tue, Mar 22, 2016 at 06:20:09AM +0200, Jarkko Sakkinen wrote:
> >Drop field int_queue from tpm_vendor_specific as it is used only by
> >tpm_tis. Probably all of the fields should be eventually dropped and
> >moved to the private structures of different drivers but it is better to
> >do this one step at a time in order not to break anything.
> >
> >Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@...>
> 
> Don't you think read_queue could be dropped instead and merge with int_queue.
> I think they are both used for the same purpose and don't really see a mean to keep 2 queue.
> 
> What do you think ?

Both should be dropped from tpm_vendor_specific.

> Best Regards
> Christophe

/Jarkko

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140

Re: [PATCH 0/3] Few st33zp24 fixes

[Jarkko Sakkinen]

On Wed, Mar 23, 2016 at 08:55:31AM +0100, Christophe Ricard wrote:
> Hi Jarkko,
> 
> After my first tentative and as discussed, please find a dedicated
> st33zp24 serie intends to provide few fixes on acpi probing and code
> style improvement.
> 
> Best Regards
> Christophe
> 
> Christophe Ricard (3):
>   tpm/st33zp24/i2c: Drop two useless checks in ACPI probe path
>   tpm/st33zp24/spi: Drop two useless checks in ACPI probe path
>   tpm/st33zp24: Remove unneeded tpm_reg in get_burstcount

I've applied these patches to my master branch and at some point
merge them to next.

/Jarkko

> 
>  drivers/char/tpm/st33zp24/i2c.c      | 13 +------------
>  drivers/char/tpm/st33zp24/spi.c      | 13 +------------
>  drivers/char/tpm/st33zp24/st33zp24.c | 10 +++++-----
>  3 files changed, 7 insertions(+), 29 deletions(-)
> 
> -- 
> 2.5.0
> 

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140