From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Justin Maggard <jmaggard10@gmail.com>
Cc: Tejun Heo <tj@kernel.org>,
linux-ide@vger.kernel.org, hdegoede@redhat.com,
mikpelinux@gmail.com
Subject: Re: failures due to "libata: disable forced PORTS_IMPL for >= AHCI 1.3 patch"
Date: Wed, 23 Mar 2016 19:06:25 +0000 [thread overview]
Message-ID: <56F2E931.7010805@linaro.org> (raw)
In-Reply-To: <CAKgsxVQ8HQKNWYNBr3FtKS=iyn838UW6TG5NDeacAg7ZKEx_gA@mail.gmail.com>
On 23/03/16 18:28, Justin Maggard wrote:
> On Wed, Mar 23, 2016 at 9:36 AM, Srinivas Kandagatla
> <srinivas.kandagatla@linaro.org> wrote:
>> Hi Tejun,
>>
>> Its bit late but just found that commit 566d18 "libata: disable forced
>> PORTS_IMPL for >= AHCI 1.3" is breaking AHCI on Qualcomm APQ8064 platforms
>> in the mainline kernel (arch/arm/boot/dts/qcom-apq8064.dtsi).
>>
>> This platform uses "generic-ahci" platform driver and reports AHCI version
>> as 0x10300, and PORTS_IMPL is never set, so the existing workaround was
>> correct for this platform, however the latest patch broken this.
>>
>> There are few ways to fix this issue,
>>
>> 1> Add new compatible string to achi_platform driver so that this platform
>> can force the port_map,
>>
>> Or
>>
>> 2> Have a generic dt binding to force the port map.
>>
>
> A generic dt binding is probably a better way forward. The Annapurna
> Alpine platform seems to have the same issue.
+1 for generic bindings.
I suspected that other platforms would also hit the same issue.
--srini
>
> -Justin
>
next prev parent reply other threads:[~2016-03-23 19:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 16:36 failures due to "libata: disable forced PORTS_IMPL for >= AHCI 1.3 patch" Srinivas Kandagatla
2016-03-23 18:28 ` Justin Maggard
2016-03-23 19:06 ` Srinivas Kandagatla [this message]
2016-03-24 19:14 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F2E931.7010805@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=hdegoede@redhat.com \
--cc=jmaggard10@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=mikpelinux@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.