From: Eric Blake <eblake@redhat.com>
To: Veronia <veroniabahaa@gmail.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH] util: move declarations out of qemu-common.h
Date: Wed, 23 Mar 2016 18:18:30 -0600 [thread overview]
Message-ID: <56F33256.7070500@redhat.com> (raw)
In-Reply-To: <56F33205.50905@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 728 bytes --]
On 03/23/2016 06:17 PM, Eric Blake wrote:
> On 03/20/2016 08:43 AM, Veronia wrote:
>>
>> Signed-off-by: Veronia Bahaa<veronia@veroniabahaa@gmail.com>
>
> Space before <. 'git commit -s' (or 'git commit --amend -s' on an
> existing commit) will space things correctly if your ~/.gitconfig is
> correct; if you are typing the S-o-b by hand, I recommend figuring out
> how to get git to do it for you.
Oh, and I also suggest you fix your 'git send-email' settings to use the
same name as your S-o-b line (that is, you want the From: to say Veronia
Bahaa, to match the same spelling you used later on).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-03-24 0:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-20 14:43 [Qemu-devel] [PATCH] util: move declarations out of qemu-common.h Veronia
2016-03-24 0:17 ` Eric Blake
2016-03-24 0:18 ` Eric Blake [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-03-20 17:16 veroniabahaa
2016-03-21 17:50 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F33256.7070500@redhat.com \
--to=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=veroniabahaa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.