Re: [openbsd] 2.02-beta3: build fails - getroot.c:(.text+0x2b): undefined reference to `getrawpartition'

[Andrei Borzenkov <arvidjaar@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 983 bytes --]

14.03.2016 21:19, Jiri B пишет:
> 
>>>>> Another thing - 'INSTALL' file says >= autoconf 2.60 is needed but
>>>>> it is >= 2.62 otherwise there is:
>>>>>
>>>>>   "error: possibly undefined macro: AS_ECHO"
>>>>>
>>>>
>>>> Indeed. According to git log, AS_ECHO appeared first in 2.61a. What
>>>> version you have?
>>>
>>> IIUC it was firstly available in "normal" autoconf release in 2.62.
>>>
>>
>> This does not answer my question - what autoconf version your system
>> ships with (i.e. - do we need to change configure.ac or simply update
>> INSTALL)?
> 
> IMO it would be ok to update INSTALL file. I had following autoconf
> versions:
> 
> autoconf-2.13p3
> autoconf-2.52p5
> autoconf-2.59p4
> autoconf-2.60p4
> autoconf-2.61p4
> autoconf-2.62p1
> autoconf-2.63p0
> autoconf-2.65p0
> autoconf-2.67p0
> autoconf-2.68p0
> autoconf-2.69p1
> 

It is silly to bump version requirement in this case where AS_ECHO is
not really needed. Could you retest attached patch with 2.60?




[-- Attachment #2: no-as_echo.patch --]
[-- Type: text/x-patch, Size: 966 bytes --]

From: Andrei Borzenkov <arvidjaar@gmail.com>
Subject: [PATCH] configure: replace AS_ECHO with echo in program transform

INSTALL requires autoconf 2.60, but AS_ECHO appeared first in 2.61a. It is
used just once to transform program names; in this case arguments are known
plain string so simple `echo' is safe to use. This avoids bumping required
autoconf version without real reason.

Reported by: Jiri B <jirib@devio.us>

---
 acinclude.m4 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/acinclude.m4 b/acinclude.m4
index 526f97a..e659b1e 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -421,5 +421,5 @@ else
 dnl Create an output variable with the transformed name of a GRUB utility
 dnl program.
 AC_DEFUN([grub_TRANSFORM],[dnl
-AC_SUBST(AS_TR_SH([$1]), [`AS_ECHO([$1]) | sed "$program_transform_name"`])dnl
+AC_SUBST(AS_TR_SH([$1]), [`echo [$1] | sed "$program_transform_name"`])dnl
 ])
-- 
tg: (f4d35d4..) u/no_as_echo (depends on: master)