From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60989)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1aj6vp-0005vx-Bu
	for qemu-devel@nongnu.org; Thu, 24 Mar 2016 11:12:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1aj6vj-000114-Jw
	for qemu-devel@nongnu.org; Thu, 24 Mar 2016 11:12:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54741)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1aj6vj-00010u-El
	for qemu-devel@nongnu.org; Thu, 24 Mar 2016 11:12:11 -0400
References: <1458728792-15779-1-git-send-email-den@openvz.org>
	<1458728792-15779-2-git-send-email-den@openvz.org>
	<56F2FDE5.5020908@redhat.com> <56F3B249.50605@virtuozzo.com>
	<56F3CE14.80300@redhat.com> <56F3EDD8.6040602@virtuozzo.com>
	<56F3F498.30809@redhat.com> <56F40393.20505@virtuozzo.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <56F403C7.6070901@redhat.com>
Date: Thu, 24 Mar 2016 16:12:07 +0100
MIME-Version: 1.0
In-Reply-To: <56F40393.20505@virtuozzo.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/3] ide: don't loose pending dma state
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Butsykin <pbutsykin@virtuozzo.com>, "Denis V. Lunev" <den@openvz.org>, qemu-devel@nongnu.org
Cc: John Snow <jsnow@redhat.com>



On 24/03/2016 16:11, Pavel Butsykin wrote:
>>
> You want something like this:
> dma_cb()
> {
> ...
>     if (ret < 0) {
>         if (ide_handle_rw_error(s, -ret, ide_dma_cmd_to_retry(s))) {
>             return;
>         }
>     }
> ...
> }
> 
> static void ide_bmdma_pre_save(void *opaque)
> {
> ...
>     if (!(bm->status & BM_STATUS_DMAING) && bm->dma_cb) {
>         bm->bus->error_status = ide_dma_cmd_to_retry(bmdma_active_if(bm));
>     }
> ...
> }

Yes, that would do.

Paolo