From: Mats Karrman <mats.dev.list@gmail.com>
To: John Kacur <jkacur@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>
Cc: RT <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH][rt-tests] cyclictest: Make the tracemark option imply notrace
Date: Thu, 24 Mar 2016 16:57:31 +0100 [thread overview]
Message-ID: <56F40E6B.4050107@gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1603241608370.8641@riemann>
On 2016-03-24 16:24, John Kacur wrote:
>
> On Thu, 24 Mar 2016, Luiz Capitulino wrote:
>
>> On Thu, 24 Mar 2016 15:44:39 +0100 (CET)
>> John Kacur <jkacur@redhat.com> wrote:
>>
...
>>> Therefore turn --notrace on if --tracemark is invoked even if the user
>>> doesn't explicitly request this.
>> I'm not necessarily against this, but at the same time I think
>> I prefer options doing only one thing.
> Maybe think about it a little differently. The option implies a certain
> consistent state. So, the option really only does do one thing, it puts
> cyclictest in the correct state as required. If we don't do this, someone
> is sure to use the --tracemark option without --notrace, and some
> unexpected things are going to occur.
>
Another alternative is to exit with an error if conflicting options are
used.
// Mats
next prev parent reply other threads:[~2016-03-24 15:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 14:44 [PATCH][rt-tests] cyclictest: Make the tracemark option imply notrace John Kacur
2016-03-24 14:52 ` Luiz Capitulino
2016-03-24 15:24 ` John Kacur
2016-03-24 15:57 ` Mats Karrman [this message]
2016-03-24 16:07 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F40E6B.4050107@gmail.com \
--to=mats.dev.list@gmail.com \
--cc=jkacur@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.