All of lore.kernel.org
 help / color / mirror / Atom feed
From: afaerber@suse.de (Andreas Färber)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM64: dts: amlogic: add Hardkernel ODROID-C2
Date: Thu, 24 Mar 2016 17:57:26 +0100	[thread overview]
Message-ID: <56F41C76.8090805@suse.de> (raw)
In-Reply-To: <8055578.HDz4P7ZJ9W@wuerfel>

Am 24.03.2016 um 13:58 schrieb Arnd Bergmann:
> On Wednesday 23 March 2016 11:33:32 Kevin Hilman wrote:
>> +/ {
>> +       compatible = "hardkernel,odroid-c2", "amlogic,meson-gxbb";
>> +       model = "Hardkernel ODROID-C2";
>> +       
>> +       chosen {
>> +               stdout-path = "serial0:115200n8";
>> +       };
>> +
>> +       memory at 0 {
>> +               device_type = "memory";
>> +               reg = <0x0 0x0 0x0 0x80000000>;
>> +       };
>> +};
>> +
>> +&uart_AO {
>> +       status = "okay";
>> +};
>>
> 
> Shouldn't this also add the serial0 alias?
> 
> It seems that the .dtsi file accidentally sets an alias to a disabled
> device, which isn't really valid. Can you fix that when adding the
> .dts?

Hm, would it be any better to not disable either of the serials and
leave the aliases in the .dtsi?

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N?rnberg)

  reply	other threads:[~2016-03-24 16:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-23 18:33 [PATCH 1/3] Documentation: devicetree: amlogic: Document P20x and ODROID-C2 boards Kevin Hilman
2016-03-23 18:33 ` [PATCH 2/3] ARM64: dts: amlogic: add Hardkernel ODROID-C2 Kevin Hilman
2016-03-24 12:58   ` Arnd Bergmann
2016-03-24 16:57     ` Andreas Färber [this message]
2016-03-24 17:16       ` Kevin Hilman
2016-03-24 17:26         ` Andreas Färber
2016-03-24 19:53           ` Arnd Bergmann
2016-03-23 18:33 ` [PATCH 3/3] ARM64: dts: amlogic: Add P200/P201 boards Kevin Hilman
2016-03-24 16:55 ` [PATCH 1/3] Documentation: devicetree: amlogic: Document P20x and ODROID-C2 boards Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56F41C76.8090805@suse.de \
    --to=afaerber@suse.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.