Re: [Qemu-devel] [PATCH 2/2] tap: vhost busy polling support

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 901 bytes --]

On 03/20/2016 11:25 PM, Jason Wang wrote:
> This patch add the capability of basic vhost net busy polling which is
> supported by recent kernel. User could configure the maximum number of
> us that could be spent on busy polling through a new property of tap
> "vhost_poll_us".
> 
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---

> +++ b/qapi-schema.json
> @@ -2532,7 +2532,8 @@
>      '*vhostfd':    'str',
>      '*vhostfds':   'str',
>      '*vhostforce': 'bool',
> -    '*queues':     'uint32'} }
> +    '*queues':     'uint32',
> +    '*vhost_poll_us': 'uint32'} }

Missing documentation.

New interfaces should prefer '-' over '_'; but this is an existing
interface where we already have 'vnet_hdr', so intra-command consistency
makes your naming okay.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]