From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ajKro-0002Ge-4v for mharc-qemu-trivial@gnu.org; Fri, 25 Mar 2016 02:05:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajKrl-0002C8-M1 for qemu-trivial@nongnu.org; Fri, 25 Mar 2016 02:05:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ajKrk-0002LI-Si for qemu-trivial@nongnu.org; Fri, 25 Mar 2016 02:05:01 -0400 Received: from [59.151.112.132] (port=46918 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajKrg-0002KW-A3; Fri, 25 Mar 2016 02:04:56 -0400 X-IronPort-AV: E=Sophos;i="5.22,518,1449504000"; d="scan'208";a="4957081" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 25 Mar 2016 14:04:42 +0800 Received: from G08CNEXCHPEKD03.g08.fujitsu.local (unknown [10.167.33.85]) by cn.fujitsu.com (Postfix) with ESMTP id 13C4C408D264; Fri, 25 Mar 2016 14:04:36 +0800 (CST) Received: from [10.167.226.69] (10.167.226.69) by G08CNEXCHPEKD03.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.279.2; Fri, 25 Mar 2016 14:04:35 +0800 To: Paolo Bonzini , References: <1458814461-5387-1-git-send-email-caoj.fnst@cn.fujitsu.com> <56F3CEBE.7060002@redhat.com> From: Cao jin Message-ID: <56F4D578.5040108@cn.fujitsu.com> Date: Fri, 25 Mar 2016 14:06:48 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <56F3CEBE.7060002@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.167.226.69] X-yoursite-MailScanner-ID: 13C4C408D264.ACA5F X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: caoj.fnst@cn.fujitsu.com X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 59.151.112.132 Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org, eblake@redhat.com, armbru@redhat.com Subject: Re: [Qemu-trivial] [PATCH] qdev property: cleanup X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2016 06:05:02 -0000 On 03/24/2016 07:25 PM, Paolo Bonzini wrote: > > >> A question about legacy property: I don`t see legacy property is really >> used in the code, so, why still add legacy property to object? > > It's used here: > > static void qdev_print_props(Monitor *mon, DeviceState *dev, Property *props, > int indent) Thanks Paolo, I saw here, and then I thought the property is added and just be printed out, seems for no real benefit("really used"). Now I think I see where I was wrong. Thanks. BTW, is this patch right? -- Yours Sincerely, Cao jin From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47702) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajKrj-0002AY-WB for qemu-devel@nongnu.org; Fri, 25 Mar 2016 02:05:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ajKrg-0002Kr-NU for qemu-devel@nongnu.org; Fri, 25 Mar 2016 02:04:59 -0400 References: <1458814461-5387-1-git-send-email-caoj.fnst@cn.fujitsu.com> <56F3CEBE.7060002@redhat.com> From: Cao jin Message-ID: <56F4D578.5040108@cn.fujitsu.com> Date: Fri, 25 Mar 2016 14:06:48 +0800 MIME-Version: 1.0 In-Reply-To: <56F3CEBE.7060002@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qdev property: cleanup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org, armbru@redhat.com On 03/24/2016 07:25 PM, Paolo Bonzini wrote: > > >> A question about legacy property: I don`t see legacy property is really >> used in the code, so, why still add legacy property to object? > > It's used here: > > static void qdev_print_props(Monitor *mon, DeviceState *dev, Property *props, > int indent) Thanks Paolo, I saw here, and then I thought the property is added and just be printed out, seems for no real benefit("really used"). Now I think I see where I was wrong. Thanks. BTW, is this patch right? -- Yours Sincerely, Cao jin