All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Yaowei Bai <baiyaowei@cmss.chinamobile.com>,
	Dongsheng Yang <dongsheng.yang@easystack.cn>
Cc: dwmw2@infradead.org, computersforpeace@gmail.com,
	boris.brezillon@free-electrons.com,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] drivers/mtd: make several functions return bool
Date: Fri, 25 Mar 2016 08:57:59 +0100	[thread overview]
Message-ID: <56F4EF87.4000003@nod.at> (raw)
In-Reply-To: <20160325063153.GA3319@yaowei-K42JY>

Am 25.03.2016 um 07:31 schrieb Yaowei Bai:
> On Fri, Mar 25, 2016 at 10:54:51AM +0800, Dongsheng Yang wrote:
>> ccing: Brian and Richard
>>
>> Hi Yao,
>>     Is that really necessary? I am not sure how much benefit we can
>> achieve from this change.
>> Could you explain more?
> 
> Yes, according to these functions' name, a boolean return value is more
> suitable and matchable.
> 
> Also personally think this change maybe benfit function's return value 
> storage in the stack when called on certain architectures.

On which archs? And what exactly is the benefit?
I agree that bool might be a better choice for new functions
but here you're touching existing and working(!) code.
The only outcome is git history pollution that makes git blame
less efficient.

Thanks,
//richard

  parent reply	other threads:[~2016-03-25  7:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-25  2:41 [PATCH 0/5] drivers/mtd: make several functions return bool Yaowei Bai
2016-03-25  2:41 ` [PATCH 1/5] drivers/mtd: mtd_is_partition can be boolean Yaowei Bai
2016-03-25  2:41 ` [PATCH 2/5] drivers/mtd: cfi_interleave_supported " Yaowei Bai
2016-03-25  2:41 ` [PATCH 3/5] drivers/mtd: map_bankwidth_supported " Yaowei Bai
2016-03-25  2:41 ` [PATCH 4/5] drivers/mtd: mtd_nand_has_bch " Yaowei Bai
2016-03-25  2:41 ` [PATCH 5/5] drivers/mtd/nand: nand_opcode_8bits " Yaowei Bai
2016-03-25  2:54 ` [PATCH 0/5] drivers/mtd: make several functions return bool Dongsheng Yang
2016-03-25  6:31   ` Yaowei Bai
2016-03-25  7:51     ` Boris Brezillon
2016-03-25  8:42       ` Yaowei Bai
2016-03-25  7:57     ` Richard Weinberger [this message]
2016-03-25  8:41       ` Yaowei Bai
2016-03-25  8:58       ` Boris Brezillon
2016-03-25  9:24         ` Yaowei Bai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56F4EF87.4000003@nod.at \
    --to=richard@nod.at \
    --cc=baiyaowei@cmss.chinamobile.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=dongsheng.yang@easystack.cn \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.