From: David Picard <davepiq@yahoo.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/qwt : added support for Qt5.
Date: Fri, 25 Mar 2016 12:08:16 +0100 [thread overview]
Message-ID: <56F51C20.4080505@yahoo.fr> (raw)
In-Reply-To: <20160325105155.071f73ae@free-electrons.com>
Hello,
OK, thanks for your help and patience. It was very instructive.
Cheers,
David.
Le 25/03/2016 10:51, Thomas Petazzoni a ?crit :
> Hello,
>
> On Thu, 24 Mar 2016 21:19:51 +0100, David Picard wrote:
>
>> + depends on (BR2_PACKAGE_HAS_LIBGLES && BR2_PACKAGE_HAS_LIBEG) || \
>> + BR2_PACKAGE_QT5_GL_AVAILABLE
>
> I know I told you to use this, but in fact I think a more correct
> dependency is:
>
> (BR2_PACKAGE_HAS_LIBGLES && BR2_PACKAGE_HAS_LIBEGL && BR2_PACKAGE_QT) || \
> (BR2_PACKAGE_QT5_GL_AVAILABLE && BR2_PACKAGE_QT5)
>
> so that we are sure that if we're using Qt, we have the dependencies
> that are needed to have OpenGL support in Qt, and if we have Qt5, we
> have the dependencies that are needed to have OpenGL support in Qt5.
>
> I've applied after fixing this.
>
> Also, after applying, I noticed there was a typo: BR2_PACKAGE_HAS_LIBEG
> in your patch should have been BR2_PACKAGE_HAS_LIBEGL. I've fixed that
> up with a following commit, as I only noticed while replying to this
> e-mail.
>
> Thanks!
>
> Thomas
>
next prev parent reply other threads:[~2016-03-25 11:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 20:19 [Buildroot] [PATCH 1/2] package/qwt : prepared package for other versions of Qt David Picard
2016-03-24 20:19 ` [Buildroot] [PATCH 2/2] package/qwt : added support for Qt5 David Picard
2016-03-25 9:51 ` Thomas Petazzoni
2016-03-25 11:08 ` David Picard [this message]
2016-03-25 9:48 ` [Buildroot] [PATCH 1/2] package/qwt : prepared package for other versions of Qt Thomas Petazzoni
2016-03-25 14:46 ` David Picard
2016-03-25 15:30 ` Thomas Petazzoni
2016-03-25 16:16 ` David Picard
2016-03-26 12:35 ` Arnout Vandecappelle
-- strict thread matches above, loose matches on Subject: below --
2016-03-24 13:36 David Picard
2016-03-24 13:36 ` [Buildroot] [PATCH 2/2] package/qwt : added support for Qt5 David Picard
2016-03-16 17:37 [Buildroot] [PATCH 1/2] package/qwt : prepared package for other versions of Qt David Picard
2016-03-16 17:37 ` [Buildroot] [PATCH 2/2] package/qwt : added support for Qt5 David Picard
2016-03-20 22:17 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F51C20.4080505@yahoo.fr \
--to=davepiq@yahoo.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.