From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753155AbcCYPId (ORCPT ); Fri, 25 Mar 2016 11:08:33 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:24777 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751989AbcCYPIc (ORCPT ); Fri, 25 Mar 2016 11:08:32 -0400 Subject: Re: [PATCH 2/2] xen/x86: Call cpu_startup_entry(CPUHP_AP_ONLINE_IDLE) from xen_play_dead() To: Konrad Rzeszutek Wilk References: <1458219805-13197-1-git-send-email-boris.ostrovsky@oracle.com> <1458219805-13197-3-git-send-email-boris.ostrovsky@oracle.com> <20160325145358.GC17902@char.us.oracle.com> Cc: david.vrabel@citrix.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org From: Boris Ostrovsky Message-ID: <56F55470.5090004@oracle.com> Date: Fri, 25 Mar 2016 11:08:32 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20160325145358.GC17902@char.us.oracle.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/25/2016 10:53 AM, Konrad Rzeszutek Wilk wrote: > On Thu, Mar 17, 2016 at 09:03:25AM -0400, Boris Ostrovsky wrote: >> This call has always been missing from xen_play dead() but until >> recently this was rather benign. With new cpu hotplug framework >> however this call is required, otherwise a hot-plugged CPU will not > Could you include the commit id of the 'new cpu hotplug' in case > anybody wants to backport this? Sure. It's commit 8df3e07e7f21 ("cpu/hotplug: Let upcoming cpu bring itself fully up"). Do you (or David) want me to re-send it? -boris > > Thanks! >> be properly brough up (by never calling cpuhp_online_idle()) >> >> Signed-off-by: Boris Ostrovsky >> --- >> arch/x86/xen/smp.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/arch/x86/xen/smp.c b/arch/x86/xen/smp.c >> index 3c6d17f..719cf29 100644 >> --- a/arch/x86/xen/smp.c >> +++ b/arch/x86/xen/smp.c >> @@ -545,6 +545,8 @@ static void xen_play_dead(void) /* used only with HOTPLUG_CPU */ >> * data back is to call: >> */ >> tick_nohz_idle_enter(); >> + >> + cpu_startup_entry(CPUHP_AP_ONLINE_IDLE); >> } >> >> #else /* !CONFIG_HOTPLUG_CPU */ >> -- >> 1.7.1 >> From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH 2/2] xen/x86: Call cpu_startup_entry(CPUHP_AP_ONLINE_IDLE) from xen_play_dead() Date: Fri, 25 Mar 2016 11:08:32 -0400 Message-ID: <56F55470.5090004@oracle.com> References: <1458219805-13197-1-git-send-email-boris.ostrovsky@oracle.com> <1458219805-13197-3-git-send-email-boris.ostrovsky@oracle.com> <20160325145358.GC17902@char.us.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ajTLk-0003X2-Cw for xen-devel@lists.xenproject.org; Fri, 25 Mar 2016 15:08:32 +0000 In-Reply-To: <20160325145358.GC17902@char.us.oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Konrad Rzeszutek Wilk Cc: xen-devel@lists.xenproject.org, david.vrabel@citrix.com, linux-kernel@vger.kernel.org List-Id: xen-devel@lists.xenproject.org T24gMDMvMjUvMjAxNiAxMDo1MyBBTSwgS29ucmFkIFJ6ZXN6dXRlayBXaWxrIHdyb3RlOgo+IE9u IFRodSwgTWFyIDE3LCAyMDE2IGF0IDA5OjAzOjI1QU0gLTA0MDAsIEJvcmlzIE9zdHJvdnNreSB3 cm90ZToKPj4gVGhpcyBjYWxsIGhhcyBhbHdheXMgYmVlbiBtaXNzaW5nIGZyb20geGVuX3BsYXkg ZGVhZCgpIGJ1dCB1bnRpbAo+PiByZWNlbnRseSB0aGlzIHdhcyByYXRoZXIgYmVuaWduLiBXaXRo IG5ldyBjcHUgaG90cGx1ZyBmcmFtZXdvcmsKPj4gaG93ZXZlciB0aGlzIGNhbGwgaXMgcmVxdWly ZWQsIG90aGVyd2lzZSBhIGhvdC1wbHVnZ2VkIENQVSB3aWxsIG5vdAo+IENvdWxkIHlvdSBpbmNs dWRlIHRoZSBjb21taXQgaWQgb2YgdGhlICduZXcgY3B1IGhvdHBsdWcnIGluIGNhc2UKPiBhbnli b2R5IHdhbnRzIHRvIGJhY2twb3J0IHRoaXM/CgpTdXJlLgoKSXQncyBjb21taXQgOGRmM2UwN2U3 ZjIxICgiY3B1L2hvdHBsdWc6IExldCB1cGNvbWluZyBjcHUgYnJpbmcgaXRzZWxmIApmdWxseSB1 cCIpLgoKRG8geW91IChvciBEYXZpZCkgd2FudCBtZSB0byByZS1zZW5kIGl0PwoKLWJvcmlzCgoK Cj4KPiBUaGFua3MhCj4+IGJlIHByb3Blcmx5IGJyb3VnaCB1cCAoYnkgbmV2ZXIgY2FsbGluZyBj cHVocF9vbmxpbmVfaWRsZSgpKQo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBCb3JpcyBPc3Ryb3Zza3kg PGJvcmlzLm9zdHJvdnNreUBvcmFjbGUuY29tPgo+PiAtLS0KPj4gICBhcmNoL3g4Ni94ZW4vc21w LmMgfCAgICAyICsrCj4+ICAgMSBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDAgZGVs ZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9hcmNoL3g4Ni94ZW4vc21wLmMgYi9hcmNoL3g4 Ni94ZW4vc21wLmMKPj4gaW5kZXggM2M2ZDE3Zi4uNzE5Y2YyOSAxMDA2NDQKPj4gLS0tIGEvYXJj aC94ODYveGVuL3NtcC5jCj4+ICsrKyBiL2FyY2gveDg2L3hlbi9zbXAuYwo+PiBAQCAtNTQ1LDYg KzU0NSw4IEBAIHN0YXRpYyB2b2lkIHhlbl9wbGF5X2RlYWQodm9pZCkgLyogdXNlZCBvbmx5IHdp dGggSE9UUExVR19DUFUgKi8KPj4gICAJICogZGF0YSBiYWNrIGlzIHRvIGNhbGw6Cj4+ICAgCSAq Lwo+PiAgIAl0aWNrX25vaHpfaWRsZV9lbnRlcigpOwo+PiArCj4+ICsJY3B1X3N0YXJ0dXBfZW50 cnkoQ1BVSFBfQVBfT05MSU5FX0lETEUpOwo+PiAgIH0KPj4gICAKPj4gICAjZWxzZSAvKiAhQ09O RklHX0hPVFBMVUdfQ1BVICovCj4+IC0tIAo+PiAxLjcuMQo+PgoKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVu LWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cDovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==