From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [RFC PATCH 1/2] build: add debug menu to Kconfig Date: Fri, 25 Mar 2016 15:59:06 -0500 Message-ID: <56F5A69A.4070006@cardoe.com> References: <1458838099-12053-1-git-send-email-cardoe@cardoe.com> <20160325194200.GC14689@char.us.oracle.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9192091178061809791==" Return-path: In-Reply-To: <20160325194200.GC14689@char.us.oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Konrad Rzeszutek Wilk Cc: Keir Fraser , Tim Deegan , Ian Jackson , Jan Beulich , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============9192091178061809791== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="q9LcwGqSmPnfWTu5aRrpiw4q2qb9vsFEk" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --q9LcwGqSmPnfWTu5aRrpiw4q2qb9vsFEk Content-Type: multipart/mixed; boundary="bovmqXrdgrIxuVD2shaNkWWFFKPdHmtQ0" From: Doug Goldstein To: Konrad Rzeszutek Wilk Cc: xen-devel@lists.xen.org, Ian Jackson , Keir Fraser , Jan Beulich , Tim Deegan Message-ID: <56F5A69A.4070006@cardoe.com> Subject: Re: [Xen-devel] [RFC PATCH 1/2] build: add debug menu to Kconfig References: <1458838099-12053-1-git-send-email-cardoe@cardoe.com> <20160325194200.GC14689@char.us.oracle.com> In-Reply-To: <20160325194200.GC14689@char.us.oracle.com> --bovmqXrdgrIxuVD2shaNkWWFFKPdHmtQ0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 3/25/16 2:42 PM, Konrad Rzeszutek Wilk wrote: > On Thu, Mar 24, 2016 at 11:48:18AM -0500, Doug Goldstein wrote: >> There are a number of debugging options for Xen so the idea is to have= a >> menu to group them all together. >> >> Signed-off-by: Doug Goldstein >> --- >> This is more of an RFC than a merge request. If this seems reasonable = I'll >> add all the other debugging options under this menu as well. Obviously= if >> this seems reasonable and the patch is fine we can merge it and I'll s= ubmit >> the others as a follow up. >=20 > There would be more I presume - the lock profile, gcov, crash, etc.. Yes. I just wanted to do one to get an idea of how people felt about the menu. >=20 > And with the 'randconfig' that means we can turn on/off various options= and > find interesting dependencies (if any). Exactly. We've found a number of interesting cases with randconfig already and fixed them. I previously checked some of them against some of the stable trees and found the combos failed so Travis CI + randconfig are finding issues but not commonly used ones. Anyway back to this patch. >=20 >=20 > Anyhow back to this patch. :-D >=20 > The usual method for distros of compiling an Xen with and without debug= (like Xenserver) > is: >=20 This feels very... http://xkcd.com/1172/ > make %{?_smp_mflags} max_phys_cpus=3D384 xen tools So two comments on this line. 1) ick! "xen" and "tools" targets have been marked as Legacy since October 5th 2005! 2) That's been broken since I got rid of max_phys_cpus and moved it to CONFIG_NR_CPUS (I think that's the name). spec files for things like busybox include the config file and just copy it in before running make cp someplace/config.release xen/.config make %{?_smp_mflags} dist-xen dist-tools >=20 > make %{?_smp_mflags} -C xen clean why use the directory here but not in the first step? make %{?_smp_mflags} clean-xen would be the matching target > make %{?_smp_mflags} -C xen debug=3Dy max_phys_cpus=3D384 ok mind blown. We build xen in the first step with the Legacy target and then changing to the directory here. >=20 > It would be preferrable to still have this functionality. As in, if we > do 'debug=3Dy' then verbose=3Dy and frame_pointer=3Dy are automatically= enabled? >=20 > Is that something the Kconfig magic can still do? I could do some wizard-y to allow debug=3Dy to turn things on. Not sure i= f the lowercase will work but I can definitely think of a way to make the uppercase DEBUG=3Dy work. But at that point I don't see the point. I see the point of debug=3Dy since that's a top level thing. >> >> >> CC: Ian Jackson >> CC: Jan Beulich >> CC: Keir Fraser >> CC: Tim Deegan >> --- >> xen/Kconfig | 2 ++ >> xen/Kconfig.debug | 6 ++++++ >> 2 files changed, 8 insertions(+) >> create mode 100644 xen/Kconfig.debug >> >> diff --git a/xen/Kconfig b/xen/Kconfig >> index fa8b27c..0fe7a1a 100644 >> --- a/xen/Kconfig >> +++ b/xen/Kconfig >> @@ -26,3 +26,5 @@ config DEFCONFIG_LIST >> config EXPERT >> string >> option env=3D"XEN_CONFIG_EXPERT" >> + >> +source "Kconfig.debug" >> diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug >> new file mode 100644 >> index 0000000..36890bd >> --- /dev/null >> +++ b/xen/Kconfig.debug >> @@ -0,0 +1,6 @@ >> + >> +menuconfig DEBUG >> + bool "Debugging Options" >> + ---help--- >> + If you want to debug Xen say Y and select any additional debugging= >> + support options. >=20 > .. You can also add: >=20 > Should not be used for production builds. >=20 > Note that any _ASSERTS_ in the code without debug are emitted. >=20 >> --=20 >> 2.7.3 >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xen.org >> http://lists.xen.org/xen-devel --=20 Doug Goldstein --bovmqXrdgrIxuVD2shaNkWWFFKPdHmtQ0-- --q9LcwGqSmPnfWTu5aRrpiw4q2qb9vsFEk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJW9aacXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUclIP/RvA8M5NWsHeCORcKBEdMeTH M+bSunc4bb+RCzk08gsXaMl56gHkNs/poetG1niJuZYRV1/X/IwtCYWoQ907nrBX hi7KOt+H7NhLnlJkfYBmGaMtTRq3WBUmRlvydb6X6nyrtjnRSYMaTg5+XOIRDHa5 L80QNMZnNHl4V6q5fGYv8lN6T82gr2KuAdARS35AuvyGnWkSGq+xaWQSvuNm0IZO +OF2fIepo+d4mDJ1SPwTVooqnlUwPBMhaSQ5fnSrgD29B2pW+edwveDh0GwTH6dK ImpGPHc/W+vKVupQ3aRtPZmx/Ro5YvSMC77SVROZbj8rfU0iMTAQ2XEoiJpJTcbu dGH9D6/nJLOtA2psyqIqgyoBr7EKb7RXydoH5o8l/p+oQX52bJPqVXo5pPumxV/Z fHHq9l7aPEWnwIl70d8sm47EoXeHt0H8Jh9bcVDZ41AZ4Vy6T0G20fbL1K1v6wKO /5bJlnJq+6RS3Hn4BiBolHr+wNCO84mxjV8ux3NBH8bESujeDgHjKMvClT1kCua3 jrPFWUPt26npXzpPztK8JeHdV1u3i9eIDt5LdHiumeB4d0SE4L4q4NYXZnwQO9gP DSoAPDLDaVwRuxEVAA2lM9U+/BIA0u1TRnZeH+eP/RwiJxeam875zXL3/QweeI4l fsSWRo4RfxBQL4T51Aut =2JRQ -----END PGP SIGNATURE----- --q9LcwGqSmPnfWTu5aRrpiw4q2qb9vsFEk-- --===============9192091178061809791== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============9192091178061809791==--