Re: [PATCH 13/15] dbus: Add message filter public API.

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1146 bytes --]

Hi Andrew,

On 03/25/2016 06:45 PM, Andrzej Zaborowski wrote:
> Hi Denis,
>
> On 24 March 2016 at 19:04, Denis Kenzior <denkenz@gmail.com> wrote:
>> Does it make sense to make glob-match values part of the tree?
>>
>> For example, I can install watch 1 with:
>> type='signal', path='/'
>>
>> and watch 2 with:
>> type='signal', sender='org.foo', path='/'
>>
>> Right now it seems we will generate 2 AddMatch cases for the above, even
>> though watch 2 is already covered by watch 1.
>
> Ah, good point.  I think we could handle that also with the current
> structure if we allow the nodes to be added to the tree in any order
> necessary, so that the "sender='org.foo'" could be a child of
> "path='/'" in specific cases.  This wouldn't add any cost to the
> filtering of incoming signals, only to adding new rules, what do you
> think?
>

Could work, but my first thought is that it would cause lots of 
additional processing, since you'd be trying all possible permutations. 
  Given that we have 4-5 rules on average that's a lot of possibilities 
to try.  Or were you thinking something else?

Regards,
-Denis