From: Marek Vasut <marex@denx.de>
To: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc: linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Alexey Brodkin <abrodkin@synopsys.com>
Subject: ARC dw-mshc binding compat string
Date: Sat, 26 Mar 2016 11:14:57 +0100 [thread overview]
Message-ID: <56F66121.8050507@denx.de> (raw)
Hi!
I noticed that arch/arc/boot/dts/axs10x_mb.dtsi uses "altr," prefix in
the DT compatible string:
mmc@0x15000 {
compatible = "altr,socfpga-dw-mshc";
reg = < 0x15000 0x400 >;
num-slots = < 1 >;
fifo-depth = < 16 >;
card-detect-delay = < 200 >;
clocks = <&apbclk>, <&mmcclk>;
clock-names = "biu", "ciu";
interrupts = < 7 >;
bus-width = < 4 >;
};
I don't think this is OK, since ARC is unrelated to Altera, which is
what the "altr," prefix stands for. I think the socfpga-dw-mshc shim
should be extended with another compatibility string, something like
"snps,arc-dw-mshc" and the axs10x_mb.dtsi should be adjusted
accordingly. What do you think ?
--
Best regards,
Marek Vasut
next reply other threads:[~2016-03-26 10:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-26 10:14 Marek Vasut [this message]
2016-03-26 17:26 ` ARC dw-mshc binding compat string Vladimir Zapolskiy
2016-03-26 17:26 ` Vladimir Zapolskiy
[not found] ` <56F6C639.5000301-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
2016-03-26 17:30 ` Marek Vasut
2016-03-26 17:30 ` Marek Vasut
2016-03-26 17:46 ` Alexey Brodkin
2016-03-26 17:46 ` Alexey Brodkin
2016-03-26 17:52 ` Vladimir Zapolskiy
2016-03-26 17:52 ` Vladimir Zapolskiy
[not found] ` <56F6CC68.5040408-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
2016-03-26 18:10 ` Marek Vasut
2016-03-26 18:10 ` Marek Vasut
2016-03-26 18:16 ` Vladimir Zapolskiy
2016-03-26 18:16 ` Vladimir Zapolskiy
[not found] ` <56F6D1E9.3050606-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
2016-03-26 19:52 ` Marek Vasut
2016-03-26 19:52 ` Marek Vasut
[not found] ` <56F6E860.8070207-ynQEQJNshbs@public.gmane.org>
2016-03-26 20:12 ` Vladimir Zapolskiy
2016-03-26 20:12 ` Vladimir Zapolskiy
[not found] ` <56F6ED41.5020908-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
2016-03-26 20:24 ` Marek Vasut
2016-03-26 20:24 ` Marek Vasut
2016-03-28 9:37 ` Alexey Brodkin
[not found] ` <1459157818.4785.5.camel-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2016-03-28 10:34 ` Jaehoon Chung
2016-03-28 10:34 ` Jaehoon Chung
2016-03-28 10:55 ` Alexey Brodkin
2016-03-28 11:44 ` Jaehoon Chung
2016-03-28 12:43 ` Rob Herring
2016-03-28 12:52 ` Marek Vasut
2016-03-28 12:50 ` Marek Vasut
2016-03-28 16:16 ` Vladimir Zapolskiy
2016-03-28 19:00 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F66121.8050507@denx.de \
--to=marex@denx.de \
--cc=abrodkin@synopsys.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.