From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40258) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ak7NM-0004h1-RY for qemu-devel@nongnu.org; Sun, 27 Mar 2016 05:52:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ak7NJ-0003S2-JT for qemu-devel@nongnu.org; Sun, 27 Mar 2016 05:52:52 -0400 Received: from out11.biz.mail.alibaba.com ([205.204.114.131]:49228) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ak7NI-0003RZ-TV for qemu-devel@nongnu.org; Sun, 27 Mar 2016 05:52:49 -0400 Message-ID: <56F7AE69.5030205@emindsoft.com.cn> Date: Sun, 27 Mar 2016 17:56:57 +0800 From: Chen Gang MIME-Version: 1.0 References: <1458142686-4405-1-git-send-email-chengang@emindsoft.com.cn> <56E9811B.90006@emindsoft.com.cn> In-Reply-To: <56E9811B.90006@emindsoft.com.cn> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] target-tilegx: Support dumping working flow instructions and registers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: rth@twiddle.net, peter.maydell@linaro.org, cmetcalf@ezchip.com, laurent@vivier.eu Cc: walt@tilera.com, qemu-devel@nongnu.org Hello all: Is this patch helpful? If it shouldn't be merged into our master branch, please let me know, I shall treat it as my own local patch (when I update my local master branch, I'll merge it at last). Thanks. On 3/16/16 23:51, Chen Gang wrote: > Hello all: > > It is only for analyzing issues, I guess it is helpful, so I send it, > welcome any other ideas, suggestions, and completions. > > And next, I shall continue to improve the floating point instruction > features: "remove (u)int64_to_float64 from fdouble implementation". > > Thanks. > > On 3/16/16 23:38, chengang@emindsoft.com.cn wrote: >> From: Chen Gang >> >> It is only for debug and analyzing tilegx qemu related issues. >> >> Signed-off-by: Chen Gang >> --- >> target-tilegx/helper.c | 34 ++++++++++++++++++++++++++++++++++ >> target-tilegx/helper.h | 2 ++ >> target-tilegx/translate.c | 37 +++++++++++++++++++++++++++++++++++++ >> 3 files changed, 73 insertions(+) >> >> diff --git a/target-tilegx/helper.c b/target-tilegx/helper.c >> index 616c5c7..c7cfe66 100644 >> --- a/target-tilegx/helper.c >> +++ b/target-tilegx/helper.c >> @@ -160,3 +160,37 @@ uint64_t helper_cmul2(uint64_t srca, uint64_t srcb, int shift, int round) >> >> return deposit32(realr >> shift, 16, 16, imagr >> shift); >> } >> + >> +extern char **debug_buf; >> + >> +#define DEBUG_DUMP_REGS >> + >> +static void dump_regs(CPUTLGState *env, int idx) >> +{ >> +#ifdef DEBUG_DUMP_REGS >> + int i; >> + >> + if (debug_buf[idx][2] == '\n') { >> + for (i = 0; i < TILEGX_R_COUNT; i++) { >> + if (!(i % 4)) { >> + fprintf(stderr, "\n"); >> + } >> + fprintf(stderr, "r%2.2u = %16.16lx, ", i, env->regs[i]); >> + } >> + fprintf(stderr, "\n"); >> + for (i = 0; i < TILEGX_SPR_COUNT; i++) { >> + if (!(i % 8)) { >> + fprintf(stderr, "\n"); >> + } >> + fprintf(stderr, "s%2.2u = %16.16lx, ", i, env->spregs[i]); >> + } >> + fprintf(stderr, "\n"); >> + } >> +#endif >> +} >> + >> +void helper_print_step(CPUTLGState *env, int idx) >> +{ >> + fprintf(stderr, "%s", debug_buf[idx]); >> + dump_regs(env, idx); >> +} >> diff --git a/target-tilegx/helper.h b/target-tilegx/helper.h >> index 9281d0f..74f796a 100644 >> --- a/target-tilegx/helper.h >> +++ b/target-tilegx/helper.h >> @@ -24,3 +24,5 @@ DEF_HELPER_FLAGS_2(v1shrs, TCG_CALL_NO_RWG_SE, i64, i64, i64) >> DEF_HELPER_FLAGS_2(v2shl, TCG_CALL_NO_RWG_SE, i64, i64, i64) >> DEF_HELPER_FLAGS_2(v2shru, TCG_CALL_NO_RWG_SE, i64, i64, i64) >> DEF_HELPER_FLAGS_2(v2shrs, TCG_CALL_NO_RWG_SE, i64, i64, i64) >> + >> +DEF_HELPER_2(print_step, void, env, int) >> diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c >> index 03918eb..8489494 100644 >> --- a/target-tilegx/translate.c >> +++ b/target-tilegx/translate.c >> @@ -47,6 +47,43 @@ static const char * const reg_names[64] = { >> "sn", "idn0", "idn1", "udn0", "udn1", "udn2", "udn2", "zero" >> }; >> >> +#define STATIC_DEBUG >> + >> +char **debug_buf; >> + >> +#ifdef STATIC_DEBUG >> + >> +#include >> + >> +#define qemu_log_mask(flag, fmt, ...) debug_print(flag, fmt, ##__VA_ARGS__) >> + >> +static int debug_idx; >> + >> +extern void debug_print(int flag, const char *fmt, ...); >> + >> +void debug_print(int flag, const char *fmt, ...) >> +{ >> + va_list args; >> + char buf[0x400]; >> + TCGv_i32 tmp; >> + >> + va_start(args, fmt); >> + vsprintf(buf, fmt, args); >> + va_end(args); >> + >> + if (!debug_buf) { >> + debug_buf = malloc(sizeof(char *) * 0x400000); >> + } >> + debug_buf[debug_idx] = malloc(strlen(buf) + 1); >> + strcpy(debug_buf[debug_idx], buf); >> + >> + tmp = tcg_const_i32(debug_idx++); >> + gen_helper_print_step(cpu_env, tmp); >> + tcg_temp_free_i32(tmp); >> +} >> + >> +#endif >> + >> /* Modified registers are cached in temporaries until the end of the bundle. */ >> typedef struct { >> unsigned reg; >> > -- Chen Gang (陈刚) Managing Natural Environments is the Duty of Human Beings.