From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH] drm/rockchip: vop: Don't reject empty modesets Date: Mon, 28 Mar 2016 14:40:05 +0800 Message-ID: <56F8D1C5.6060504@rock-chips.com> References: <1458300123-6397-1-git-send-email-tomeu.vizoso@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1458300123-6397-1-git-send-email-tomeu.vizoso@collabora.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomeu Vizoso , linux-kernel@vger.kernel.org Cc: linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gMjAxNuW5tDAz5pyIMTjml6UgMTk6MjIsIFRvbWV1IFZpem9zbyB3cm90ZToKPiBTbyB0aGF0 IHdoZW4gRFJNX0lPQ1RMX01PREVfU0VUQ1JUQyBpcyBjYWxsZWQgd2l0aG91dCBhIEZCIG5vciBt b2RlLCB0aGUKPiBDUlRDIGdldHMgZGlzYWJsZWQuCj4KPiBTaWduZWQtb2ZmLWJ5OiBUb21ldSBW aXpvc28gPHRvbWV1LnZpem9zb0Bjb2xsYWJvcmEuY29tPgo+IExpbms6IGh0dHA6Ly9sa21sLmtl cm5lbC5vcmcvZy9DQUFPYnNLQXYrMDVpaDVVKz00a2ljX05zakdNaGZ4WWhlSFI4eFhYbWFjWnMr cDVTSHdAbWFpbC5nbWFpbC5jb20KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9y b2NrY2hpcF9kcm1fdm9wLmMgfCAzIC0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDMgZGVsZXRpb25z KC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2Ry bV92b3AuYyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fdm9wLmMKPiBp bmRleCBmZDM3MDU0OGQ3ZDcuLjVlNTdmNWIyZTRiMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3AuYwo+IEBAIC04ODUsOSArODg1LDYgQEAgc3RhdGlj IGJvb2wgdm9wX2NydGNfbW9kZV9maXh1cChzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gICB7Cj4g ICAJc3RydWN0IHZvcCAqdm9wID0gdG9fdm9wKGNydGMpOwo+ICAgCj4gLQlpZiAoYWRqdXN0ZWRf bW9kZS0+aHRvdGFsID09IDAgfHwgYWRqdXN0ZWRfbW9kZS0+dnRvdGFsID09IDApCj4gLQkJcmV0 dXJuIGZhbHNlOwo+IC0KPiAgIAlhZGp1c3RlZF9tb2RlLT5jbG9jayA9Cj4gICAJCWNsa19yb3Vu ZF9yYXRlKHZvcC0+ZGNsaywgbW9kZS0+Y2xvY2sgKiAxMDAwKSAvIDEwMDA7Cj4gICAKQXBwbGll ZCB0byBteSBkcm0tZml4ZXMsIFRoYW5rcy4KCi0tIArvvK1hcmsgWWFvCgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Mon, 28 Mar 2016 14:40:05 +0800 Subject: [PATCH] drm/rockchip: vop: Don't reject empty modesets In-Reply-To: <1458300123-6397-1-git-send-email-tomeu.vizoso@collabora.com> References: <1458300123-6397-1-git-send-email-tomeu.vizoso@collabora.com> Message-ID: <56F8D1C5.6060504@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016?03?18? 19:22, Tomeu Vizoso wrote: > So that when DRM_IOCTL_MODE_SETCRTC is called without a FB nor mode, the > CRTC gets disabled. > > Signed-off-by: Tomeu Vizoso > Link: http://lkml.kernel.org/g/CAAObsKAv+05ih5U+=4kic_NsjGMhfxYheHR8xXXmacZs+p5SHw at mail.gmail.com > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index fd370548d7d7..5e57f5b2e4b0 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -885,9 +885,6 @@ static bool vop_crtc_mode_fixup(struct drm_crtc *crtc, > { > struct vop *vop = to_vop(crtc); > > - if (adjusted_mode->htotal == 0 || adjusted_mode->vtotal == 0) > - return false; > - > adjusted_mode->clock = > clk_round_rate(vop->dclk, mode->clock * 1000) / 1000; > Applied to my drm-fixes, Thanks. -- ?ark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754577AbcC1GkT (ORCPT ); Mon, 28 Mar 2016 02:40:19 -0400 Received: from regular1.263xmail.com ([211.150.99.135]:50518 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753416AbcC1GkO (ORCPT ); Mon, 28 Mar 2016 02:40:14 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-rockchip@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <56F8D1C5.6060504@rock-chips.com> Date: Mon, 28 Mar 2016 14:40:05 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Tomeu Vizoso , linux-kernel@vger.kernel.org CC: David Airlie , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] drm/rockchip: vop: Don't reject empty modesets References: <1458300123-6397-1-git-send-email-tomeu.vizoso@collabora.com> In-Reply-To: <1458300123-6397-1-git-send-email-tomeu.vizoso@collabora.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年03月18日 19:22, Tomeu Vizoso wrote: > So that when DRM_IOCTL_MODE_SETCRTC is called without a FB nor mode, the > CRTC gets disabled. > > Signed-off-by: Tomeu Vizoso > Link: http://lkml.kernel.org/g/CAAObsKAv+05ih5U+=4kic_NsjGMhfxYheHR8xXXmacZs+p5SHw@mail.gmail.com > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index fd370548d7d7..5e57f5b2e4b0 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -885,9 +885,6 @@ static bool vop_crtc_mode_fixup(struct drm_crtc *crtc, > { > struct vop *vop = to_vop(crtc); > > - if (adjusted_mode->htotal == 0 || adjusted_mode->vtotal == 0) > - return false; > - > adjusted_mode->clock = > clk_round_rate(vop->dclk, mode->clock * 1000) / 1000; > Applied to my drm-fixes, Thanks. -- Ｍark Yao