From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH v2 1/5] drm/rockchip: dw_hdmi: Call drm_encoder_cleanup() in error path Date: Mon, 28 Mar 2016 14:45:02 +0800 Message-ID: <56F8D2EE.4080004@rock-chips.com> References: <1457388054-23077-1-git-send-email-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1457388054-23077-1-git-send-email-dianders@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Douglas Anderson , David Airlie , linux@arm.linux.org.uk, Heiko Stuebner Cc: john@keeping.me.uk, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gMjAxNuW5tDAz5pyIMDjml6UgMDY6MDAsIERvdWdsYXMgQW5kZXJzb24gd3JvdGU6Cj4gVGhl IGRybV9lbmNvZGVyX2NsZWFudXAoKSB3YXMgbWlzc2luZyBib3RoIGZyb20gdGhlIGVycm9yIHBh dGggb2YKPiBkd19oZG1pX3JvY2tjaGlwX2JpbmQoKS4gIFRoaXMgY2F1c2VkIGEgY3Jhc2ggd2hl biBzbHViX2RlYnVnIHdhcwo+IGVuYWJsZWQgYW5kIHdlIGVuZGVkIHVwIGRlZmVycmluZyBwcm9i ZSBvZiBIRE1JIGF0IGJvb3QuCj4KPiBUaGlzIGNhbGwgaXNuJ3QgbmVlZGVkIGZyb20gdW5iaW5k KCkgYmVjYXVzZSBpZiBkd19oZG1pX2JpbmQoKSByZXR1cm5zCj4gbm8gZXJyb3IgdGhlbiBpdCB0 YWtlcyBvdmVyIHRoZSBqb2Igb2YgZnJlZWluZyB0aGUgZW5jb2RlciAoaW4KPiBkd19oZG1pX3Vu YmluZCkuCj4KPiBTaWduZWQtb2ZmLWJ5OiBEb3VnbGFzIEFuZGVyc29uIDxkaWFuZGVyc0BjaHJv bWl1bS5vcmc+CgpIaSBEb3VnbGFzCgppdCBzZWVtcyBoYXMgbm8gZG91YnQgb24gdGhlc2UgcGF0 Y2gsIGFuZCBpdCB3b3JrcyBvbiBteSBib2FyZCwgU28gSSdkIApsaWtlIHRvIGFwcGx5IGZvbGxv d2luZyB0aHJlZSBwYXRjaGVzLgoKW1BBVENIIHYyIDEvNV0gZHJtL3JvY2tjaGlwOiBkd19oZG1p OiBDYWxsIGRybV9lbmNvZGVyX2NsZWFudXAoKSBpbiAKZXJyb3IgcGF0aApbUEFUQ0ggdjIgMy81 XSBkcm0vcm9ja2NoaXA6IHZvcDogRml4IHZvcCBjcnRjIGNsZWFudXAKW1BBVENIIHYyIDQvNV0g ZHJtL3JvY2tjaGlwOiBkd19oZG1pOiBEb24ndCBjYWxsIHBsYXRmb3JtX3NldF9kcnZkYXRhKCkK ClRoYW5rcyBmb3IgeW91ciBmaXhlcy4KCi0tIO+8rWFyayBZYW8KCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Mon, 28 Mar 2016 14:45:02 +0800 Subject: [PATCH v2 1/5] drm/rockchip: dw_hdmi: Call drm_encoder_cleanup() in error path In-Reply-To: <1457388054-23077-1-git-send-email-dianders@chromium.org> References: <1457388054-23077-1-git-send-email-dianders@chromium.org> Message-ID: <56F8D2EE.4080004@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016?03?08? 06:00, Douglas Anderson wrote: > The drm_encoder_cleanup() was missing both from the error path of > dw_hdmi_rockchip_bind(). This caused a crash when slub_debug was > enabled and we ended up deferring probe of HDMI at boot. > > This call isn't needed from unbind() because if dw_hdmi_bind() returns > no error then it takes over the job of freeing the encoder (in > dw_hdmi_unbind). > > Signed-off-by: Douglas Anderson Hi Douglas it seems has no doubt on these patch, and it works on my board, So I'd like to apply following three patches. [PATCH v2 1/5] drm/rockchip: dw_hdmi: Call drm_encoder_cleanup() in error path [PATCH v2 3/5] drm/rockchip: vop: Fix vop crtc cleanup [PATCH v2 4/5] drm/rockchip: dw_hdmi: Don't call platform_set_drvdata() Thanks for your fixes. -- ?ark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754654AbcC1Gp1 (ORCPT ); Mon, 28 Mar 2016 02:45:27 -0400 Received: from regular1.263xmail.com ([211.150.99.132]:37478 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754173AbcC1GpR (ORCPT ); Mon, 28 Mar 2016 02:45:17 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <56F8D2EE.4080004@rock-chips.com> Date: Mon, 28 Mar 2016 14:45:02 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Douglas Anderson , David Airlie , linux@arm.linux.org.uk, Heiko Stuebner CC: Daniel Kurtz , linux-rockchip@lists.infradead.org, john@keeping.me.uk, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/5] drm/rockchip: dw_hdmi: Call drm_encoder_cleanup() in error path References: <1457388054-23077-1-git-send-email-dianders@chromium.org> In-Reply-To: <1457388054-23077-1-git-send-email-dianders@chromium.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年03月08日 06:00, Douglas Anderson wrote: > The drm_encoder_cleanup() was missing both from the error path of > dw_hdmi_rockchip_bind(). This caused a crash when slub_debug was > enabled and we ended up deferring probe of HDMI at boot. > > This call isn't needed from unbind() because if dw_hdmi_bind() returns > no error then it takes over the job of freeing the encoder (in > dw_hdmi_unbind). > > Signed-off-by: Douglas Anderson Hi Douglas it seems has no doubt on these patch, and it works on my board, So I'd like to apply following three patches. [PATCH v2 1/5] drm/rockchip: dw_hdmi: Call drm_encoder_cleanup() in error path [PATCH v2 3/5] drm/rockchip: vop: Fix vop crtc cleanup [PATCH v2 4/5] drm/rockchip: dw_hdmi: Don't call platform_set_drvdata() Thanks for your fixes. -- Ｍark Yao