From: Jonathan Cameron <jic23@kernel.org>
To: Richard Weinberger <richard@nod.at>, linux-kernel@vger.kernel.org
Cc: linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>
Subject: Re: [PATCH 8/8] iio: imu: Fix inv_mpu6050 dependencies
Date: Mon, 28 Mar 2016 10:03:16 +0100 [thread overview]
Message-ID: <56F8F354.3050207@kernel.org> (raw)
In-Reply-To: <1458945655-5027-8-git-send-email-richard@nod.at>
On 25/03/16 22:40, Richard Weinberger wrote:
> Not all archs have io memory.
> Instead of selecting I2C_MUX (and bypassing the HAS_IOMEM dependency)
> depend directly on it.
>
> Fixes the following kconfig warning:
> warning: (MEDIA_SUBDRV_AUTOSELECT && VIDEO_CX231XX && INV_MPU6050_I2C) selects I2C_MUX which has unmet direct dependencies (I2C && HAS_IOMEM)
> And this build error:
> ERROR: "devm_ioremap_resource" [drivers/i2c/muxes/i2c-mux-reg.ko] undefined!
> ERROR: "of_address_to_resource" [drivers/i2c/muxes/i2c-mux-reg.ko] undefined!
>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Hartmut Knaack <knaack.h@gmx.de>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Peter Meerwald <pmeerw@pmeerw.net>
> Signed-off-by: Richard Weinberger <richard@nod.at>
Applied to the fixes-togreg-post-rc1 branch of iio.git.
Thanks,
Jonathan
> ---
> drivers/iio/imu/inv_mpu6050/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iio/imu/inv_mpu6050/Kconfig b/drivers/iio/imu/inv_mpu6050/Kconfig
> index a7f557a..847455a 100644
> --- a/drivers/iio/imu/inv_mpu6050/Kconfig
> +++ b/drivers/iio/imu/inv_mpu6050/Kconfig
> @@ -9,9 +9,8 @@ config INV_MPU6050_IIO
>
> config INV_MPU6050_I2C
> tristate "Invensense MPU6050 devices (I2C)"
> - depends on I2C
> + depends on I2C_MUX
> select INV_MPU6050_IIO
> - select I2C_MUX
> select REGMAP_I2C
> help
> This driver supports the Invensense MPU6050 devices.
>
next prev parent reply other threads:[~2016-03-28 9:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-25 22:40 [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies Richard Weinberger
2016-03-25 22:40 ` [PATCH 2/8] mailbox: Fix rockchip dependencies Richard Weinberger
2016-03-25 22:40 ` [PATCH 3/8] phy: Fix phy-omap-control dependencies Richard Weinberger
2016-03-25 22:40 ` [PATCH 4/8] phy: Fix phy-bcm-cygnus-pcie dependencies Richard Weinberger
2016-03-25 22:40 ` [PATCH 5/8] nvmem: Fix io memory dependencies Richard Weinberger
2016-03-30 8:50 ` Srinivas Kandagatla
2016-03-25 22:40 ` [PATCH 6/8] iio: adc: Fix at91-sama5d2_adc dependencies Richard Weinberger
2016-03-28 8:44 ` Jonathan Cameron
2016-03-25 22:40 ` [PATCH 7/8] fpga: Fix zynq-fpga dependencies Richard Weinberger
2016-03-25 22:40 ` [PATCH 8/8] iio: imu: Fix inv_mpu6050 dependencies Richard Weinberger
2016-03-28 9:03 ` Jonathan Cameron [this message]
2016-03-26 9:05 ` [PATCH 1/8] phy: Fix phy-hi6220-usb dependencies Geert Uytterhoeven
2016-03-26 9:27 ` Richard Weinberger
2016-03-30 4:15 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F8F354.3050207@kernel.org \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.