From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Emilio_L=c3=b3pez?= Subject: Re: [RFC PATCH v1 1/9] selftest: sync: basic tests for sw_sync framework Date: Mon, 28 Mar 2016 09:20:38 -0300 Message-ID: <56F92196.6040604@collabora.co.uk> References: <1457537342-678-1-git-send-email-emilio.lopez@collabora.co.uk> <1457537342-678-2-git-send-email-emilio.lopez@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Emil Velikov Cc: devel@driverdev.osuosl.org, Daniel Stone , Daniel Vetter , Shuah Khan , ML dri-devel , "Linux-Kernel@Vger. Kernel. Org" , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , linux-kselftest@vger.kernel.org, Riley Andrews , Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org SGksCgpFbCAyOC8wMy8xNiBhIGxhcyAwODo1NiwgRW1pbCBWZWxpa292IGVzY3JpYmnDszoKPiBI aSBFbWlsaW8sCj4KPiBPbiA5IE1hcmNoIDIwMTYgYXQgMTU6MjgsIEVtaWxpbyBMw7NwZXogPGVt aWxpby5sb3BlekBjb2xsYWJvcmEuY28udWs+IHdyb3RlOgo+PiBUaGVzZSB0ZXN0cyBhcmUgYmFz ZWQgb24gdGhlIGxpYnN5bmMgdGVzdCBzdWl0ZSBmcm9tIEFuZHJvaWQuCj4+IFRoaXMgY29tbWl0 IGxheXMgdGhlIGdyb3VuZCBmb3IgZnV0dXJlIHRlc3RzLCBhcyB3ZWxsIGFzIGluY2x1ZGVzCj4+ IHRlc3RzIGZvciBhIHZhcmlldHkgb2YgYmFzaWMgYWxsb2NhdGlvbiBjb21tYW5kcy4KPj4KPj4g U2lnbmVkLW9mZi1ieTogR3VzdGF2byBQYWRvdmFuIDxndXN0YXZvLnBhZG92YW5AY29sbGFib3Jh LmNvLnVrPgo+PiBTaWduZWQtb2ZmLWJ5OiBFbWlsaW8gTMOzcGV6IDxlbWlsaW8ubG9wZXpAY29s bGFib3JhLmNvLnVrPgo+PiAtLS0KPj4KPgo+PiAgIHRvb2xzL3Rlc3Rpbmcvc2VsZnRlc3RzL3N5 bmMvc3luYy5oICAgICAgIHwgMTE5ICsrKysrKysrKysrKysrKysrKwo+IEFkbWl0dGVkbHkgSSBr bm93IG5vdGhpbmcgYWJvdXQgdGhlIGtlcm5lbCBzZWxmdGVzdHMgYWx0aG91Z2ggY29weWluZwo+ IHRoZSBVQVBJIGhlYWRlciwgc2VlbXMgdG8gZGVmZWF0IHRoZSBwdXJwb3NlIG9mIHRoaXMgZXhl cmNpc2UuCj4gU2hvdWxkbid0IG9uZSByZXVzZSB0aGUgZXhpc3RpbmcgaGVhZGVyID8gSXQgd291 bGQgZXZlbiBjYXVzZSBpc3N1ZXMKPiBhcyB0aGUgaW50ZXJmYWNlIGdldHMgdXBkYXRlZCAoaWly YyBHdXN0YXZvIGNoYW5nZWQgdGhlIGlvY3RsIG51bWJlcnMKPiBhbmQvb3IgaGVhZGVyIG5hbWUg d2l0aCBsYXR0ZXIgc2VyaWVzKS4KClRoZSBwcm9ibGVtIGlzIHRoYXQgb25lIGNhbm5vdCB1c2Ug dGhlIHN5c3RlbSBoZWFkZXIgd2l0aG91dCBoYXZpbmcgCmJ1aWx0IGFuZCBpbnN0YWxsZWQgdGhl IGtlcm5lbCBmaXJzdCwgd2hpY2ggaXMgcmF0aGVyIHByb2JsZW1hdGljIGZvciAKZWcuIGNyb3Nz Y29tcGlsaW5nIG9yIHZpcnR1YWxpemF0aW9uLiBJIGRpc2N1c3NlZCB0aGlzIHdpdGggR3VzdGF2 byBhbmQgCndlIGFncmVlZCB0aGF0IHRoZSBiZXN0IHdheSBmb3J3YXJkIHdvdWxkIGJlIHRvIGNv cHkgdGhlIGludGVyZmFjZXMsIGFzIApzdWdnZXN0ZWQgYnkga2VybmVsbmV3Ymllcycgd2lraVsw XToKCiIiIgpUaGUgY29ycmVjdCB3YXkgdG8gYWRkcmVzcyB0aGlzIHByb2JsZW0gaXMgdG8gaXNv bGF0ZSB0aGUgc3BlY2lmaWMgCmludGVyZmFjZXMgdGhhdCB5b3UgbmVlZCwgZS5nLiBhIHNpbmds ZSBoZWFkZXIgZmlsZSB0aGF0IGlzIHBhdGNoZWQgaW4gYSAKbmV3IGtlcm5lbCBwcm92aWRpbmcg dGhlIGlvY3RsIG51bWJlcnMgZm9yIGEgY2hhcmFjdGVyIGRldmljZSB1c2VkIGJ5IAp5b3VyIHBy b2dyYW0uIEluIHlvdXIgb3duIHByb2dyYW0sIGFkZCBhIGNvcHkgb2YgdGhhdCBzb3VyY2UgZmls ZSwgd2l0aCAKYSBub3RpY2UgdGhhdCBpdCBzaG91bGQgYmUga2VwdCBpbiBzeW5jIHdpdGggbmV3 IGtlcm5lbCB2ZXJzaW9ucy4KIiIiCgpDaGVlcnMsCkVtaWxpbwoKWzBdIGh0dHA6Ly9rZXJuZWxu ZXdiaWVzLm9yZy9LZXJuZWxIZWFkZXJzCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRldmVsIG1haWxpbmcgbGlzdApkZXZlbEBsaW51eGRyaXZlcnByb2pl Y3Qub3JnCmh0dHA6Ly9kcml2ZXJkZXYubGludXhkcml2ZXJwcm9qZWN0Lm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaXZlcmRldi1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755071AbcC1Mvs (ORCPT ); Mon, 28 Mar 2016 08:51:48 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:42215 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754079AbcC1Mvq (ORCPT ); Mon, 28 Mar 2016 08:51:46 -0400 Subject: Re: [RFC PATCH v1 1/9] selftest: sync: basic tests for sw_sync framework To: Emil Velikov References: <1457537342-678-1-git-send-email-emilio.lopez@collabora.co.uk> <1457537342-678-2-git-send-email-emilio.lopez@collabora.co.uk> Cc: Shuah Khan , devel@driverdev.osuosl.org, Daniel Stone , Daniel Vetter , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel , Riley Andrews , linux-kselftest@vger.kernel.org, Gustavo Padovan , John Harrison From: =?UTF-8?Q?Emilio_L=c3=b3pez?= Message-ID: <56F92196.6040604@collabora.co.uk> Date: Mon, 28 Mar 2016 09:20:38 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, El 28/03/16 a las 08:56, Emil Velikov escribió: > Hi Emilio, > > On 9 March 2016 at 15:28, Emilio López wrote: >> These tests are based on the libsync test suite from Android. >> This commit lays the ground for future tests, as well as includes >> tests for a variety of basic allocation commands. >> >> Signed-off-by: Gustavo Padovan >> Signed-off-by: Emilio López >> --- >> > >> tools/testing/selftests/sync/sync.h | 119 ++++++++++++++++++ > Admittedly I know nothing about the kernel selftests although copying > the UAPI header, seems to defeat the purpose of this exercise. > Shouldn't one reuse the existing header ? It would even cause issues > as the interface gets updated (iirc Gustavo changed the ioctl numbers > and/or header name with latter series). The problem is that one cannot use the system header without having built and installed the kernel first, which is rather problematic for eg. crosscompiling or virtualization. I discussed this with Gustavo and we agreed that the best way forward would be to copy the interfaces, as suggested by kernelnewbies' wiki[0]: """ The correct way to address this problem is to isolate the specific interfaces that you need, e.g. a single header file that is patched in a new kernel providing the ioctl numbers for a character device used by your program. In your own program, add a copy of that source file, with a notice that it should be kept in sync with new kernel versions. """ Cheers, Emilio [0] http://kernelnewbies.org/KernelHeaders