All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 1/3] net: phy: Optionally force master mode for RTL PHY
Date: Mon, 28 Mar 2016 14:54:33 +0200	[thread overview]
Message-ID: <56F92989.9040602@redhat.com> (raw)
In-Reply-To: <CANr=Z=Zpdszi9TznEOc1JTi6Djv_4JTO0LbF43NAOnV6g2hQ_A@mail.gmail.com>

Hi,

On 25-03-16 22:11, Joe Hershberger wrote:
> On Fri, Mar 25, 2016 at 12:22 PM, Michael Haas
> <haas@computerlinguist.org> wrote:
>> This patch introduces CONFIG_RTL8211X_PHY_FORCE_MASTER. If this
>> define is set, RTL8211x PHYs (except for the RTL8211F) will have their
>> 1000BASE-T master/slave autonegotiation disabled and forced to master
>> mode.
>>
>> This is helpful for PHYs like the RTL8211C which produce unstable links
>> in slave mode. Such problems have been found on the A20-Olimex-SOM-EVB
>> and A20-OLinuXino-Lime2.
>>
>> There is no proper way to identify affected PHYs in software as the
>> RTL8211C shares its UID with the RTL8211B. Thus, this fix requires
>> the introduction of an #ifdef.
>>
>> CC: fradav at gmail.com
>> CC: merker at debian.org
>> CC: hdegoede at redhat.com
>> CC: ijc at hellion.org.uk
>> CC: joe.hershberger at ni.com
>>
>> Signed-off-by: Michael Haas <haas@computerlinguist.org>
>> Tested-by: Karsten Merker <merker@debian.org>
>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>

Series looks good to me:

Acked-by: Hans de Goede <hdegoede@redhat.com>

Joe, how do you want to proceed with upstreaming this, shall I take
all 3 patches upstream through u-boot-sunxi ?

Regards,

Hans

  reply	other threads:[~2016-03-28 12:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-25 17:22 [U-Boot] [PATCH v5 0/3] net: phy: Force master mode for RTL8211C on some boards Michael Haas
2016-03-25 17:22 ` [U-Boot] [PATCH v5 1/3] net: phy: Optionally force master mode for RTL PHY Michael Haas
2016-03-25 21:11   ` Joe Hershberger
2016-03-28 12:54     ` Hans de Goede [this message]
2016-03-28 16:12       ` Joe Hershberger
2016-03-25 17:22 ` [U-Boot] [PATCH v5 2/3] sunxi: A20-Olimex-SOM-EVB: Force 8211CL to master Michael Haas
2016-03-25 17:22 ` [U-Boot] [PATCH v5 3/3] sunxi: A20-OLinuXino-Lime2: " Michael Haas
2016-03-31 12:31 ` [U-Boot] [PATCH v5 0/3] net: phy: Force master mode for RTL8211C on some boards Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56F92989.9040602@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.