From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joseph Salisbury Subject: Re: [4.4-rc1][Regression] drm/i915: Check live status before reading edid Date: Mon, 28 Mar 2016 14:39:33 -0400 Message-ID: <56F97A65.3010608@canonical.com> References: <56CE22DB.6050108@canonical.com> <87lh63uago.fsf@intel.com> <56D76208.7020702@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <56D76208.7020702@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , sonika.jindal@intel.com Cc: David Airlie , Daniel Vetter , intel-gfx , LKML , dri-devel , rodrigo.vivi@intel.com List-Id: dri-devel@lists.freedesktop.org T24gMDMvMDIvMjAxNiAwNDo1OCBQTSwgSm9zZXBoIFNhbGlzYnVyeSB3cm90ZToKPiBPbiAwMi8y OS8yMDE2IDA0OjMzIEFNLCBKYW5pIE5pa3VsYSB3cm90ZToKPj4gT24gV2VkLCAyNCBGZWIgMjAx NiwgSm9zZXBoIFNhbGlzYnVyeSA8am9zZXBoLnNhbGlzYnVyeUBjYW5vbmljYWwuY29tPiB3cm90 ZToKPj4+IEhpIFNvbmlrYSwKPj4+Cj4+PiBBIGtlcm5lbCBidWcgcmVwb3J0IHdhcyBvcGVuZWQg YWdhaW5zdCBVYnVudHUgWzBdLiAgQWZ0ZXIgYSBrZXJuZWwKPj4+IGJpc2VjdCwgaXQgd2FzIGZv dW5kIHRoYXQgcmV2ZXJ0aW5nIHRoZSBmb2xsb3dpbmcgY29tbWl0IHJlc29sdmVkIHRoaXMgYnVn Ogo+Pj4KPj4+IGNvbW1pdCAyMzdlZDg2YzY5M2Q4YThlNGRiNDc2OTc2YWViMzBkZjRkZWFjNzRi Cj4+PiBBdXRob3I6IFNvbmlrYSBKaW5kYWwgPHNvbmlrYS5qaW5kYWxAaW50ZWwuY29tPgo+Pj4g RGF0ZTogICBUdWUgU2VwIDE1IDA5OjQ0OjIwIDIwMTUgKzA1MzAKPj4+Cj4+PiAgICAgZHJtL2k5 MTU6IENoZWNrIGxpdmUgc3RhdHVzIGJlZm9yZSByZWFkaW5nIGVkaWQKPj4+Cj4+Pgo+Pj4KPj4+ IFRoZSByZWdyZXNzaW9uIHdhcyBpbnRyb2R1Y2VkIGFzIG9mIHY0LjQtcmMxLgo+Pj4KPj4+IEkg d2FzIGhvcGluZyB0byBnZXQgeW91ciBmZWVkYmFjaywgc2luY2UgeW91IGFyZSB0aGUgcGF0Y2gg YXV0aG9yLiAgRG8KPj4+IHRoaW5rIGluY3JlYXNpbmcgdGhlIG51bWJlciBvZiB0cmllcyBpbiBp bnRlbF9oZG1pX2RldGVjdCgpIGlzIHdvcnRoCj4+PiB0cnlpbmc/ICBEbyB5b3UgdGhpbmsgZ2F0 aGVyaW5nIGFueSBhZGRpdGlvbmFsIGRhdGEgd2lsbCBoZWxwIGRpYWdub3NlCj4+PiB0aGlzIGlz c3VlLCBvciB3b3VsZCBpdCBiZSBiZXN0IHRvIHN1Ym1pdCBhIHJldmVydCByZXF1ZXN0Pwo+IFRo YW5rcyBmb3IgdGhlIGluZm8uICBJIHdpbGwgaGF2ZSBhbGwgb2YgdGhlc2UgY29tbWl0cyB0ZXN0 ZWQuCj4KPgo+PiBUaGVyZSBhcmUgYXQgbGVhc3QgdGhlIGZvbGxvd2luZyBjb21taXRzIGNsYWlt aW5nIHRvIGZpeCBpc3N1ZXMgaW4gdGhlCj4+IGFib3ZlIGNvbW1pdC4gUGxlYXNlIG1ha2Ugc3Vy ZSB5b3UgaGF2ZSB0aGVtLgo+Pgo+PiBCUiwKPj4gSmFuaS4KPj4KPj4KPj4gY29tbWl0IDhkNDA5 Y2IzZThhMjQxOTZiZTcyNzFkZWZhZmQ0NjM4ZjNlMGI1MTQKPj4gQXV0aG9yOiBWaWxsZSBTeXJq w6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+PiBEYXRlOiAgIFdlZCBGZWIg MTAgMTk6NTk6MDUgMjAxNiArMDIwMAo+Pgo+PiAgICAgZHJtL2k5MTU6IEZpeCBocGQgbGl2ZSBz dGF0dXMgYml0cyBmb3IgZzR4Cj4+Cj4+IGNvbW1pdCAzZDhhY2QxZjY2N2I0NWM1MzE0MDFjOGYw YzIwMzMwNzJlMzJhMDVkCj4+IEF1dGhvcjogR2FyeSBXYW5nIDxnYXJ5LmMud2FuZ0BpbnRlbC5j b20+Cj4+IERhdGU6ICAgV2VkIERlYyAyMyAxNjoxMTozNSAyMDE1ICswODAwCj4+Cj4+ICAgICBk cm0vaTkxNTogaW5jcmVhc2UgdGhlIHRyaWVzIGZvciBIRE1JIGhvdHBsdWcgbGl2ZSBzdGF0dXMg Y2hlY2tpbmcKPj4KPj4gY29tbWl0IDk3ZjkwMTBhZjA1YzE1ZTBiN2U2YjRlZjZmZjhjYjBlYmI3 ZTc3MTUKPj4gQXV0aG9yOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+ PiBEYXRlOiAgIEZyaSBEZWMgMTEgMTk6NDQ6MTUgMjAxNSArMDEwMAo+Pgo+PiAgICAgZHJtL2k5 MTU6IG1kZWxheSgxMCkgY29uc2lkZXJlZCBoYXJtZnVsCj4+Cj4+IGNvbW1pdCAwZjVhOWJlMTU3 OTdmNzhjOWEzNGU0MzJmMjZjNzk2MTY1YjZlNDlhCj4+IEF1dGhvcjogSW1yZSBEZWFrIDxpbXJl LmRlYWtAaW50ZWwuY29tPgo+PiBEYXRlOiAgIEZyaSBOb3YgMjcgMTg6NTU6MjkgMjAxNSArMDIw MAo+Pgo+PiAgICAgZHJtL2k5MTU6IHRha2UgYSBwb3dlciBkb21haW4gcmVmZXJlbmNlIHdoaWxl IGNoZWNraW5nIHRoZSBIRE1JIGxpdmUgc3RhdHVzCj4+Cj4+Cj4+Cj4+CkhpIEphbmksCgpBcHBs eWluZyB0aGUgZm9sbG93aW5nIGNvbW1pdCBkaWQgaW5kZWVkIGZpeCB0aGUgb3JpZ2luYWwgYnVn WzBdOgoKY29tbWl0IDhkNDA5Y2IzZThhMjQxOTZiZTcyNzFkZWZhZmQ0NjM4ZjNlMGI1MTQKQXV0 aG9yOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgpEYXRl OiAgIFdlZCBGZWIgMTAgMTk6NTk6MDUgMjAxNiArMDIwMAoKICAgIGRybS9pOTE1OiBGaXggaHBk IGxpdmUgc3RhdHVzIGJpdHMgZm9yIGc0eAoKCgpIb3dldmVyLCBpdCBhbHNvIGludHJvZHVjZWQg YSBuZXcgYnVnLCB3aGljaCBpcyBjb3ZlcmVkIGluIHRoYXQgYnVnCnJlcG9ydC4gIFRoZSBuZXcg YnVnIGlzIHRoYXQgYWZ0ZXIgbG9ja2luZy91bmxvY2tpbmcgdGhlIHNjcmVlbiwgYWxsIHRoZQp3 aW5kb3dzIGdldCBzaHVmZmxlZCBhcm91bmQgaW4gYSBtYW5uZXIgdGhhdCBpcyBjb25zaXN0ZW50 IHdpdGggWApkZWNpZGluZyB0aGF0IGl0J3Mgc2luZ2xlLWhlYWRlZCBhZ2FpbiwgYW5kIHRoZW4g YmFjayB0byBkb3VibGUgaGVhZGVkLiAKVGhpcyBvbmx5IGhhcHBlbnMgd2hlbiBJIGJ1aWxkIGEg a2VybmVsIHdpdGggYm90aCBjb21taXQgMjM3ZWQ4NmMgQU5ECmNvbW1pdCA4ZDQwOWNiM2UuICBJ ZiBJIHJldmVydCAyMzdlZDg2YyBhbmQga2VlcCBvbmx5IDhkNDA5Y2IzZSBib3RoIHRoZQpvcmln aW5hbCBidWcgYW5kIHRoZSBuZXcgYnVnIGdvIGF3YXkuICBEbyB5b3UgdGhpbmsgY29tbWl0IDIz N2VkODZjIGlzCnN0aWxsIGV2ZW4gbmVlZGVkIG5vdyB0aGF0IDhkNDA5Y2IzZSBoYXMgbGFuZGVk PyAgTWF5YmUgdGhlIG5ldyBidWcgaXMKZHVlIHRvIHRoZSBpbnRlcmFjdGlvbiBiZXR3ZWVuIDIz N2VkODZjIGFuZCA4ZDQwOWNiM2UuCgpUaGFua3MsCgpKb2UKClswXSBodHRwOi8vcGFkLmx2LzE1 NDM2ODMKCgoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753973AbcC1Sjl (ORCPT ); Mon, 28 Mar 2016 14:39:41 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:52172 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751005AbcC1Sjj convert rfc822-to-8bit (ORCPT ); Mon, 28 Mar 2016 14:39:39 -0400 Subject: Re: [4.4-rc1][Regression] drm/i915: Check live status before reading edid To: Jani Nikula , sonika.jindal@intel.com References: <56CE22DB.6050108@canonical.com> <87lh63uago.fsf@intel.com> <56D76208.7020702@canonical.com> Cc: shashank.sharma@intel.com, rodrigo.vivi@intel.com, Daniel Vetter , David Airlie , intel-gfx , dri-devel , LKML From: Joseph Salisbury Message-ID: <56F97A65.3010608@canonical.com> Date: Mon, 28 Mar 2016 14:39:33 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56D76208.7020702@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/02/2016 04:58 PM, Joseph Salisbury wrote: > On 02/29/2016 04:33 AM, Jani Nikula wrote: >> On Wed, 24 Feb 2016, Joseph Salisbury wrote: >>> Hi Sonika, >>> >>> A kernel bug report was opened against Ubuntu [0]. After a kernel >>> bisect, it was found that reverting the following commit resolved this bug: >>> >>> commit 237ed86c693d8a8e4db476976aeb30df4deac74b >>> Author: Sonika Jindal >>> Date: Tue Sep 15 09:44:20 2015 +0530 >>> >>> drm/i915: Check live status before reading edid >>> >>> >>> >>> The regression was introduced as of v4.4-rc1. >>> >>> I was hoping to get your feedback, since you are the patch author. Do >>> think increasing the number of tries in intel_hdmi_detect() is worth >>> trying? Do you think gathering any additional data will help diagnose >>> this issue, or would it be best to submit a revert request? > Thanks for the info. I will have all of these commits tested. > > >> There are at least the following commits claiming to fix issues in the >> above commit. Please make sure you have them. >> >> BR, >> Jani. >> >> >> commit 8d409cb3e8a24196be7271defafd4638f3e0b514 >> Author: Ville Syrjälä >> Date: Wed Feb 10 19:59:05 2016 +0200 >> >> drm/i915: Fix hpd live status bits for g4x >> >> commit 3d8acd1f667b45c531401c8f0c2033072e32a05d >> Author: Gary Wang >> Date: Wed Dec 23 16:11:35 2015 +0800 >> >> drm/i915: increase the tries for HDMI hotplug live status checking >> >> commit 97f9010af05c15e0b7e6b4ef6ff8cb0ebb7e7715 >> Author: Daniel Vetter >> Date: Fri Dec 11 19:44:15 2015 +0100 >> >> drm/i915: mdelay(10) considered harmful >> >> commit 0f5a9be15797f78c9a34e432f26c796165b6e49a >> Author: Imre Deak >> Date: Fri Nov 27 18:55:29 2015 +0200 >> >> drm/i915: take a power domain reference while checking the HDMI live status >> >> >> >> Hi Jani, Applying the following commit did indeed fix the original bug[0]: commit 8d409cb3e8a24196be7271defafd4638f3e0b514 Author: Ville Syrjälä Date: Wed Feb 10 19:59:05 2016 +0200 drm/i915: Fix hpd live status bits for g4x However, it also introduced a new bug, which is covered in that bug report. The new bug is that after locking/unlocking the screen, all the windows get shuffled around in a manner that is consistent with X deciding that it's single-headed again, and then back to double headed. This only happens when I build a kernel with both commit 237ed86c AND commit 8d409cb3e. If I revert 237ed86c and keep only 8d409cb3e both the original bug and the new bug go away. Do you think commit 237ed86c is still even needed now that 8d409cb3e has landed? Maybe the new bug is due to the interaction between 237ed86c and 8d409cb3e. Thanks, Joe [0] http://pad.lv/1543683