Re: [PATCH] scripts/gdb: Fix loading of modules information

[Daniel Wagner <wagi@monom.org>]

On 03/29/2016 08:59 AM, Jan Kiszka wrote:
> On 2016-03-29 08:41, Daniel Wagner wrote:
>>          for module in module_list():
>>              gdb.write("{address} {name:<19} {size:>8}  {ref}".format(
>> -                address=str(module['module_core']).split()[0],
>> +                module_layout=module['core_layout']
>> +                addressr=str(module_layout['base'])
> 
> This looks untested.

Yep, I send out the untested version. Need more coffee...

>>                  name=module['name'].string(),
>>                  size=str(module['core_size']),
>>                  ref=str(module['refcnt']['counter'])))
>> diff --git a/scripts/gdb/linux/symbols.py b/scripts/gdb/linux/symbols.py
>> index 627750c..8650ede 100644
>> --- a/scripts/gdb/linux/symbols.py
>> +++ b/scripts/gdb/linux/symbols.py
>> @@ -108,7 +108,8 @@ lx-symbols command."""
>>  
>>      def load_module_symbols(self, module):
>>          module_name = module['name'].string()
>> -        module_addr = str(module['module_core']).split()[0]
>> +        module_layout = module['core_layout']
>> +        module_addr = str(module_layout['base'])
>>  
>>          module_file = self._get_module_file(module_name)
>>          if not module_file and not self.module_files_updated:
>>
> 
> Thanks, but ad4db3b24a should already be on its way into stable.

Ah, I haven't got that fix yet because I am still on a older branch.
Also my google-foo didn't help.

Sorry about that noise.

cheers,
daniel