Re: [Qemu-devel] [PATCH v2] util: Improved qemu_hexmap() to include an ascii dump of the buffer

[Thomas Huth <thuth@redhat.com>]

There's a typo in the title: qemu_hexmap should be qemu_hexdump/ instead.

On 25.03.2016 11:42, Isaac Lozano wrote:
> qemu_hexdump() in util/hexdump.c has been changed to give also include a
> ascii dump of the buffer. Also, calls to hex_dump() in net/net.c have
> been replaced with calls to qemu_hexdump(). This takes care of two misc
> BiteSized Tasks.
> 
> Signed-off-by: Isaac Lozano <109lozanoi@gmail.com>
> ---
> 
> v2: Fixed code-style and made debug line smaller.
> 
>  net/net.c      | 30 +-----------------------------
>  util/hexdump.c | 33 ++++++++++++++++++++++-----------
>  2 files changed, 23 insertions(+), 40 deletions(-)
[...]

Code looks fine now, thanks for taking care of this!

Reviewed-by: Thomas Huth <thuth@redhat.com>

Jason, since there is no explicit maintainer for util/hexdump.c, could
you maybe take this through your net tree, since this patch touches
net/net.c as well?

 Thomas