From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Marc Kleine-Budde <mkl@pengutronix.de>, linux-can@vger.kernel.org
Cc: ramesh.shanmugasundaram@bp.renesas.com
Subject: Re: [PATCH v5] can: fix handling of unmodifiable configuration options
Date: Wed, 30 Mar 2016 14:24:27 +0200 [thread overview]
Message-ID: <56FBC57B.3060204@hartkopp.net> (raw)
In-Reply-To: <56F80231.1010005@pengutronix.de>
On 03/27/2016 05:54 PM, Marc Kleine-Budde wrote:
> On 03/21/2016 08:18 PM, Oliver Hartkopp wrote:
>> +static int can_validate(struct nlattr *tb[], struct nlattr *data[])
>> +{
>> + u32 is_can_fd = 0;
> ^^^
> I've made this bool.
ok
>> +/* helper to define static CAN controller features at device creation time */
>> +static inline void can_set_static_ctrlmode(struct net_device *dev,
>> + const u32 static_mode)
> ^^^^^
>
> I've removed the const here.
ok
But doesn't it make sense to indicate that we do not change the given
parameter in some way?
> Applied with these changes to can-next.
Thanks!
Oliver
prev parent reply other threads:[~2016-03-30 12:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 19:18 [PATCH v5] can: fix handling of unmodifiable configuration options Oliver Hartkopp
2016-03-22 7:52 ` Ramesh Shanmugasundaram
2016-03-22 15:07 ` Oliver Hartkopp
2016-03-27 15:54 ` Marc Kleine-Budde
2016-03-30 12:24 ` Oliver Hartkopp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FBC57B.3060204@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=ramesh.shanmugasundaram@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.