From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from li153-180.members.linode.com ([109.74.206.180]:54864 "EHLO mail.tekno-soft.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751458AbcC3MvC (ORCPT ); Wed, 30 Mar 2016 08:51:02 -0400 Subject: Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org References: <56FB87A1.4020505@tekno-soft.it> <5245625.0MITzPXo6V@wuerfel> Cc: Tim Harvey , "linux-pci@vger.kernel.org" , Richard Zhu , linux-kernel , =?UTF-8?Q?Krzysztof_Ha=c5=82asa?= , Bjorn Helgaas , =?UTF-8?Q?Petr_=c5=a0tetiar?= , Fabio Estevam , Lucas Stach From: Roberto Fichera Message-ID: <56FBCBA2.6050903@tekno-soft.it> Date: Wed, 30 Mar 2016 14:50:42 +0200 MIME-Version: 1.0 In-Reply-To: <5245625.0MITzPXo6V@wuerfel> Content-Type: text/plain; charset=windows-1252 Sender: linux-pci-owner@vger.kernel.org List-ID: On 03/30/2016 12:10 PM, Arnd Bergmann wrote: > On Wednesday 30 March 2016 10:00:33 Roberto Fichera wrote: >>> Check your XIO2001 routing and insure the following for proper IRQ mapping: >>> Slot12: IDSEL A28: socket INTA = XIO2001 INTA >>> Slot13: IDSEL A29: socket INTA = XIO2001 INTB >>> Slot14: IDSEL A30: socket INTA = XIO2001 INTC >>> Slot15: IDSEL A31: socket INTA = XIO2001 INTD >> After crosschecking with our hardware designer the PCB IRQ mapping is the following: >> >> J2 : IDSEL A16: => Device 0 : socket INTA = XIO2001 INTA >> J3 : IDSEL A18: => Device 2 : socket INTA = XIO2001 INTA* **(This should be INTC)* >> J11: IDSEL A20: => Device 4 : socket INTA = XIO2001 INTA >> >> The interrupt routing for J3 is wrong. The XIO2001 driver may expect Device 2 to interrupt on INTC - but it will >> interrupt on INTA. > What does your interrupt-map property look like then? Unfortunately it seems that J3 slot doesn't work anymore. Inserting a card there, PCIe link will not come up anymore. Likely I broke it. Looking at some spare logs I have, a card inserted in J3 will get another interrupt, was 291 however unfortunately I don't have an usefull lspci -vv output, sorry! Will check in it against another PCB when I can. > Note that you have to override both map and map-mask in this case. Can you please give more details where should I have a look? > > Arnd > From mboxrd@z Thu Jan 1 00:00:00 1970 From: kernel@tekno-soft.it (Roberto Fichera) Date: Wed, 30 Mar 2016 14:50:42 +0200 Subject: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity In-Reply-To: <5245625.0MITzPXo6V@wuerfel> References: <56FB87A1.4020505@tekno-soft.it> <5245625.0MITzPXo6V@wuerfel> Message-ID: <56FBCBA2.6050903@tekno-soft.it> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/30/2016 12:10 PM, Arnd Bergmann wrote: > On Wednesday 30 March 2016 10:00:33 Roberto Fichera wrote: >>> Check your XIO2001 routing and insure the following for proper IRQ mapping: >>> Slot12: IDSEL A28: socket INTA = XIO2001 INTA >>> Slot13: IDSEL A29: socket INTA = XIO2001 INTB >>> Slot14: IDSEL A30: socket INTA = XIO2001 INTC >>> Slot15: IDSEL A31: socket INTA = XIO2001 INTD >> After crosschecking with our hardware designer the PCB IRQ mapping is the following: >> >> J2 : IDSEL A16: => Device 0 : socket INTA = XIO2001 INTA >> J3 : IDSEL A18: => Device 2 : socket INTA = XIO2001 INTA* **(This should be INTC)* >> J11: IDSEL A20: => Device 4 : socket INTA = XIO2001 INTA >> >> The interrupt routing for J3 is wrong. The XIO2001 driver may expect Device 2 to interrupt on INTC - but it will >> interrupt on INTA. > What does your interrupt-map property look like then? Unfortunately it seems that J3 slot doesn't work anymore. Inserting a card there, PCIe link will not come up anymore. Likely I broke it. Looking at some spare logs I have, a card inserted in J3 will get another interrupt, was 291 however unfortunately I don't have an usefull lspci -vv output, sorry! Will check in it against another PCB when I can. > Note that you have to override both map and map-mask in this case. Can you please give more details where should I have a look? > > Arnd >