From mboxrd@z Thu Jan 1 00:00:00 1970 From: Georgi Djakov Subject: Re: [PATCH] regulator: qcom_spmi: Add slewing delays for all SMPS types Date: Wed, 30 Mar 2016 17:36:11 +0300 Message-ID: <56FBE45B.4030709@linaro.org> References: <1459292320-1996-1-git-send-email-stephen.boyd@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wm0-f51.google.com ([74.125.82.51]:38119 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752215AbcC3OgP (ORCPT ); Wed, 30 Mar 2016 10:36:15 -0400 Received: by mail-wm0-f51.google.com with SMTP id 20so74214127wmh.1 for ; Wed, 30 Mar 2016 07:36:14 -0700 (PDT) In-Reply-To: <1459292320-1996-1-git-send-email-stephen.boyd@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephen Boyd , Mark Brown Cc: linux-arm@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, David Collins On 03/30/2016 01:58 AM, Stephen Boyd wrote: > Only the FT SMPS type regulators have slewing supported in the > driver, but all types of SMPS regulators need the same support. > The only difference is that some SMPS regulators don't have a > step size and the step delay is typically 20, not 8. Luckily, the > step size reads as 0 for the non-FT types, so we can always read > that, but we need to detect which type of regulator we're using > to figure out what step delay to use. Make these minor > adjustments to the slew rate calculations and add support for the > delay function to the appropriate regulator ops. > > Reported-by: Georgi Djakov > Cc: David Collins > Signed-off-by: Stephen Boyd Thanks for the patch! I have verified it by applying this one on top: https://lkml.org/lkml/2016/3/30/381 Tested-by: Georgi Djakov BR, Georgi