Re: [Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6

[Thomas Huth <thuth@redhat.com>]

On 30.03.2016 17:04, Samuel Thibault wrote:
> Hello,
> 
> Thomas Huth, on Wed 30 Mar 2016 10:38:46 +0200, wrote:
>>> -    "-netdev user,id=str[,net=addr[/mask]][,host=addr][,ipv6-net=addr[/int]]\n"
>>> -    "         [,ipv6-host=addr][,restrict=on|off][,hostname=host][,dhcpstart=addr]\n"
>>> +    "-netdev user,id=str[,ipv4][,net=addr[/mask]][,host=addr]\n"
>>> +    "         [,ipv6][,ipv6-net=addr[/int]][,ipv6-host=addr]\n"
>>> +    "         [,restrict=on|off][,hostname=host][,dhcpstart=addr]\n"
>>>      "         [,dns=addr][,ipv6-dns=addr][,dnssearch=domain][,tftp=dir]\n"
>>>      "         [,bootfile=f][,hostfwd=rule][,guestfwd=rule]"
>>
>> Shouldn't that rather be "[,ipv4=on|off]" and "[,ipv6=on|off]" for a
>> boolean value?
> 
> Well, just like the rest of these ipv4/ipv6 options, they do accept
> =on|off, but it's not documented in the qemu-options.hx file.  Should we
> fix them all?

The "restrict" option is listed with "=on|off" here, that's why I
thought it should be there for "ipv4" and "ipv6", too. Which boolean
options are missing the "=on|off" ?

 Thomas