From: Thomas Huth <thuth@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
Cc: drjones@redhat.com, dgibson@redhat.com, pbonzini@redhat.com
Subject: Re: [kvm-unit-tests PATCH]] powerpc: display alignment exception in verbose mode only
Date: Wed, 30 Mar 2016 15:07:47 +0000 [thread overview]
Message-ID: <56FBEBC3.5060802@redhat.com> (raw)
In-Reply-To: <1459350381-23387-1-git-send-email-lvivier@redhat.com>
On 30.03.2016 17:06, Laurent Vivier wrote:
> In the emulator test, the illegal exception is displayed
> only in verbose mode, do the same thing for the alignment
> exception.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> powerpc/emulator.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/powerpc/emulator.c b/powerpc/emulator.c
> index ef27f15..3696d83 100644
> --- a/powerpc/emulator.c
> +++ b/powerpc/emulator.c
> @@ -35,8 +35,10 @@ static void alignment_handler(struct pt_regs *regs, void *opaque)
> {
> int *data = opaque;
>
> - printf("Detected alignment exception 0x%016lx: %08x\n",
> - regs->nip, *(uint32_t*)regs->nip);
> + if (verbose) {
> + printf("Detected alignment exception 0x%016lx: %08x\n",
> + regs->nip, *(uint32_t*)regs->nip);
> + }
>
> *data = 1;
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
Cc: drjones@redhat.com, dgibson@redhat.com, pbonzini@redhat.com
Subject: Re: [kvm-unit-tests PATCH]] powerpc: display alignment exception in verbose mode only
Date: Wed, 30 Mar 2016 17:07:47 +0200 [thread overview]
Message-ID: <56FBEBC3.5060802@redhat.com> (raw)
In-Reply-To: <1459350381-23387-1-git-send-email-lvivier@redhat.com>
On 30.03.2016 17:06, Laurent Vivier wrote:
> In the emulator test, the illegal exception is displayed
> only in verbose mode, do the same thing for the alignment
> exception.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> powerpc/emulator.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/powerpc/emulator.c b/powerpc/emulator.c
> index ef27f15..3696d83 100644
> --- a/powerpc/emulator.c
> +++ b/powerpc/emulator.c
> @@ -35,8 +35,10 @@ static void alignment_handler(struct pt_regs *regs, void *opaque)
> {
> int *data = opaque;
>
> - printf("Detected alignment exception 0x%016lx: %08x\n",
> - regs->nip, *(uint32_t*)regs->nip);
> + if (verbose) {
> + printf("Detected alignment exception 0x%016lx: %08x\n",
> + regs->nip, *(uint32_t*)regs->nip);
> + }
>
> *data = 1;
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2016-03-30 15:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 15:06 [kvm-unit-tests PATCH]] powerpc: display alignment exception in verbose mode only Laurent Vivier
2016-03-30 15:06 ` Laurent Vivier
2016-03-30 15:07 ` Thomas Huth [this message]
2016-03-30 15:07 ` Thomas Huth
2016-03-30 16:12 ` Paolo Bonzini
2016-03-30 16:12 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FBEBC3.5060802@redhat.com \
--to=thuth@redhat.com \
--cc=dgibson@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.