From: Troy Kisky <troy.kisky@boundarydevices.com>
To: Greg Ungerer <gerg@uclinux.org>, Zhi Li <lznuaa@gmail.com>,
Fugang Duan <fugang.duan@nxp.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: fec: stop the "rcv is not +last, " error messages
Date: Wed, 30 Mar 2016 10:04:20 -0700 [thread overview]
Message-ID: <56FC0714.6060607@boundarydevices.com> (raw)
In-Reply-To: <56FB46EA.7050401@uclinux.org>
On 3/29/2016 8:24 PM, Greg Ungerer wrote:
> Hi Troy,
>
> Commit 55cd48c8 ('net: fec: stop the "rcv is not +last, " error
> messages') adds a write to a register that is not present in all
> implementations of the FEC hardware module. None of the ColdFire
> SoC parts with the FEC module have the FTRL (0x1b0) register.
>
> Does this need a quirk flag to key access to this register of?
> Or can you piggyback on the FEC_QUIRK_HAS_RACC flag?
>
> Regards
> Greg
I'm no expert on what hardware has which registers, but piggybacking
works for all the processors that I use. Let's see what Freescale
says, but would you like to submit a patch to move it inside the quirk's
"if", or do you want me to do it?
next prev parent reply other threads:[~2016-03-30 17:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 3:24 [PATCH] net: fec: stop the "rcv is not +last, " error messages Greg Ungerer
2016-03-30 17:04 ` Troy Kisky [this message]
2016-03-30 18:37 ` Fabio Estevam
2016-03-31 1:17 ` Greg Ungerer
2016-03-31 10:58 ` Fabio Estevam
2016-03-31 1:41 ` Fugang Duan
2016-03-31 1:59 ` Greg Ungerer
2016-03-31 10:56 ` Fabio Estevam
2016-04-01 1:37 ` Fugang Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FC0714.6060607@boundarydevices.com \
--to=troy.kisky@boundarydevices.com \
--cc=fugang.duan@nxp.com \
--cc=gerg@uclinux.org \
--cc=lznuaa@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.