From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] Tegra-specific header file location
Date: Wed, 30 Mar 2016 16:48:10 -0600 [thread overview]
Message-ID: <56FC57AA.1090906@wwwdotorg.org> (raw)
Masahiro,
I'm about to work on some refactoring of the Tegra-specific header files
in U-Boot to enable support for another Tegra variant. I'd like to
confirm where you think header files should be located before doing that.
I believe you want Tegra-specific headers moved into
arch/arm/mach-tegra/include. That would probably be a good location for
headers currently in arch/arm/include/asm/arch-tegra/. Does that sound
correct to you?
What about SoC-specific headers currently in
arch/arm/include/asm/arch-tegraNNN/; should they move to
arch/arm/mach-tegra/tegraNNN/include?
A number of those header files primarily contain driver-internal
definitions such as HW register layouts. I'd like to propose moving this
private information into the relevant drivers/ directories where the
driver implementation already is. There is no need to place it in an
include directory where any C file could include it. For example, 99% of
arch/arm/include/asm/arch-tegra/tegra_mmc.h might move to
drivers/mmc/tegra_mmc_{priv,internal}.h or even into
drivers/mmc/tegra_mmc.c itself. The only thing that wouldn't move is the
public prototype for pad_init_mmc(); a function the MMC driver calls and
board code is expected to implement. I am considering making a single
header that defines all those Tegra-specific function prototypes so we
can reduce the number of header files too. What do you think about this.
next reply other threads:[~2016-03-30 22:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 22:48 Stephen Warren [this message]
2016-03-31 8:00 ` [U-Boot] Tegra-specific header file location Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FC57AA.1090906@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.