From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47947)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lizhijian@cn.fujitsu.com>) id 1alSBR-0003lU-PA
	for qemu-devel@nongnu.org; Wed, 30 Mar 2016 22:18:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lizhijian@cn.fujitsu.com>) id 1alSBO-0004qn-Iv
	for qemu-devel@nongnu.org; Wed, 30 Mar 2016 22:18:05 -0400
Received: from [59.151.112.132] (port=52545 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lizhijian@cn.fujitsu.com>) id 1alSBN-0004qY-CG
	for qemu-devel@nongnu.org; Wed, 30 Mar 2016 22:18:02 -0400
References: <1459326950-17708-1-git-send-email-zhangchen.fnst@cn.fujitsu.com>
	<1459326950-17708-4-git-send-email-zhangchen.fnst@cn.fujitsu.com>
	<20160330114143.GA7580@work-vm>
From: Li Zhijian <lizhijian@cn.fujitsu.com>
Message-ID: <56FC88D1.8080902@cn.fujitsu.com>
Date: Thu, 31 Mar 2016 10:17:53 +0800
MIME-Version: 1.0
In-Reply-To: <20160330114143.GA7580@work-vm>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V2 3/3] colo-compare: introduce packet
	comparison thread
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>, Gui jianfeng <guijianfeng@cn.fujitsu.com>, Jason Wang <jasowang@redhat.com>, "eddie.dong" <eddie.dong@intel.com>, qemu devel <qemu-devel@nongnu.org>, Yang Hongyang <hongyang.yang@easystack.cn>



On 03/30/2016 07:41 PM, Dr. David Alan Gilbert wrote:
[...]

>> >@@ -433,7 +532,9 @@ static void compare_pri_chr_in(void *opaque, const uint8_t *buf, int size)
>> >      if (ret == 1) {
>> >          if (packet_enqueue(s, PRIMARY_IN)) {
>> >              error_report("primary: unsupported packet in");
>> >-            compare_chr_send(s->chr_out, buf, size);
>> >+            compare_chr_send(s->chr_out, s->pri_rs.buf, s->pri_rs.packet_len);
> Doesn't that change belong in an earlier patch?
>
>> >+        } else {
>> >+            qemu_event_set(&s->event);
> Also these - why are these in this patch?
This event is to wakeup comparison thread to do compare.
Do you think we should put event related code to patch 2 ?

Thanks
Li
>
>> >          }