From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Quinn Tran <quinn.tran@qlogic.com>,
James Bottomley <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Himanshu Madhani <himanshu.madhani@qlogic.com>,
Christoph Hellwig <hch@lst.de>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 3/3] qla2xxx: Assign names to the flags in cmd_flags
Date: Thu, 31 Mar 2016 08:22:29 -0700 [thread overview]
Message-ID: <56FD40B5.4090707@sandisk.com> (raw)
In-Reply-To: <E8740ECF-B45F-4999-83AF-3EA27E4F55DF@qlogic.com>
On 03/31/16 08:16, Quinn Tran wrote:
> We use these flags for debugging purpose in crash cases.
Hello Quinn,
It must be inconvenient to have to look up the meaning of the individual
bits of the cmd_flags variable when analyzing a kernel crash. How about
preserving all these flags and to assign a meaningful name to each flag
instead of using bit numbers?
Thanks,
Bart.
next prev parent reply other threads:[~2016-03-31 15:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 23:24 [PATCH 0/3] qla2xxx: Patches for kernel v4.7 Bart Van Assche
2016-03-30 23:25 ` [PATCH 1/3] qla2xxx: Indicate out-of-memory with -ENOMEM Bart Van Assche
2016-03-31 7:30 ` Johannes Thumshirn
2016-03-31 15:21 ` Quinn Tran
2016-04-01 0:37 ` Martin K. Petersen
2016-03-30 23:25 ` [PATCH 2/3] qla2xxx: Remove set-but-not-used variables Bart Van Assche
2016-03-31 7:37 ` Johannes Thumshirn
2016-03-31 15:24 ` Quinn Tran
2016-03-31 15:57 ` Bart Van Assche
2016-03-30 23:26 ` [PATCH 3/3] qla2xxx: Assign names to the flags in cmd_flags Bart Van Assche
2016-03-31 7:56 ` Johannes Thumshirn
2016-03-31 15:16 ` Quinn Tran
2016-03-31 15:22 ` Bart Van Assche [this message]
2016-03-31 15:26 ` Quinn Tran
2016-03-31 15:52 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FD40B5.4090707@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=hch@lst.de \
--cc=himanshu.madhani@qlogic.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quinn.tran@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.