From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] test/py: Add support for loading image via tftp to specified location
Date: Thu, 31 Mar 2016 10:31:11 -0600 [thread overview]
Message-ID: <56FD50CF.2060100@wwwdotorg.org> (raw)
In-Reply-To: <ad3f296ba92c0721312cc59933c38eda795f33c5.1459413126.git.michal.simek@xilinx.com>
On 03/31/2016 02:32 AM, Michal Simek wrote:
> For example this setting:
>
> env__net_tftp_readable_file = {
> "fn": "ep108/image.ub",
> "addr": "0x10000000",
Why not remove the quotes, so the value is an integer already...
Could you please add the "addr" field into the example at the top of
test_net.py too?
> diff --git a/test/py/tests/test_net.py b/test/py/tests/test_net.py
> + addr = int(addr,16)
There should be a space after the comma.
... but removing the quotes as I mentioned above would allow removing
this int() call altogether.
next prev parent reply other threads:[~2016-03-31 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 8:32 [U-Boot] [PATCH] test/py: Add support for loading image via tftp to specified location Michal Simek
2016-03-31 16:31 ` Stephen Warren [this message]
2016-04-04 18:06 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FD50CF.2060100@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.