From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932111AbcCaSrG (ORCPT <rfc822;w@1wt.eu>);
	Thu, 31 Mar 2016 14:47:06 -0400
Received: from a.ns.miles-group.at ([95.130.255.143]:11949 "EHLO radon.swed.at"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1758216AbcCaSrD (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 31 Mar 2016 14:47:03 -0400
Subject: Re: [PATCH] Make CONFIG_FHANDLE default y
To: Andi Kleen <andi@firstfloor.org>
References: <1459437846-3690-1-git-send-email-andi@firstfloor.org>
 <CAFLxGvwRyKKSBxUGKHPD5y3h8DVrYxh40s+JgzJGsk3f4Me4zg@mail.gmail.com>
 <20160331184221.GK7982@two.firstfloor.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>, Andi Kleen <ak@linux.intel.com>
From: Richard Weinberger <richard@nod.at>
Message-ID: <56FD70A2.4060108@nod.at>
Date: Thu, 31 Mar 2016 20:46:58 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.1
MIME-Version: 1.0
In-Reply-To: <20160331184221.GK7982@two.firstfloor.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 31.03.2016 um 20:42 schrieb Andi Kleen:
> On Thu, Mar 31, 2016 at 05:52:52PM +0200, Richard Weinberger wrote:
>> On Thu, Mar 31, 2016 at 5:24 PM, Andi Kleen <andi@firstfloor.org> wrote:
>>> From: Andi Kleen <ak@linux.intel.com>
>>>
>>> Newer Fedora and OpenSUSE didn't boot with my standard configuration.
>>> It took me some time to figure out why, in fact I had to write a script
>>> to try different config options systematically.
>>>
>>> The problem is that something in dracut depends on CONFIG_FHANDLE,
>>> which adds open by file handle syscalls.
>>
>> s/something/systemd. :-)
> 
> Makes sense thanks. It should probably give a better error message
> like it gives for missing cgroups
> (right now just your root file system is missing)

That's an improvement, a few release ago it segfaulted in that case.

> But right now we should avoid others having the same pain
> and make the option default.

FHANDLE is part of x86's defconfig.

Please see https://github.com/systemd/systemd/blob/master/README#L37 for a list
of needed kernel options.

Thanks,
//richard