From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37064) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alhxk-0001dm-RY for qemu-devel@nongnu.org; Thu, 31 Mar 2016 15:09:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alhxh-0000K9-JL for qemu-devel@nongnu.org; Thu, 31 Mar 2016 15:09:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58743) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alhxh-0000K3-Bo for qemu-devel@nongnu.org; Thu, 31 Mar 2016 15:08:57 -0400 References: <1459448124-52318-1-git-send-email-alex@alex.org.uk> From: Eric Blake Message-ID: <56FD75C7.107@redhat.com> Date: Thu, 31 Mar 2016 13:08:55 -0600 MIME-Version: 1.0 In-Reply-To: <1459448124-52318-1-git-send-email-alex@alex.org.uk> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Sh7P8jR5kSEwT8d6xqcalrbFdpFiiue0V" Subject: Re: [Qemu-devel] [PATCH 1/2] proto.md: Clearly set out NBDMAGIC is the actual value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Bligh , Wouter Verhelst Cc: "nbd-general@lists.sourceforge.net" , "qemu-devel@nongnu.org" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Sh7P8jR5kSEwT8d6xqcalrbFdpFiiue0V Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/31/2016 12:15 PM, Alex Bligh wrote: > Clearly set out NBDMAGIC, not the name of a constant equal to > some value. Set out the value in hex as well. >=20 > Signed-off-by: Alex Bligh > --- > doc/proto.md | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/doc/proto.md b/doc/proto.md > index c1e05c5..7994076 100644 > --- a/doc/proto.md > +++ b/doc/proto.md > @@ -67,7 +67,7 @@ newstyle negotiation. > =20 > #### Oldstyle negotiation > =20 > -S: 64 bits, `NBDMAGIC` (also known as the `INIT_PASSWD`) =20 > +S: 64 bits, `0x4e42444d41474943` (ASCII '`NBDMAGIC`') (also known as t= he `INIT_PASSWD`) =20 > S: 64 bits, `0x00420281861253` (`cliserv_magic`, a magic number) =20 > S: 64 bits, size of the export in bytes (unsigned) =20 > S: 32 bits, flags =20 > @@ -96,7 +96,7 @@ production purposes. > =20 > The initial few exchanges in newstyle negotiation look as follows: > =20 > -S: 64 bits, `NBDMAGIC` (as in the old style handshake) =20 > +S: 64 bits, `0x4e42444d41474943` (ASCII '`NBDMAGIC`') (as in the old s= tyle handshake) =20 Markdown doesn't care, but the rest of this file is less than 80 columns, making this a long line. You can wrap it (see how I wrapped the line regarding 124 bytes of zeroes in response to NBD_OPT_EXPORT_NAME= ). > S: 64 bits, `0x49484156454F5054` (note different magic number) =20 As long as we are spelling out ASCII counterpart, is it worth mentioning that this is (ASCII `'IHAVEOPT'`)? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Sh7P8jR5kSEwT8d6xqcalrbFdpFiiue0V Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW/XXHAAoJEKeha0olJ0NqTegH/0c9sxLH4tpzBuXTsYGFuJHD Dru6xafLsYXd69+Ef/k2kqoIf26uzBfRi9BslaTcHnAS2Li0iEJk5VcMzAm34WX+ WqzEpQoZao2zyHyLxQKlxcvWxVUE4044jPTY6RkoBE6IYZy6IXe/oRT8TurLbLKp K85dcINtSQHO3Fq30fRrL/QJotC59G1ObMLKRedUPuGR9Lz2rkksB4HONBOs01xY T1BPrIi0AQs8X9VSNDNH8kUSPs+u0jzt9/VlLc2C8YjiZCia7570cPauDR3M+2hk mPSEaOVtMB3opFl2UB5JIyVBkrmREULlYrCqd9/Zb1xUh3Fu+EpEbxIAOrE1OW0= =1nH6 -----END PGP SIGNATURE----- --Sh7P8jR5kSEwT8d6xqcalrbFdpFiiue0V--