From: Eric Blake <eblake@redhat.com>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"nbd-general@lists.sourceforge.net"
<nbd-general@lists.sourceforge.net>
Subject: [Qemu-devel] Is NBD_CMD_FLAG_FUA valid during NBD_CMD_FLUSH?
Date: Thu, 31 Mar 2016 13:33:18 -0600 [thread overview]
Message-ID: <56FD7B7E.4060004@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 649 bytes --]
Qemu's nbd-client is setting NBD_CMD_FLAG_FUA during a flush command,
but the official NBD protocol documentation doesn't describe this as
valid (it merely states that flush must not have a reply until all
acknowledged writes have hit permanent storage). Does this flag make
sense (what semantics would the flag add, and we need to fix the NBD
docs as well as relax the reference implementation to allow the flag),
or is it a bug in qemu (and the recent tightening of NBD to throw EINVAL
on unsupported flags will trip up qemu)?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next reply other threads:[~2016-03-31 19:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 19:33 Eric Blake [this message]
2016-03-31 19:41 ` [Qemu-devel] [Nbd] Is NBD_CMD_FLAG_FUA valid during NBD_CMD_FLUSH? Alex Bligh
2016-03-31 19:54 ` Eric Blake
2016-03-31 20:17 ` Alex Bligh
2016-03-31 20:34 ` Eric Blake
2016-04-01 7:49 ` Paolo Bonzini
2016-04-01 9:25 ` Alex Bligh
2016-04-01 8:27 ` Wouter Verhelst
2016-04-01 9:40 ` Alex Bligh
2016-04-01 14:16 ` Eric Blake
2016-04-01 15:00 ` Alex Bligh
2016-04-01 15:08 ` Eric Blake
2016-04-01 15:12 ` Alex Bligh
2016-04-01 15:13 ` Alex Bligh
2016-04-01 15:31 ` Eric Blake
2016-04-01 15:46 ` Alex Bligh
2016-05-02 17:08 ` Eric Blake
2016-04-01 7:43 ` Paolo Bonzini
2016-04-01 9:19 ` Alex Bligh
2016-04-05 5:09 ` Kevin Wolf
2016-04-05 13:28 ` Paolo Bonzini
2016-04-06 13:14 ` Kevin Wolf
2016-04-06 13:28 ` Paolo Bonzini
2016-04-06 13:50 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FD7B7E.4060004@redhat.com \
--to=eblake@redhat.com \
--cc=nbd-general@lists.sourceforge.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.