From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: omap4: how to get the HDMI core IRQ? Date: Fri, 1 Apr 2016 10:03:21 +0300 Message-ID: <56FE1D39.1080303@ti.com> References: <56F45A30.4070701@xs4all.nl> <56FBAC79.6060405@ti.com> <56FDC4FA.2080001@xs4all.nl> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1378880418==" Return-path: Received: from bear.ext.ti.com (bear.ext.ti.com [192.94.94.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id E290F6EB9E for ; Fri, 1 Apr 2016 07:03:25 +0000 (UTC) In-Reply-To: <56FDC4FA.2080001@xs4all.nl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hans Verkuil Cc: Maling list - DRI developers List-Id: dri-devel@lists.freedesktop.org --===============1378880418== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4evPLiLiu0np6C7tnx1AvBRIKVciARXOu" --4evPLiLiu0np6C7tnx1AvBRIKVciARXOu Content-Type: multipart/mixed; boundary="ajLWFU2CQF9Hno66S6Amer3GIpOB2qCDn" From: Tomi Valkeinen To: Hans Verkuil Cc: Maling list - DRI developers Message-ID: <56FE1D39.1080303@ti.com> Subject: Re: omap4: how to get the HDMI core IRQ? References: <56F45A30.4070701@xs4all.nl> <56FBAC79.6060405@ti.com> <56FDC4FA.2080001@xs4all.nl> In-Reply-To: <56FDC4FA.2080001@xs4all.nl> --ajLWFU2CQF9Hno66S6Amer3GIpOB2qCDn Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/04/16 03:46, Hans Verkuil wrote: >> Apparently we set it always to 0 in >> hdmi4_core.c:hdmi_core_powerdown_disable(), but never enable it. I gue= ss >> it only affects core irqs, so there have been no side effects. >> >> But it would make sense to either have a matching call in the enable >> path, or then just set it to 0 when initializing the IP. >=20 > I think it should be set in hdmi_core_video_config(). It sets other > SYS_CTRL1 bits there as > well, and that is probably why I missed it. I just never realized that > the PD bit wasn't set > there. Hmm. Well, it's "power-down". It's quite unclear what it actually does, but from the name of it, I think it makes sense to set it only when HDMI core is enabled. In hdmi4.c, there are hdmi_power_on_core() and hdmi_power_off_core() functions, those might be good places to handle the bit. Ehh... Actually, looking at the code more carefully... hdmi_core_powerdown_disable() is called from hdmi4_configure() when setting everything up, and there's a comment "power down off". So apparently the intention of the code is to disable power-down mode, but it sets the bit to a wrong state. So probably we could just fix hdmi_core_powerdown_disable(), so that it sets PD to 1, which is what it was meant to do. This assumes that there are no bad side effects having PD 1 even if the HDMI is blanked, which is something we need to verify. I can do a few tests with that. Tomi --ajLWFU2CQF9Hno66S6Amer3GIpOB2qCDn-- --4evPLiLiu0np6C7tnx1AvBRIKVciARXOu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJW/h05AAoJEPo9qoy8lh71/cAP/RI6+BKmtdZiPjfHWo70UAi+ cyWhrW5b15UYHulYDRPUSvYk/zvuum/8aVxu8qVApWWpd24wD8XXZdAXJfV3ZjiN BWqWZYyzNx2A1kexnZjp7fL6mpeHExyXf+6YcrpBgSM8r5Wq3M328htr/TqyUeB6 vwYJsQosCmnbJLoAQNDC4AwmZkRBJXh7MwJb2+9fmwbnQnR0cDlxtfvEmefSkrBC CQakDh2vGkXuW5oZSOQld9V+qXk8wcf7sBHjDgWx8Pgn4eygjVRrYiDfpNhetQOO OKnTTsHwOy4TXDQpWLHgPaZtkGHxilocYuY/GwCinXPB1EEgJIsqR3rypOYpzZ+G i3nhJZ4/GinR4j1TrFEsS2VJQCs+WfNmaQIoniqZNsnTM1V4hhNqtLusXwPBL8Ku /A9loheQc1a7vM6EzCuMotzA/wNwZ2G+yMYmS9MGl21z4jkbPZHtrkL0xgB9MWq1 lu9ntNLR8F/s5eqjSThrqvZCnxIk2xDAi0Vva64UgPV7rYHhdzS70nboFf2XR4rk dReZaWkTBtmgE3U4ceNHramtjpJwVU8QSm+/iw97roPMbSmHbxGF/bKssEC0oDah 7iPmD1Z7j+iU1idCmDZGvlfY0nxY2gnyEGcDqPYeBJi93Ux1ooXYbpQz8ZqlhTci 9JbpK+GpwGhBgUvTFiAg =KqoG -----END PGP SIGNATURE----- --4evPLiLiu0np6C7tnx1AvBRIKVciARXOu-- --===============1378880418== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1378880418==--