From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: omap4: how to get the HDMI core IRQ? Date: Fri, 1 Apr 2016 10:35:07 +0300 Message-ID: <56FE24AB.1080204@ti.com> References: <56F45A30.4070701@xs4all.nl> <56FBAC79.6060405@ti.com> <56FDC4FA.2080001@xs4all.nl> <56FE1D39.1080303@ti.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2053278947==" Return-path: Received: from bear.ext.ti.com (bear.ext.ti.com [192.94.94.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1AD596EBF1 for ; Fri, 1 Apr 2016 07:35:11 +0000 (UTC) In-Reply-To: <56FE1D39.1080303@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hans Verkuil Cc: Maling list - DRI developers List-Id: dri-devel@lists.freedesktop.org --===============2053278947== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gbdDoCKuUi9MrTfoL7XJO0G9enQK4QEuW" --gbdDoCKuUi9MrTfoL7XJO0G9enQK4QEuW Content-Type: multipart/mixed; boundary="VMgA46AsSMdK10Lfu9arR7uDOpJ2EJsSf" From: Tomi Valkeinen To: Hans Verkuil Cc: Maling list - DRI developers Message-ID: <56FE24AB.1080204@ti.com> Subject: Re: omap4: how to get the HDMI core IRQ? References: <56F45A30.4070701@xs4all.nl> <56FBAC79.6060405@ti.com> <56FDC4FA.2080001@xs4all.nl> <56FE1D39.1080303@ti.com> In-Reply-To: <56FE1D39.1080303@ti.com> --VMgA46AsSMdK10Lfu9arR7uDOpJ2EJsSf Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/04/16 10:03, Tomi Valkeinen wrote: > So probably we could just fix hdmi_core_powerdown_disable(), so that it= > sets PD to 1, which is what it was meant to do. This assumes that there= > are no bad side effects having PD 1 even if the HDMI is blanked, which > is something we need to verify. I can do a few tests with that. I can't see any bad side effects with fixing the function. So here: =46rom 5cddaa31e28c059ea99a21ab03c4c1864bf5e610 Mon Sep 17 00:00:00 2001 From: Tomi Valkeinen Date: Fri, 1 Apr 2016 10:29:29 +0300 Subject: [PATCH] drm/omap: fix OMAP4 hdmi_core_powerdown_disable() hdmi_core_powerdown_disable() is supposed to disable HDMI core's power-down mode. Howver, the function sets the power-down bit to 0, which means "enable power-down". This hasn't caused any issues as the PD seems to affect only interrupts from HDMI core, and none of those interrupts are used at the moment. CEC functionality requires core interrupts, and the PD mode needs to be fixed. This patch fixes hdmi_core_powerdown_disable() to actually disable the PD mode. Signed-off-by: Tomi Valkeinen Reported-by: Hans Verkuil diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c b/drivers/gpu/drm/o= mapdrm/dss/hdmi4_core.c index fa72e735dad2..ef3afe99e487 100644 --- a/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c @@ -211,7 +211,7 @@ static void hdmi_core_init(struct hdmi_core_video_con= fig *video_cfg) static void hdmi_core_powerdown_disable(struct hdmi_core_data *core) { DSSDBG("Enter hdmi_core_powerdown_disable\n"); - REG_FLD_MOD(core->base, HDMI_CORE_SYS_SYS_CTRL1, 0x0, 0, 0); + REG_FLD_MOD(core->base, HDMI_CORE_SYS_SYS_CTRL1, 0x1, 0, 0); } =20 static void hdmi_core_swreset_release(struct hdmi_core_data *core) --VMgA46AsSMdK10Lfu9arR7uDOpJ2EJsSf-- --gbdDoCKuUi9MrTfoL7XJO0G9enQK4QEuW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJW/iSrAAoJEPo9qoy8lh71IQsQAITRT7Y39Wmb83TTZN8YRjW7 sU9McN1K+1rhHd03WIIocV7pMoG8F65/q6d33c3vTEznxRGpHyVRBnazYpKT+n2X R9L8ES/9Dmu4kk6c1Y+b1jT38uIi6GLmH1GH/OZfFlRG15A/GUZ168L8PGJHLEvo +09ZTCa0UlFDJN6PrnpD+Vkat5EBdQhgvUjCEvSHKde+w6Q5sD+XvO08qKpiE0zC io9giDQKADwxlv6oNIcaQVizfO6MDo5R8r5DkHoZxUOemmCd9yzU2FzGXLT6v1qV Ne6UukG9c9Wjh/Lz1YdFcfABX21gr/yOHYJ2aD0RxMCaRrVLkhRBm05uwnsjl5/4 oLx3xeEY3xmgCVRAKua0LZ4rYg7FjaaylvLxBjeGAfwb++8191h1pqVDXJ5wKULZ 0yLzjdKjJKpNo9BhRJAczGwsRXrgQK4h0Vrc7UgzcgffwAx4fxc3McAZuylDCrq+ owAVIOKw5mv2H6iH+co67D/TGGfMnzviOARrIjLTpBnzZfmrJCfdN3bL2Ueh6Nzi MNjnLdIabW48wYnaisq6twVO+E28ZQKhSFFi5P0UB6XPJbkzgEKl5rO782e6iKHQ BfzOsb44gzuY3GrW4GltkeOKaTNoaceBxUsxRrvBpr3YNF9q/p5rxqnP009JN0En wKB/Zx2L6tii3m25HNsm =1iKV -----END PGP SIGNATURE----- --gbdDoCKuUi9MrTfoL7XJO0G9enQK4QEuW-- --===============2053278947== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============2053278947==--