From: Cristina Ciocan <cristina.ciocan@intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: mathias.nyman@linux.intel.com, heikki.krogerus@linux.intel.com,
linus.walleij@linaro.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, irina.tirdea@intel.com,
octavian.purdila@intel.com
Subject: Re: [PATCH v3 1/6] pinctrl: baytrail: Add pin control data structures
Date: Fri, 1 Apr 2016 13:44:22 +0300 [thread overview]
Message-ID: <56FE5106.6010607@intel.com> (raw)
In-Reply-To: <20160331080434.GE2099@lahna.fi.intel.com>
On 31.03.2016 11:04, Mika Westerberg wrote:
> On Wed, Mar 30, 2016 at 06:05:30PM +0300, Cristina Ciocan wrote:
>> + PINCTRL_PIN(55, "GPIO_S0_SC[055]"),
>> + PINCTRL_PIN(56, "GPIO_S0_SC[056]"),
>> + PINCTRL_PIN(57, "GPIO_S0_SC[057]"),
>> + PINCTRL_PIN(58, "GPIO_S0_SC[058]"),
>> + PINCTRL_PIN(59, "GPIO_S0_SC[059]"),
>> + PINCTRL_PIN(60, "GPIO_S0_SC[060]"),
>> + PINCTRL_PIN(61, "GPIO_S0_SC[061]"),
>
> You still have these (and all similar [number]) things. IMO this looks
> better:
>
> PINCTRL_PIN(55, "GPIO_S0_SC55"),
> PINCTRL_PIN(56, "GPIO_S0_SC56"),
> PINCTRL_PIN(57, "GPIO_S0_SC57"),
> PINCTRL_PIN(58, "GPIO_S0_SC58"),
> PINCTRL_PIN(59, "GPIO_S0_SC59"),
> PINCTRL_PIN(60, "GPIO_S0_SC60"),
> PINCTRL_PIN(61, "GPIO_S0_SC61"),
Will fix in a new patch set, for consistency. Thank you.
>
> but I don't really care that much ;-)
>
> My ack still applies to the whole series.
>
next prev parent reply other threads:[~2016-04-01 10:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 15:05 [PATCH v3 0/6] Add pinctrl support for Baytrail Cristina Ciocan
2016-03-30 15:05 ` [PATCH v3 1/6] pinctrl: baytrail: Add pin control data structures Cristina Ciocan
2016-03-31 8:04 ` Mika Westerberg
2016-04-01 10:44 ` Cristina Ciocan [this message]
2016-04-01 13:25 ` Linus Walleij
2016-04-01 13:30 ` Mika Westerberg
2016-03-30 15:05 ` [PATCH v3 2/6] pinctrl: baytrail: Add pin control operations Cristina Ciocan
2016-03-30 15:05 ` [PATCH v3 3/6] pinctrl: baytrail: Update gpio chip operations Cristina Ciocan
2016-03-30 15:05 ` [PATCH v3 4/6] pinctrl: baytrail: Update irq " Cristina Ciocan
2016-03-30 15:05 ` [PATCH v3 5/6] pinctrl: baytrail: Register pin control handling Cristina Ciocan
2016-03-30 15:05 ` [PATCH v3 6/6] pinctrl: baytrail: Add debounce configuration Cristina Ciocan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FE5106.6010607@intel.com \
--to=cristina.ciocan@intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=irina.tirdea@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=octavian.purdila@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.