From: Eric Blake <eblake@redhat.com>
To: Alex Bligh <alex@alex.org.uk>, Wouter Verhelst <w@uter.be>
Cc: "nbd-general@lists.sourceforge.net"
<nbd-general@lists.sourceforge.net>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCHv2 2/2] Correct definition of NBD_CMD_FLAG_FUA
Date: Fri, 1 Apr 2016 07:29:45 -0600 [thread overview]
Message-ID: <56FE77C9.7060303@redhat.com> (raw)
In-Reply-To: <1459507590-1191-2-git-send-email-alex@alex.org.uk>
[-- Attachment #1: Type: text/plain, Size: 607 bytes --]
On 04/01/2016 04:46 AM, Alex Bligh wrote:
> NBD_CMD_FLAG_FUA is defined as 1<<0 in the documentation, but
> 1<<16 in nbd.h.
>
> The code currently treats the command as a 32 bit quantity
> and masks this off. This is confusing. Until such time as the
> code is fixed up, make it obvious this isn't really bit 16.
>
> Signed-off-by: Alex Bligh <alex@alex.org.uk>
> ---
> nbd.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-04-01 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 10:46 [Qemu-devel] [PATCHv2 1/2] proto.md: Clearly set out NBDMAGIC is the actual value Alex Bligh
2016-04-01 10:46 ` [Qemu-devel] [PATCHv2 2/2] Correct definition of NBD_CMD_FLAG_FUA Alex Bligh
2016-04-01 13:29 ` Eric Blake [this message]
2016-04-01 13:29 ` [Qemu-devel] [PATCHv2 1/2] proto.md: Clearly set out NBDMAGIC is the actual value Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FE77C9.7060303@redhat.com \
--to=eblake@redhat.com \
--cc=alex@alex.org.uk \
--cc=nbd-general@lists.sourceforge.net \
--cc=qemu-devel@nongnu.org \
--cc=w@uter.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.