From: Peter Hurley <peter@hurleysoftware.com>
To: Dominique van den Broeck <domdevlin@free.fr>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shraddha Barke <shraddha.6596@gmail.com>,
Radek Dostal <rd@radekdostal.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: fwserial: (coding style) Turning every "unsigned" into "unsigned int"
Date: Fri, 1 Apr 2016 09:22:17 -0700 [thread overview]
Message-ID: <56FEA039.5020802@hurleysoftware.com> (raw)
In-Reply-To: <1459271662-14990-1-git-send-email-domdevlin@free.fr>
On 03/29/2016 10:14 AM, Dominique van den Broeck wrote:
> Coding-style-only modifications to remove every warning saying:
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>
> Compiled against revision "next-20160327".
>
> (checkpatch.pl was updated to treat "UNSPECIFIED_INT" warnings
> as of commit a1ce18e4f941d20 )
Please change $subject to "staging: fwserial: Convert unsigned to unsigned int"
With that,
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
PS - For v2 of this patch, be sure to change the subject prefix to [PATCH v2 ...],
and note any changes in the diffstat area of the patch itself; eg.,
Signed-off-by: Dominique van den Broeck <domdevlin@free.fr>
---
v2: change subject per Peter Hurley's comments
drivers/staging/fwserial/dma_fifo.c | 8 +++----
drivers/staging/fwserial/dma_fifo.h | 16 +++++++-------
drivers/staging/fwserial/fwserial.c | 38 +++++++++++++++++----------------
drivers/staging/fwserial/fwserial.h | 42 ++++++++++++++++++-------------------
4 files changed, 53 insertions(+), 51 deletions(-)
prev parent reply other threads:[~2016-04-01 16:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 17:14 [PATCH 1/3] staging: fwserial: (coding style) Turning every "unsigned" into "unsigned int" Dominique van den Broeck
2016-03-29 17:14 ` [PATCH 2/3] staging: fwserial: (coding style) removing "!= NULL" to comply with checkpatch.pl Dominique van den Broeck
2016-04-01 16:25 ` Peter Hurley
2016-03-29 17:14 ` [PATCH 3/3] staging: fwserial: (coding style) Rewriting a call to a long function Dominique van den Broeck
2016-03-29 17:38 ` Joe Perches
2016-03-29 17:50 ` Dominique van den Broeck
2016-04-01 16:38 ` Peter Hurley
2016-04-01 23:20 ` Dominique van den Broeck
2016-04-01 23:29 ` Peter Hurley
2016-04-01 16:22 ` Peter Hurley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FEA039.5020802@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=domdevlin@free.fr \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rd@radekdostal.com \
--cc=shraddha.6596@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.