From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v3] xen/arm64: check XSM Magic and Signature from the second unknown module. Date: Fri, 1 Apr 2016 19:10:26 +0100 Message-ID: <56FEB992.3050304@arm.com> References: <1459222015-12036-1-git-send-email-fu.wei@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1459222015-12036-1-git-send-email-fu.wei@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: fu.wei@linaro.org, xen-devel@lists.xensource.com, sstabellini@kernel.org, dgdegra@tycho.nsa.gov, konrad.wilk@oracle.com Cc: jcm@redhat.com, leif.lindholm@linaro.org, linaro-uefi@lists.linaro.org List-Id: xen-devel@lists.xenproject.org KFVzZSBTdGVmYW5vJ3MgbmV3IGUtbWFpbCBhZGRyZXNzKQpIaSBGdSBXZWksCgpPbiAyOS8wMy8x NiAwNDoyNiwgZnUud2VpQGxpbmFyby5vcmcgd3JvdGU6Cj4gRnJvbTogRnUgV2VpIDxmdS53ZWlA bGluYXJvLm9yZz4KPgo+IFRoaXMgcGF0Y2ggYWRkIGEgY2hlY2tfeHNtX3NpZ25hdHVyZSBzdGF0 aWMgZnVuY3Rpb24gZm9yIGRldGVjdGluZyBYU00KCnMvYWRkL2FkZHMvCgo+IGZyb20gdGhlIHNl Y29uZCB1bmtub3duIG1vZHVsZS4KPgo+IElmIFhlbiBjYW4ndCBnZXQgdGhlIGtpbmQgb2YgbW9k dWxlIGZyb20gY29tcGF0aWJsZSwgd2UgZ3Vlc3MgdGhlIGtpbmQgb2YKPiB0aGVzZSBmaXJzdCB0 d28gdW5rbm93biByZXNwZWN0aXZlbHk6CgpUaGUgc3RlcHMgYmVsb3cgYXJlIG5vdCBvbmx5IGZv ciB0aGUgZmlyc3QgdHdvIG1vZHVsZXMuCgo+ICAgICAgKDEpIFRoZSBmaXJzdCB1bmtub3duIG11 c3QgYmUga2VybmVsOwo+ICAgICAgKDIpIFRoZSBzZWNvbmQgdW5rbm93biBpcyByYW1kaXNrLCBv bmx5IGlmIHdlIGhhdmUgcmFtZGlzazsKClRoaXMgaXMgdW5jbGVhci4KCj4gICAgICAoMykgU3Rh cnQgZnJvbSB0aGUgMm5kIHVua25vd24sIGRldGVjdCB0aGUgWFNNIGJpbmFyeSBzaWduYXR1cmU7 Cj4gICAgICAoNCkgSWYgd2UgZ290IFhTTSBpbiB0aGUgMm5kIHVua25vd24sIHRoYXQgbWVhbnMg d2UgZG9uJ3QgbG9hZCBpbml0cmQuCgpzL2luaXRyZC9yYW1kaXNrLwoKQWxzbywgdGhlIGRvY3Vt ZW50YXRpb24gaW4gbWlzYy9hcm0vZGV2aWNlLXRyZWUvYm9vdGluZy50eHQgbmVlZHMgdG8gYmUg CnVwZGF0ZWQuCgpBUk0gYmVoYXZpb3Igd2lsbCBiZSBjb21wYXRpYmxlIHRvIHg4NiBhbmQgd2ls bCBzaW1wbGlmeSBtdWx0aS1hcmNoIApib290bG9hZGVyIHN1Y2ggYXMgR1JVQiwgc28gSSdtIGZp bmUgdG8gaW50cm9kdWNlIHRoaXMgYm9vdCBwcm90b2NvbCAKY2hhbmdlLiBIb3dldmVyLCBJJ2Qg bGlrZSB0byBzZWUgdGhlIHJlYXNvbiBvZiB0aGlzIGNoYW5nZSBzcGVsbHMgb3V0IGluIAp0aGUg Y29tbWl0IG1lc3NhZ2UuCgo+Cj4gU2lnbmVkLW9mZi1ieTogRnUgV2VpIDxmdS53ZWlAbGluYXJv Lm9yZz4KPiAtLS0KPiBDaGFuZ2Vsb2c6Cj4gdjM6IFVzaW5nIG1lbWNtcCBpbnN0ZWFkIG9mIHN0 cm5jbXAuCj4gICAgICBVc2luZyAicmV0dXJuIDA7IiBpbnN0ZWFkIG9mIHBhbmljKCk7Cj4gICAg ICBJbXByb3ZlIHNvbWUgY29tbWVudHMuCj4KPiB2MjogaHR0cDovL2xpc3RzLnhlbi5vcmcvYXJj aGl2ZXMvaHRtbC94ZW4tZGV2ZWwvMjAxNi0wMy9tc2cwMzU0My5odG1sCj4gICAgICBVc2luZyBY RU5fTUFHSUMgbWFjcm8gaW5zdGVhZCBvZiAweGY5N2NmZjhjIDoKPiAgICAgIHVpbnQzMl90IHNl bGludXhfbWFnaWMgPSAweGY5N2NmZjhjOyAtLT4gdWludDMyX3QgeGVuX21hZ2ljID0gWEVOX01B R0lDOwo+ICAgICAgQ29tbWVudCBvdXQgdGhlIGNvZGUocmV0dXJuIDAgZGlyZWN0bHkpLCBpZiBD T05GSUdfRkxBU0sgaXMgbm90IHNldC4KPgo+IHYxOiBodHRwOi8vbGlzdHMueGVuLm9yZy9hcmNo aXZlcy9odG1sL3hlbi1kZXZlbC8yMDE2LTAzL21zZzAyNDMwLmh0bWwKPiAgICAgIFRoZSBmaXJz dCB1cHN0cmVhbSBwYXRjaCB0byB4ZW4tZGV2ZWwgbWFpbGluZyBsaXN0cy4KPgo+ICAgeGVuL2Fy Y2gvYXJtL2Jvb3RmZHQuYyB8IDU0ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKystCj4gICAxIGZpbGUgY2hhbmdlZCwgNTMgaW5zZXJ0aW9ucygrKSwgMSBk ZWxldGlvbigtKQo+Cj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9ib290ZmR0LmMgYi94ZW4v YXJjaC9hcm0vYm9vdGZkdC5jCj4gaW5kZXggOGExNDAxNS4uMTBkMzM4MiAxMDA2NDQKPiAtLS0g YS94ZW4vYXJjaC9hcm0vYm9vdGZkdC5jCj4gKysrIGIveGVuL2FyY2gvYXJtL2Jvb3RmZHQuYwo+ IEBAIC0xNjMsNiArMTYzLDQ5IEBAIHN0YXRpYyB2b2lkIF9faW5pdCBwcm9jZXNzX21lbW9yeV9u b2RlKGNvbnN0IHZvaWQgKmZkdCwgaW50IG5vZGUsCj4gICAgICAgfQo+ICAgfQo+Cj4gKy8qKgo+ ICsgKiBjaGVja194c21fc2lnbmF0dXJlIC0gQ2hlY2sgWFNNIE1hZ2ljIGFuZCBTaWduYXR1cmUg b2YgdGhlIG1vZHVsZSBoZWFkZXIKPiArICogQSBYU00gbW9kdWxlIGhhcyBhIHNwZWNpYWwgaGVh ZGVyCj4gKyAqIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LQo+ICsgKiB1aW50IG1hZ2ljIHwgdWludCB0YXJnZXRfbGVuIHwgdWNoYXIgdGFyZ2V0WzhdIHwK PiArICogMHhmOTdjZmY4YyB8ICAgICAgICA4ICAgICAgICB8ICAgICJYZW5GbGFzayIgICB8Cj4g KyAqIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICsg KiAweGY5N2NmZjhjIGlzIHBvbGljeSBtYWdpYyBudW1iZXIgKFhTTV9NQUdJQykuCj4gKyAqIFNv IHdlIG9ubHkgcmVhZCB0aGUgZmlyc3QgMTYgYnl0ZXMgb2YgdGhlIG1vZHVsZSwgdGhlbiBjaGVj ayB0aGVzZSB0aHJlZQo+ICsgKiBwYXJ0cy4gVGhpcyBjaGVja2luZyAobWVtY21wKSBhc3N1bWVz IGxpdHRsZS1lbmRpYW4gYnl0ZSBvcmRlci4KPiArICovCj4gK3N0YXRpYyBib29sIF9faW5pdCBj aGVja194c21fc2lnbmF0dXJlKGNvbnN0IHZvaWQgKmZkdCwgaW50IG5vZGUsCj4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IGNoYXIgKm5hbWUsCj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHUzMiBhZGRyZXNzX2NlbGxzLCB1MzIg c2l6ZV9jZWxscykKPiArewo+ICsjaWZkZWYgQ09ORklHX0ZMQVNLCj4gKyAgICB1MzIgeGVuX21h Z2ljID0gWFNNX01BR0lDLCB0YXJnZXRfbGVuID0gODsKPiArICAgIGNvbnN0IHN0cnVjdCBmZHRf cHJvcGVydHkgKnByb3A7Cj4gKyAgICB1bnNpZ25lZCBjaGFyIGJ1ZmZbMTZdOwo+ICsgICAgcGFk ZHJfdCBzdGFydCwgc2l6ZTsKPiArICAgIGNvbnN0IF9fYmUzMiAqY2VsbDsKPiArICAgIGludCBs ZW47Cj4gKwo+ICsgICAgcHJvcCA9IGZkdF9nZXRfcHJvcGVydHkoZmR0LCBub2RlLCAicmVnIiwg Jmxlbik7Cj4gKyAgICBpZiAoICFwcm9wIHx8IGxlbiA8IGR0X2NlbGxzX3RvX3NpemUoYWRkcmVz c19jZWxscyArIHNpemVfY2VsbHMpKQo+ICsgICAgICAgIHJldHVybiAwOwo+ICsKPiArICAgIGNl bGwgPSAoY29uc3QgX19iZTMyICopcHJvcC0+ZGF0YTsKPiArICAgIGRldmljZV90cmVlX2dldF9y ZWcoJmNlbGwsIGFkZHJlc3NfY2VsbHMsIHNpemVfY2VsbHMsICZzdGFydCwgJnNpemUpOwoKSSB3 b3VsZCBwcmVmZXIgaWYgeW91IHJlLW9yZGVyIHRoZSBjb2RlIGluIHByb2Nlc3NfbXVsdGlib290 X25vZGUgdG8gZ2V0IAp0aGUgYmFzZSBhZGRyZXNzIGFuZCBzaXplIGZpcnN0LiBUaGlzIGZ1bmN0 aW9uIHdpbGwgdGhlbiBvbmx5IGNoZWNrIGlmIAp0aGUgc2lnbmF0dXJlIGlzIHZhbGlkLgoKPiAr Cj4gKyAgICBjb3B5X2Zyb21fcGFkZHIoYnVmZiwgc3RhcnQsIHNpemVvZihidWZmKSk7Cj4gKwo+ ICsgICAgaWYgKG1lbWNtcChidWZmLCAodm9pZCAqKSAmeGVuX21hZ2ljLCBzaXplb2YodTMyKSkg fHwKPiArICAgICAgICBtZW1jbXAoYnVmZiArIHNpemVvZih1MzIpLCAodm9pZCAqKSAmdGFyZ2V0 X2xlbiwgc2l6ZW9mKHUzMikpIHx8Cj4gKyAgICAgICAgbWVtY21wKGJ1ZmYgKyBzaXplb2YodTMy KSAqIDIsICJYZW5GbGFzayIsIHRhcmdldF9sZW4pKQoKRG8gd2UgcmVhbGx5IG5lZWQgdG8gdGVz dCBhbGwgdGhvc2UgZmllbGRzPyBUaGUgY3VycmVudCBjaGVjayBpbiAKeHNtX3BvbGljeS5jIG9u bHkgY2hlY2sgdGhlIG1hZ2ljIG51bWJlci4KCkFsc28gSSB3b3VsZCBwcmVmZXIgaWYgeW91IGZh Y3RvciB0aGUgY29kZSB0byBjb3B5L2NoZWNrIGluIGFuIGhlbHBlciAKYW5kIHJlLXVzZSBpdCBp biB4c21fZHRfcG9saWN5X2luaXQuCgo+ICsgICAgICAgIHJldHVybiAwOwo+ICsKPiArICAgIHJl dHVybiAxOwo+ICsjZWxzZQo+ICsgICAgcmV0dXJuIDA7Cj4gKyNlbmRpZgo+ICt9Cj4gKwo+ICAg c3RhdGljIHZvaWQgX19pbml0IHByb2Nlc3NfbXVsdGlib290X25vZGUoY29uc3Qgdm9pZCAqZmR0 LCBpbnQgbm9kZSwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGNvbnN0IGNoYXIgKm5hbWUsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB1MzIgYWRkcmVzc19jZWxscywgdTMyIHNpemVfY2VsbHMpCj4gQEAgLTE4Niw3ICsy MjksMTMgQEAgc3RhdGljIHZvaWQgX19pbml0IHByb2Nlc3NfbXVsdGlib290X25vZGUoY29uc3Qg dm9pZCAqZmR0LCBpbnQgbm9kZSwKPiAgICAgICBlbHNlCj4gICAgICAgICAgIGtpbmQgPSBCT09U TU9EX1VOS05PV047Cj4KPiAtICAgIC8qIEd1ZXNzIHRoYXQgZmlyc3QgdHdvIHVua25vd24gYXJl IGtlcm5lbCBhbmQgcmFtZGlzayByZXNwZWN0aXZlbHkuICovCj4gKyAgICAvKioKPiArICAgICAq IEd1ZXNzIHRoZSBraW5kIG9mIHRoZXNlIGZpcnN0IHR3byB1bmtub3duIHJlc3BlY3RpdmVseToK PiArICAgICAqICgxKSBUaGUgZmlyc3QgdW5rbm93biBtdXN0IGJlIGtlcm5lbDsKPiArICAgICAq ICgyKSBUaGUgc2Vjb25kIHVua25vd24gaXMgcmFtZGlzaywgb25seSBpZiB3ZSBoYXZlIHJhbWRp c2s7Cj4gKyAgICAgKiAoMykgU3RhcnQgZnJvbSB0aGUgMm5kIHVua25vd24sIGRldGVjdCB0aGUg WFNNIGJpbmFyeSBzaWduYXR1cmU7Cj4gKyAgICAgKiAoNCkgSWYgd2UgZ290IFhTTSBpbiB0aGUg Mm5kIHVua25vd24sIHRoYXQgbWVhbnMgd2UgaGF2ZSBub3QgaW5pdHJkLgoKcy9ub3Qvbm8vCgo+ ICsgICAgICovCj4gICAgICAgaWYgKCBraW5kID09IEJPT1RNT0RfVU5LTk9XTiApCj4gICAgICAg ewo+ICAgICAgICAgICBzd2l0Y2ggKCBraW5kX2d1ZXNzKysgKQo+IEBAIC0xOTUsNiArMjQ0LDkg QEAgc3RhdGljIHZvaWQgX19pbml0IHByb2Nlc3NfbXVsdGlib290X25vZGUoY29uc3Qgdm9pZCAq ZmR0LCBpbnQgbm9kZSwKPiAgICAgICAgICAgY2FzZSAxOiBraW5kID0gQk9PVE1PRF9SQU1ESVNL OyBicmVhazsKPiAgICAgICAgICAgZGVmYXVsdDogYnJlYWs7Cj4gICAgICAgICAgIH0KPiArICAg ICAgICBpZiAoa2luZF9ndWVzcyA+IDEgJiYgY2hlY2tfeHNtX3NpZ25hdHVyZShmZHQsIG5vZGUs IG5hbWUsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgYWRkcmVzc19jZWxscywgc2l6ZV9jZWxscykpCj4gKyAgICAgICAgICAgIGtpbmQgPSBCT09U TU9EX1hTTTsKPiAgICAgICB9Cj4KPiAgICAgICBwcm9wID0gZmR0X2dldF9wcm9wZXJ0eShmZHQs IG5vZGUsICJyZWciLCAmbGVuKTsKPgoKUmVnYXJkcywKCi0tIApKdWxpZW4gR3JhbGwKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWls aW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cDovL2xpc3RzLnhlbi5vcmcveGVu LWRldmVsCg==