From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Alex Braunegg" Subject: Re: [BUG} libxl.c:5947:libxl_send_trigger: Send trigger 'reset' failed: Function not implemented Date: Thu, 11 Feb 2016 09:30:26 +1100 Message-ID: <56bbba08.ee35420a.d8138.fffff636@mx.google.com> References: <56b2762f.0e57620a.f6044.ffff976e@mx.google.com> <1454583460.25207.165.camel@citrix.com> <56b3d9fa.4902620a.e0e8f.ffffab27@mx.google.com> <1455013705.19857.30.camel@citrix.com> <56ba897e.010f620a.d7d7b.1cbc@mx.google.com> <1455096752.19857.114.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1455096752.19857.114.camel@citrix.com> Content-Language: en-au List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: 'Ian Campbell' , xen-devel@lists.xen.org Cc: 'Ian Jackson' , 'Wei Liu' , 'Jan Beulich' , 'Andrew Cooper' List-Id: xen-devel@lists.xenproject.org Hi Ian, > There is a function internal to libxl (libxl__domain_pvcontrol) which > answers this question (by looking at the callback IRQ). I looked at this function yesterday and it appears that it calls: ret = libxl__domain_pvcontrol_available(gc, domid); which in turn calls: ret = xc_hvm_param_get(ctx->xch, domid, HVM_PARAM_CALLBACK_IRQ, &pvdriver); which is defined in xenctrl.h, this is why I thought it may have been easier to call "xc_hvm_param_get" directly inside the 'xl vm-list' function with the applicable header applied. > I suppose it would be reasonable to expose that formally in the libxl > public API in some form, although it is also the case that any function > which uses PV control mechanisms performs (or at least should perform) this > check and return ERROR_NOPARAVIRT if pv control is not avaiable, so > application code can try PV and fallback to other methods (as xl does). > libxc (xenctrl.h) is not a stable interface and it is a design goal of > libxl that toolstacks should only need to use libxl interfaces for their > toolstack oriented operations. So this functionality would need to be > reflected in the stable libxl API for use by xl (and libvirt, and other > toolstacks people might write) So potentially before trying to make use of libxl__domain_pvcontrol for the 'xl vm-list' command to provide feedback if PV control is available, I will need to wait for the functionality to be exposed via an applicable libxl header. Best regards, Alex