From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FF68C5DF86 for ; Wed, 19 Aug 2026 10:19:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5C15B10EDA1; Wed, 19 Aug 2026 10:18:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="ek55XU+b"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id D77A110E10B for ; Wed, 19 Aug 2026 10:18:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1787134738; x=1818670738; h=message-id:date:subject:to:cc:references:from: in-reply-to:mime-version; bh=iKJx34fGb+0rTEzMkZPJZV75ev8DFyyJoK3wTI4YrZo=; b=ek55XU+biZkUhj6JanJn9zkhBRQmNRy2g1V0qlxspmRLs66VrjLGhmel xuX8oirDgWdHRZRd85M0OfNs5i5V2QEnZtAuAE2cHb6k7LqAbO68rq0fb pl2Z13CPVHJ5GqdnQtQkPlWyBmMhegJwj7hVm7US6S2qm5iL0uVO8THCp sGWLYgPUN3+aji1icsA6nbjVEIeqSLKckSI3VM5mnEjoYUI6R5XMH/dhm 01GcxD8u4ApyS3akgLUULqin3hIZcbnLPhXsJNIEd9ugWECy9+RPGh5Kh mFnsNp8m1Gkg50F5vxfHWbxGLp2ScP2qbC6xWHUho3UUiZcMbf/Jh02+3 Q==; X-CSE-ConnectionGUID: SKQKojYGRBW8A9FNGsTGXw== X-CSE-MsgGUID: t1zp9sAOTxK8N/iBu0efDA== X-IronPort-AV: E=McAfee;i="6800,10657,11879"; a="86760648" X-IronPort-AV: E=Sophos;i="6.25,231,1779174000"; d="scan'208,217";a="86760648" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2026 03:18:44 -0700 X-CSE-ConnectionGUID: ho6seNRVTgSHM1f0As0AtA== X-CSE-MsgGUID: lOV3FtcpQuyjgDkBUs3Yog== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,231,1779174000"; d="scan'208,217";a="262878051" Received: from fmsmsx902.amr.corp.intel.com ([10.18.126.91]) by fmviesa008.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2026 03:18:44 -0700 Received: from FMSMSX902.amr.corp.intel.com (10.18.126.91) by fmsmsx902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Wed, 19 Aug 2026 03:18:43 -0700 Received: from fmsedg901.ED.cps.intel.com (10.1.192.143) by FMSMSX902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Wed, 19 Aug 2026 03:18:43 -0700 Received: from SJ2PR03CU001.outbound.protection.outlook.com (52.101.43.38) by edgegateway.intel.com (192.55.55.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Wed, 19 Aug 2026 03:18:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nVVZ9wPPyTm1U6ZzEJF7PDVxvKxYHp+6/UAKOhIgD4p3jSR7or18CZiuPoETyphkHXir/S2QfMWknPfQL8j4b04/U0GhOVA3yqVRR7chl7RC8adt9noAZTuHuOfmxyutErEyAb2UwGzYumk2jl1WAA+ylxGdbI2lhZV7rOwhv9EkwNzcNWSVeRx3h8Vs9u6AfXxwsDYFeVGahphQBrDlt6nXsdwcr7J9KK+USMTcyfw+SQ64YBq4YIJ4yJ2LkdQRvZhIHatVilt7stH2K1yqJCphU3bJxBJpdu97joX/gQKXQ+jPcIDPVy795oAFejiwrWU2XB8Xp0z0NJfyZX4N+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RkhWjxSjuVn81A5GogH/7r/1IT+ZouwI0deRFr52DEI=; b=nBihdgfrhmSqtS3qOaW9/K6Pmz9QoP9IO/o6ZDtNYwvFPGybVJegH85rS9dpUSvOAtKgmlmpnifthein89c7c7lbGcStiZ1WHFEfst9fJuHz9ItUgOGjAncqmtIDhabdTxDgFbRNZhLbmefGMamyKci/UXmBwL4T2X7t5O3OgyMya+kzWM3HudYVV9h+XHene32ShNKXU17tWbp6I9YEPqR5VkODhN35HfXOkvN+7QKU79yMLY4GNWHtoFzZEY6JMJoeD3OfKfyWxouzZ+7HIHIVCWL8smL6W7Clh6Y67aJ6sM082Dd7M3wPMP4CC77i8rXv081AOcbuMheStqJprw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MN0PR11MB6207.namprd11.prod.outlook.com (2603:10b6:208:3c5::21) by MN2PR11MB4566.namprd11.prod.outlook.com (2603:10b6:208:24e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.8; Wed, 19 Aug 2026 10:18:41 +0000 Received: from MN0PR11MB6207.namprd11.prod.outlook.com ([fe80::52eb:929f:a8b2:139d]) by MN0PR11MB6207.namprd11.prod.outlook.com ([fe80::52eb:929f:a8b2:139d%4]) with mapi id 15.21.0339.007; Wed, 19 Aug 2026 10:18:41 +0000 Content-Type: multipart/alternative; boundary="------------3vXaw3FGysjUX0rS5qLZDKxw" Message-ID: <56c19f54-529f-4e91-9859-5add0afe0891@intel.com> Date: Wed, 19 Aug 2026 15:48:31 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] drm/drv: Convert wedged event string building to seq_buf To: Raag Jadav CC: , , , , , , , , , , , , , , References: <20260818133610.496374-2-mallesh.koujalagi@intel.com> Content-Language: en-US From: "Mallesh, Koujalagi" In-Reply-To: X-ClientProxiedBy: MA0PR01CA0083.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:ae::9) To MN0PR11MB6207.namprd11.prod.outlook.com (2603:10b6:208:3c5::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN0PR11MB6207:EE_|MN2PR11MB4566:EE_ X-MS-Office365-Filtering-Correlation-Id: b20872cd-d652-4003-87be-08defddb3d88 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|23010399003|376014|366016|1800799024|6133799003|56012099006|10067099003|4143699003|11063799006|8096899003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: P+X+PadbTsN0o4HwJdfl81P0lfaRL5pTgBBQdL+r2uFvzd1b6OZJdAgYAc9GE4ofXO2/E7oKuh6g1taUbwmsbSd2hR8D9gQ6EzBq+m+BcPn6Ij7bbd7QkGRstS3hoN5WmBwyGA5TNxqcj/h5ISiwfDuR2shZn2YMcggZzxbHMVcRsnelojlP/VuDg/etfwOVB/vYR6i+CF4tfEH+kuM4CFscyxGO4ze/IF+gnB+pq8z99evSUT5sI/C8dRIwFCsIW4Pueznr2qPfsg+hEt+mrh5qh8NFxQTOek/ujR8Q0HBNXSsVI67TishO0BdLTgIZo6/SA7Dp34NU3qFBH7I48QO0MpzGkgPg2FsrgdJ0ckbo/MwVyD+Vr0AIZz3SlufeMGS2msXP6zSf0oSCdC373NuV1Bkx0kqfHpl4ToBVXQai/lVl87aBT+GJRpHB3XXTOxiR1FbHA59REnoRIOdTFY4hbol4Si44VXonj071zdMyf+suJ2KJQ/nhuLxk1f1i0Pm01a9yVhIXY6/kpu1DZI+UyxxQuUI4SyJ1KtXLLS6c7f6WhmZrxnZTeRYA38xq8BNd/mbw8rzv6YHqryF9+g+5eDkrlhTVJqs9ylo0Ua1UuiVCQtQk9YaKe69aPmuVfBAt6nKfXOPDMWsyd4wBB+YA4JXYyXNhdGJ1dGjHSII= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN0PR11MB6207.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(376014)(366016)(1800799024)(6133799003)(56012099006)(10067099003)(4143699003)(11063799006)(8096899003)(22082099003)(18002099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Um1seFc1L3ZiREI0QTRWVzhOdEFKNEZabGZ3WGN6OEhsSnEvSzhqWHkxYXli?= =?utf-8?B?OFNlUUlLeS9ETVZnUk0zQUVuUDZnalRlTFdhSDBGdzlFUHR6Wm1CRkNSYXNr?= =?utf-8?B?UnhPTFo0akRFTDlkRWI0cU9ZVEtPS1lhMFhCUWQrQ1JqOUFXR1dKeVo1VDdy?= =?utf-8?B?OWQvTk1pU3VIazUxZEMyNXh4VjZnTUt2NW9DcFNtNjZKQk8yWW5DcGx1QWVQ?= =?utf-8?B?blFyUHRUQWxSd0F5eDZMQVlXT09YS0REeWlZRDdzV3lUWm5OS2JYSWMvWkJp?= =?utf-8?B?WDFIUjdwN2JGMEhDeUxGTmlNdTlRYWVUTkRsQ0VMdjhET2M2bHgzYzR4c3RV?= =?utf-8?B?enVxUkNaejhIVlZSdGVsZDNjOUh1dVN5VW80L3NtaTVQRDdjT3FoT0h0MzRv?= =?utf-8?B?Y1RJQ055ZllpM1E0bENYRjhYemxIUVVRcWszaDBTY05vdG9acnZDSCtYa2Js?= =?utf-8?B?UHFDSjNlaVlGTU9SSm1DK1BiRXhyQlFneHFMWllhTFhoYkdHZGd3S3RwKzNH?= =?utf-8?B?cmp6M3h0UmZjcFNUTWdHV3V4NEFibHhMd1BGclVCTjVXMTgrQVpmYjI0VDV5?= =?utf-8?B?TDZ6VTZvU2VHR1o3SWt3ekRxT21rN3pmc0RCYUVSUVBQNCt2RG9vZXJtVk54?= =?utf-8?B?OHBhSzh1VjU3SHJZb0JxQ1lpQ3ZLSm1nRE9Odklia3VRWUg0ckdZeENjbXpl?= =?utf-8?B?NFZnV3gxWlNBSEh5VVJNT3diNTdRd0s0clRYM3RWeG93cnpncFErUVlEZXdh?= =?utf-8?B?eXpWS095WXpzK1Vsd2orWTJYKzRpSDdpcnN1VFZ6ZHl3STZhemZKcWNISlhY?= =?utf-8?B?MTlUeU4zbTczTFB5enNFOVIxRXNCbWFFS1o0WXFQaHJ2eDNsdzJ6UWJwTy9J?= =?utf-8?B?MUJtMzQ2M0kvOFpaZVNwTzNxUkFhekI1NXVuT2hJZVAxeEVpczZUTnZnR0Va?= =?utf-8?B?L1E2aUQ5aTA5RWo1UVczaGZ6amVOb3Z5d0IvNVd2bDlqajdPa3RNalA4Z0Nn?= =?utf-8?B?clR1ekwvcU50ZzdMSEpyenhMT2tKczBUa05FMW9uOUlybGhBQjg4MEFiWXJp?= =?utf-8?B?Zk9pOTRsRFpnc3p5ZGx5eURTZEZOWldWZjNVcmNjY0plOWFpMU1XRS9Hc0FE?= =?utf-8?B?UGRnaDVTMElocWFZU2VNYm9waGQ1cWtPb2QzN0ZCcUQ4U1hHOVdicVVCOGNX?= =?utf-8?B?Z2tPdTA3Y2RRak9ndnJiblNnN0FkRFlsa2xhNUJEN2FVUE10aEtQdElPZmVv?= =?utf-8?B?WkFMT2pQQ0FHWEp5eHdFOFB4UEd0dFJqVXFRSXlOdUthNXBraTJjVkF4eExX?= =?utf-8?B?RjFZZlVxL1dMTFdlY09xZ05jc3BBQTRBd01sSEJnQy9Kdkw3aUhNcmlRMUJ1?= =?utf-8?B?YlNMQktMVEc4bmpTK2xaSEEycFVnaWtUd3I3L29LcSs2K1pMZ0RGcDVlMzhS?= =?utf-8?B?a3hnN1FwenhGak9kelNObFlua3BRQy83WXZYeFJINjJZUlJsN0toekFVSlh6?= =?utf-8?B?TkliVXBUUXgvbWNxSS91bU1hVyszRm0xWk9xOFg3Q1VwSm95bFQrVTN1bC9i?= =?utf-8?B?c1RCcjNQQUNOWTFCM0xPK3o1SWphaUVsSlRCcGJ1czM1bm5VVy9PV3pFMXFV?= =?utf-8?B?ZWFSKzRVbkZnbzU0RWJKYWFybnBkNmQrZkIrNW92aHZDYlpMSTRwczV5MVVC?= =?utf-8?B?dXZpb1dMb0hJcndoWlJINGtsVEJqelU5V204YSt6QjRTeC9rZVB4SzNwWlBi?= =?utf-8?B?MDRLbFAyM1NDRU1Nd0RLQk5SWlpsQUUvQ3psNG9ENm13U255bzhOcmswbi80?= =?utf-8?B?SWFnTWtNOUM4eXU5MXlCcUtZeThKSmFhODl4cUwvZDRJWGpqWnJDd0oxRUtC?= =?utf-8?B?R1NPWUZieXg5OUVnU1VZaS9PcGovSWl6bjhpVXJIWUxUTytJK3hxbW9zMmo2?= =?utf-8?B?TGU2U2ZyNmp5dDVyOUszZ2pHYXN4cHZWZWRtSEhrNlkvYXBkVXlDVjNPYzBq?= =?utf-8?B?WUcvMEkwTWFJWnF0VEFETjNPTTAvRlNxQWQ4ZjlJK256eEFMQlBHbldhUGUw?= =?utf-8?B?SStxOEg4M1BXRVUwVFVyWlJaM2hoemhWSWVJc3VxVmhGSlhPQ0VqS3d1c2NG?= =?utf-8?B?ZG1qNGt1MDRvT3ZQcmJDQlNwcGR1YmF5czJJMVVRMHJiaDFMVEZkajZSd002?= =?utf-8?B?Wis0dzJRSnJoUjV2VDJPMW9lMEpFenBqMmxsSXZzYTh0YXAwQitYUW1RZ2Q4?= =?utf-8?B?blBqbURlVTRCb3FHTXFTd2I4d3cvMURCaE5GZXFjQW8zYWhubEVyV3JVbXNp?= =?utf-8?B?N3hNcmJSeVZvUUJoaGsvOFIvRzdnOVplc1FFeU1ZYkNEMlkwM0YycTNMSDN1?= =?utf-8?Q?hrnBHyk3mowONJSQ=3D?= X-Exchange-RoutingPolicyChecked: rwZLa3nUC+PEcyt6MyUYVTEVPwEQnYZWt+UI+s8leDHHd5T+TK5hFqe6oPHIk7BlEqrvRL1IxTQRB/WPcPosuuQQdAmWKgdHAHyqKcTv6VL/lLNqYlDN6qIj+Pwn1FHgvG+1eW71nyUp+4rnh0UXN9vmAKyVKwXOZyJl6lCq+8HDPjTEYzXUvuZpAdZWu5nJmgfFf9Lel54Yfch1HlNMwJcNjvqze+EnseEe/OXdb0T4vg8+IuRTJyFvd+hLzv+xRdG3ZQDWL/omY713FHZxCZrz/5VxOl9Z6U/gWzqBUeCKAtEAQsw2tzijEAjC509kMYvxLYM/IXxKee/kQCuDgg== X-MS-Exchange-CrossTenant-Network-Message-Id: b20872cd-d652-4003-87be-08defddb3d88 X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6207.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2026 10:18:40.9178 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Mi1wUsEvMmTzn6u77VXojD9P0u7fDGEYy+eh8Q/pU//EwlMNjr+V7VS/qZ1ovrb27Tj01uRC8IMPDjfHpmhppeoFy59Vmbubu2FB6QLsUyw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4566 X-OriginatorOrg: intel.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --------------3vXaw3FGysjUX0rS5qLZDKxw Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 19-08-2026 09:58 am, Raag Jadav wrote: > On Tue, Aug 18, 2026 at 07:06:11PM +0530, Mallesh Koujalagi wrote: >> event_string[] has a fixed size of WEDGE_STR_LEN (32) bytes. >> The original scnprintf()-based loop required a manual pre-flight >> bounds check. >> >> Replace the manual bookkeeping with seq_buf, which tracks overflow >> internally. seq_buf_printf() writes each "method," token into the >> buffer. >> >> On overflow, len retains the position of the last >> successful write, so the trailing comma is stripped cleanly without >> including any partial method name in the uevent payload. >> >> Fixes: b7cf9f4ac1b8 ("drm: Introduce device wedged event") > This actually doesn't fix anything, it just adds a WARN() splat. > So I'm not sure if this is needed here. In previous implementation multiple recovery methods may exceed WEDGE_STR_LEN (32) that cause silently truncate a recovery method and emit a malformed uevent string containing a partial token, however using seq_buf makes overflow explicit, when it occurs, emits a WARN and include complete recovery name in the uevent string so IMO, it's fix. > >> Signed-off-by: Mallesh Koujalagi > Assuming this is tested and there are no regressions. > > Reviewed-by: Raag Jadav Thanks Raag! The changes are tested and no regressions were observed in my testing. Thanks, -/Mallesh --------------3vXaw3FGysjUX0rS5qLZDKxw Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 8bit


On 19-08-2026 09:58 am, Raag Jadav wrote:
On Tue, Aug 18, 2026 at 07:06:11PM +0530, Mallesh Koujalagi wrote:

event_string[] has a fixed size of WEDGE_STR_LEN (32) bytes.
The original scnprintf()-based loop required a manual pre-flight
bounds check.

Replace the manual bookkeeping with seq_buf, which tracks overflow
internally. seq_buf_printf() writes each "method," token into the
buffer.

On overflow, len retains the position of the last
successful write, so the trailing comma is stripped cleanly without
including any partial method name in the uevent payload.

Fixes: b7cf9f4ac1b8 ("drm: Introduce device wedged event")

This actually doesn't fix anything, it just adds a WARN() splat.
So I'm not sure if this is needed here.

In previous implementation multiple recovery methods may exceed WEDGE_STR_LEN (32) that

cause silently truncate a recovery method and emit a malformed uevent string containing a 

partial token, however using seq_buf makes overflow

explicit, when it occurs, emits a WARN and include complete recovery name

in the uevent string so IMO, it's fix. 



Signed-off-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>

Assuming this is tested and there are no regressions.

Reviewed-by: Raag Jadav <raag.jadav@intel.com>

Thanks Raag!

The changes are tested and no regressions were observed in my testing.


Thanks,

-/Mallesh


    

  


--------------3vXaw3FGysjUX0rS5qLZDKxw--